Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Vittorio Giovara <vittorio.giovara@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add ambient viewing environment packet side data.
Date: Tue, 30 Jan 2024 14:38:49 +0100
Message-ID: <CABLWnS9cwQeLUDm1XRCDrPKnvcUhhS-Wf8_-5oaqezgpUCTgAQ@mail.gmail.com> (raw)
In-Reply-To: <ZbjofHVcNuDi1ZSy@sakura.greysector.net>

On Tue, Jan 30, 2024 at 1:16 PM Dominik 'Rathann' Mierzejewski <
dominik@greysector.net> wrote:

> On Wednesday, 06 September 2023 at 18:27, Cosmin Stejerean via
> ffmpeg-devel wrote:
> >
> >
> > > On Aug 17, 2023, at 11:36 PM, Damiano Galassi <damiog@gmail.com>
> wrote:
> > >
> > > Ping
> > >
> >
> > I believe this is still waiting for a FATE test to be added.
>
> Could this be added without a FATE test?
>

Ideally no, is there any concern with sharing such a sample?

diff --git a/libavcodec/packet.h b/libavcodec/packet.h
index f28e7e7011..199baad763 100644
--- a/libavcodec/packet.h
+++ b/libavcodec/packet.h
@@ -299,6 +299,13 @@ enum AVPacketSideDataType {
      */
     AV_PKT_DATA_DYNAMIC_HDR10_PLUS,

+    /**
+     * Ambient viewing environment metadata, as defined by H.274.. This
metadata

Nit: double ".."
-- 
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-01-30 13:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-16  6:21 Damiano Galassi
2023-07-16  6:21 ` [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document Damiano Galassi
2023-08-18  6:36 ` [FFmpeg-devel] [PATCH v2 1/2] avcodec: add ambient viewing environment packet side data Damiano Galassi
2023-09-06  9:15   ` Dominik 'Rathann' Mierzejewski
     [not found]   ` <0E6F4660-BDAD-42BD-995F-1777131EEE1B@cosmin.at>
2023-09-06 16:27     ` Cosmin Stejerean via ffmpeg-devel
2024-01-30 12:15       ` Dominik 'Rathann' Mierzejewski
2024-01-30 13:38         ` Vittorio Giovara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABLWnS9cwQeLUDm1XRCDrPKnvcUhhS-Wf8_-5oaqezgpUCTgAQ@mail.gmail.com \
    --to=vittorio.giovara@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git