From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4A60942BEC for ; Wed, 12 Jan 2022 14:24:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 83D3D68AB82; Wed, 12 Jan 2022 16:23:58 +0200 (EET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 409C3687FCE for ; Wed, 12 Jan 2022 16:23:52 +0200 (EET) Received: by mail-wm1-f54.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso3568932wmj.2 for ; Wed, 12 Jan 2022 06:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=62eEcmZmBCsR+LmErvjCQB5MT9IY0oWuUllPadBC8f0=; b=OXs1ya9u1TKHujjXmTaV8/6YIuDyxrGRgJ2KxqWTf5CG9ZpZyzhW82v5lZ2MnIo90s X64NMp1jLzyeKdY8RTTsBvt/6ExIVVkPUzdo1f9rfoJNc3AkNb9NCzRikej9T5t27R0J 1RCCoXqJWm5pIwEOo1EiUIh5fjnfxiX/Y7D0KBLWulLAvW3yLPlwygsB0Xc9qXHQFUIa L6C82ODPTqju68VSgqz3vj2aMQVCo4LZ/ujAO7d9+hBolQR8YX5oN5Fbqi7QvefBgDuX jkalG3HM8+XMduQELYl8q9B7t8alc8T3Uy0TVyCM7TlrPTDQSyYzG4gN8A281HdX6dbh IowQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=62eEcmZmBCsR+LmErvjCQB5MT9IY0oWuUllPadBC8f0=; b=YVrqsprsW8h8aN3Fud7U8YI9geIzyJ7IPz+9W7iIEFa086rIq5fAfgTShQkNFgadRr fq3gAjIWwz/7iqm2cOeTG2Zn74Pre7Jr+FEM/5qV0bUQ+hbGcqlbuhIx9fOA1d4M0voy ghaYcj8Wjppg7rCf1riGUriCCxX+7lTVDotzT3ZrLdYfIE6FJNBflbRQsFZcgtApFA5K qwHG95xm7pXSaA8SM8KG584fucoLRnw/TsDIsknWFmZd+sBAhvcYtjPjg/pX/kLwrWqj OlLYFn7y6OEOS2cuqr78wDcRPsm/6z0VbNOY999qxAP0A3NWxdyu/hWJd1j1bcXB/izU ajHA== X-Gm-Message-State: AOAM533LF/sJp3A4ORpnzuOYdj4rk6/Co41Rq3EviT/Pz7Oa/PFd/gme 2v+bhpqS0MU+OpEFj22BSoU67N+XlpRXICqx3ox5maUkmBMrSQ== X-Google-Smtp-Source: ABdhPJyD8OC6fRF9OFLdoeWrs9GiXZQKoVjfHz1Za+rLHwluvfKaPtDyly0dytXYoDVlkgpvb7ry6BXZPt8wrsno68w= X-Received: by 2002:a1c:2544:: with SMTP id l65mr7190462wml.101.1641997430871; Wed, 12 Jan 2022 06:23:50 -0800 (PST) MIME-Version: 1.0 References: <20220105135941.85715-1-vittorio.giovara@gmail.com> <20220105151506.74794-1-vittorio.giovara@gmail.com> <164198110935.2375.9814405413495189335@lain.red.khirnov.net> In-Reply-To: <164198110935.2375.9814405413495189335@lain.red.khirnov.net> From: Vittorio Giovara Date: Wed, 12 Jan 2022 15:23:39 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] vf_tonemap: Fix order of planes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jan 12, 2022 at 10:51 AM Anton Khirnov wrote: > Quoting Vittorio Giovara (2022-01-05 16:15:06) > > This resulted in a dimmed tonemapping due to bad resulting luma > > calculation. > > > > Found by: Derek Buitenhuis > > > > Signed-off-by: Vittorio Giovara > > --- > > libavfilter/vf_tonemap.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/libavfilter/vf_tonemap.c b/libavfilter/vf_tonemap.c > > index 363df8034b..644c9fd9e3 100644 > > --- a/libavfilter/vf_tonemap.c > > +++ b/libavfilter/vf_tonemap.c > > @@ -120,17 +120,17 @@ static void tonemap(TonemapContext *s, AVFrame > *out, const AVFrame *in, > > const AVPixFmtDescriptor *desc, int x, int y, > double peak) > > { > > const float *r_in = (const float *)(in->data[0] + x * > desc->comp[0].step + y * in->linesize[0]); > > - const float *b_in = (const float *)(in->data[1] + x * > desc->comp[1].step + y * in->linesize[1]); > > - const float *g_in = (const float *)(in->data[2] + x * > desc->comp[2].step + y * in->linesize[2]); > > + const float *g_in = (const float *)(in->data[1] + x * > desc->comp[1].step + y * in->linesize[1]); > > + const float *b_in = (const float *)(in->data[2] + x * > desc->comp[2].step + y * in->linesize[2]); > > I'm confused by this, the filter seems to use GBR pixel format. > hmmm right, so the first and last elements are swapped... i'm possibly implying the order in a wrong way, let me send a more generic version of this then -- Vittorio _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".