Re: [FFmpeg-devel] [PATCH] exclude currently unused 0.17% of fate samples from rsync

[Vittorio Giovara <vittorio.giovara@gmail.com>]

On Thu, Aug 10, 2023 at 5:27 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> Several developers where upset, that from the over 1gb of fate samples 2mb
> are only used
> by the ffmpeg branch with SDR support in https://git.ffmpeg.org/libavradio
>
> This avoids these samples from being downloaded or synchronized.
> It should have no real world effect on anything of course if 0.17% more or
> less is downloaded but maybe it makes some people happier.
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  configure      | 2 ++
>  tests/Makefile | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index 932998b8d6..f859701ebd 100755
> --- a/configure
> +++ b/configure
> @@ -2384,6 +2384,7 @@ TOOLCHAIN_FEATURES="
>      inline_asm_nonlocal_labels
>      pragma_deprecated
>      rsync_contimeout
> +    rsync_exclude
>      symver_asm_label
>      symver_gnu_asm
>      vfp_args
> @@ -6968,6 +6969,7 @@ disabled makeinfo_html && texi2html --help 2>
> /dev/null | grep -q 'init-file' &&
>  perl -v            > /dev/null 2>&1 && enable perl      || disable perl
>  pod2man --help     > /dev/null 2>&1 && enable pod2man   || disable pod2man
>  rsync --help 2> /dev/null | grep -q 'contimeout' && enable
> rsync_contimeout || disable rsync_contimeout
> +rsync --help 2> /dev/null | grep -q -- '--exclude' && enable
> rsync_exclude || disable rsync_exclude
>  xmllint --version  > /dev/null 2>&1 && enable xmllint   || disable xmllint
>
>  # check V4L2 codecs available in the API
> diff --git a/tests/Makefile b/tests/Makefile
> index e09f30a0fc..45db76695e 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -265,6 +265,7 @@ FATE_EXTERN                   += $(FATE_EXTERN-yes)
> $(FATE_SAMPLES_FASTSTART)
>  FATE += $(FATE-yes)
>
>  RSYNC_OPTIONS-$(HAVE_RSYNC_CONTIMEOUT) += --contimeout=60
> +RSYNC_OPTIONS-$(HAVE_RSYNC_EXCLUDE)    += --exclude=/sdr/
>

This causes a list of folders to be maintained in the Makefile code which
I'm not sure is kosher
Would it not be simpler to just delete the sdr folder?
-- 
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".