Re: [FFmpeg-devel] [PATCH v2] avcodec/libkvazaar: Respect codec context color settings.

[Vittorio Giovara <vittorio.giovara@gmail.com>]

On Fri, Sep 29, 2023 at 5:12 PM John Mather via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:

> This patch makes the libkvazaar encoder respect color settings that are
> present on the codec context, including color range, primaries, transfer
> function and colorspace.
> ---
>  libavcodec/libkvazaar.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
> index 2ef34dd82e..984f78ba65 100644
> --- a/libavcodec/libkvazaar.c
> +++ b/libavcodec/libkvazaar.c
> @@ -101,6 +101,15 @@ FF_ENABLE_DEPRECATION_WARNINGS
>          cfg->rc_algorithm = KVZ_LAMBDA;
>      }
>
> +    if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED)
> +        cfg->vui.fullrange = avctx->color_range == AVCOL_RANGE_JPEG;
> +    if (avctx->color_primaries != AVCOL_PRI_UNSPECIFIED)
> +        cfg->vui.colorprim = avctx->color_primaries;
> +    if (avctx->color_trc != AVCOL_TRC_UNSPECIFIED)
> +        cfg->vui.transfer = avctx->color_trc;
> +    if (avctx->colorspace != AVCOL_SPC_UNSPECIFIED)
> +        cfg->vui.colormatrix = avctx->colorspace;
>

since both avcodec and the library follow the same standard, you could
avoid checking for UNSPECIFIED entirely and just assign the value there
-- 
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".