Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

[Vittorio Giovara <vittorio.giovara@gmail.com>]

On Sun, Jun 23, 2024 at 1:16 AM James Almer <jamrial@gmail.com> wrote:

> Given that a video stream/frame may have only one or both views coded with
> the packing information being unavailable, this commit adds a new type
> value
> AV_STEREO3D_UNSPEC for this purpose.
>

not to bikeshed the name, but why UNSPEC instead of UNKNOWN?
Vittorio


> The most common case for this is container level signaling of Stereo3D
> video
> where the specifics are defined at the bitstream level.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavutil/stereo3d.c | 1 +
>  libavutil/stereo3d.h | 6 ++++++
>  2 files changed, 7 insertions(+)
>
> diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c
> index 37cf093099..1f944e9cac 100644
> --- a/libavutil/stereo3d.c
> +++ b/libavutil/stereo3d.c
> @@ -65,6 +65,7 @@ static const char * const stereo3d_type_names[] = {
>      [AV_STEREO3D_SIDEBYSIDE_QUINCUNX] = "side by side (quincunx
> subsampling)",
>      [AV_STEREO3D_LINES]               = "interleaved lines",
>      [AV_STEREO3D_COLUMNS]             = "interleaved columns",
> +    [AV_STEREO3D_UNSPEC]              = "unspecified",
>  };
>
>  static const char * const stereo3d_view_names[] = {
> diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h
> index 9a004d88a1..deddecfb36 100644
> --- a/libavutil/stereo3d.h
> +++ b/libavutil/stereo3d.h
> @@ -136,6 +136,12 @@ enum AVStereo3DType {
>       * @endcode
>       */
>      AV_STEREO3D_COLUMNS,
> +
> +    /**
> +     * Video may be monoscopic, or stereoscopic where the
> +     * packing is unspecified.
> +     */
> +    AV_STEREO3D_UNSPEC,
>  };
>
>  /**
> --
> 2.45.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>


-- 
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".