From: Vittorio Giovara <vittorio.giovara@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions
Date: Tue, 28 Jan 2025 06:11:33 +0100
Message-ID: <CABLWnS89kGEbkWX_HDREouf5Df1FfTpzWrPXpzPBvLf+dsJtnw@mail.gmail.com> (raw)
In-Reply-To: <20250125203841.GL4991@pb2>
On Sat, Jan 25, 2025 at 9:38 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> On Thu, Jan 23, 2025 at 10:27:47PM +0100, Michael Niedermayer wrote:
> > On Wed, Jan 22, 2025 at 09:36:09PM +0100, Michael Niedermayer wrote:
> > > This blocks disallowed extensions from probing
> > > It also requires all available segments to have matching extensions to
> the format
> > > mpegts is treated independent of the extension
> > >
> > > It is recommended to set the whitelists correctly
> > > instead of depending on extensions, but this should help a bit,
> > > and this is easier to backport
> > >
> > > Fixes: CVE-2023-6602 II. HLS Force TTY Demuxer
> > > Fixes: CVE-2023-6602 IV. HLS XBIN Demuxer DoS Amplification
> > >
> > > The other parts of CVE-2023-6602 have been fixed by prior commits
> > >
> > > Found-by: Harvey Phillips of Amazon Element55 (element55)
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > > doc/demuxers.texi | 7 +++++++
> > > libavformat/hls.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 57 insertions(+)
> >
> > I intend to apply this patchset soon so it receives some testing before
> 7.1.1
>
> will apply
>
Should this be backported to other stable releases since it's a CVE?
--
Vittorio
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-01-28 5:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 20:36 [FFmpeg-devel] [PATCH 1/2] Revert "avformat/mpegts: Add standard extension so hls can check in extension_picky mode" Michael Niedermayer
2025-01-22 20:36 ` [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions Michael Niedermayer
2025-01-22 22:47 ` Kieran Kunhya via ffmpeg-devel
2025-01-23 0:11 ` Michael Niedermayer
2025-01-23 21:54 ` Kieran Kunhya via ffmpeg-devel
2025-01-23 22:35 ` Michael Niedermayer
2025-01-23 21:27 ` Michael Niedermayer
2025-01-25 20:38 ` Michael Niedermayer
2025-01-28 5:11 ` Vittorio Giovara [this message]
2025-01-28 12:14 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABLWnS89kGEbkWX_HDREouf5Df1FfTpzWrPXpzPBvLf+dsJtnw@mail.gmail.com \
--to=vittorio.giovara@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git