From: Vittorio Giovara <vittorio.giovara@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter
Date: Wed, 13 Dec 2023 05:06:46 -0500
Message-ID: <CABLWnS-p=eBYBwUbdnEUdw9L753sZSZoqtGGV1s-GXobTN_9Bw@mail.gmail.com> (raw)
In-Reply-To: <ZXgTEtcc+mOvely2@phare.normalesup.org>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Tue, Dec 12, 2023 at 3:00 AM Nicolas George <george@nsup.org> wrote:
> Vittorio Giovara (12023-12-11):
> > This is an older filter I wrote and never got around publishing.
> > It can be used to generate a distortion effect like
> > https://vimeo.com/104938599?share=copy
> > Please see attached.
>
> Your code is doing in request_frame() what should be done in
> filter_frame(). That will work in simple linear graphs but not in
> graphs with branches and/or time shifts. See doc/filter_design.txt for
> details.
>
Thanks for the review, attached the proposed changes.
--
Vittorio
[-- Attachment #2: 0001-Add-new-vf_tiltandshift-filter.patch --]
[-- Type: application/octet-stream, Size: 21844 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-13 10:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:51 Vittorio Giovara
2023-12-12 8:00 ` Nicolas George
2023-12-13 10:06 ` Vittorio Giovara [this message]
2023-12-15 17:36 ` Andreas Rheinhardt
2023-12-15 20:12 ` Vittorio Giovara
2023-12-20 19:43 ` Vittorio Giovara
2023-12-20 19:50 ` Nicolas George
2023-12-20 19:56 ` Vittorio Giovara
2023-12-21 21:43 ` Vittorio Giovara
2023-12-22 15:33 ` Paul B Mahol
2023-12-22 15:40 ` Ronald S. Bultje
2023-12-22 21:48 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABLWnS-p=eBYBwUbdnEUdw9L753sZSZoqtGGV1s-GXobTN_9Bw@mail.gmail.com' \
--to=vittorio.giovara@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git