From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A6CED45492 for ; Wed, 1 Mar 2023 20:32:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5D73068B09D; Wed, 1 Mar 2023 22:32:17 +0200 (EET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D455168AAD9 for ; Wed, 1 Mar 2023 22:32:10 +0200 (EET) Received: by mail-pf1-f169.google.com with SMTP id z11so8763825pfh.4 for ; Wed, 01 Mar 2023 12:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5gobIuRTC2kn8483nPDAlJCf80raHLXAeggFw4fZcdg=; b=R8G8gxJb6otNjVYcbiFWnKlzuGoVP/hNa3ZTN1lbg5aw5TLsOf2cqFLf258WKR5Xfg BStPKNwJ3TIAjWgct/EqlhIqRmZ8lpu+2X6Hmha3sfUzZLG8/gFTWWc7pfIZUrVKSWlQ Z6SS2L4ESoMiq3qcmY5TCAa+J2IWmHJoUjgdIY4scKeXXKF0VrloFNWWT4T1RrxjxyXH ztRFguqkOAsaxA/jJZA83LhpOdBiOKlIBhvTbCpn9uhVQ5xRGn+lHsgB1Wl9kRTrS+Ng W/kjoC9Rgu/W4/DKeivZqfP5JCRlRjF/Hw9HRz3UGJe1zcE7b/w315vYO5KDwezI66gI FyUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5gobIuRTC2kn8483nPDAlJCf80raHLXAeggFw4fZcdg=; b=NLVsYtmHPoszsgN8yoS9580IFYNVkmgaUlyskd97oKyn1/pEFDYe83k/YPz1Cea98Q Zd9MDdOXBv6r06apgDNRs6vT0P1Oy8jrRJXwNMdXkrp0yPaAm9Sn8A12Sig0RiqJvjZt dHxbAiSWxCwwhf5bQJFNhw0gl/acXft/DNTU4OQZV1aUf0NW1/JmueTzhmyJ74J7DW6w Fw0TIut1/vN/Snuy2D/GyrSQn5NNqfyfNK2auesv0NEnPZFF56QCipBe37is++c3fxsg 5oct7Bqy6rJPJ7HapRVoBE5kkDy/5cgDH6halKIWc7fnNb3zgoO4Ezw4TfQeVVIY4PRm Gzfg== X-Gm-Message-State: AO0yUKVuMlii0q/DbJQ31594NWmPZnQZIp0zYL8Xb7/1KJxdrg52vaMr QUGg87lFglsBnA1FK2bFL4iL3PloEtObp9bMEgdvtB/223hAG+UPRU3/zg== X-Google-Smtp-Source: AK7set+7VP0BcKsA+jLQDNDtGhOBHTy0zIK+2XKPwDb8BBQpHOfXQvggJQ05RExHRtY+ZLBYfWMtGHrN1gfi40bMC3I= X-Received: by 2002:a05:6a02:117:b0:502:ecb9:4f23 with SMTP id bg23-20020a056a02011700b00502ecb94f23mr2972829pgb.5.1677702727736; Wed, 01 Mar 2023 12:32:07 -0800 (PST) MIME-Version: 1.0 References: <20230301185008.2167529-1-jdorfman@google.com> <8592e078-de2d-4bb8-9e60-872a0328fb5b@gmail.com> In-Reply-To: From: Jeremy Dorfman Date: Wed, 1 Mar 2023 15:31:55 -0500 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/h264dec: avoid arithmetic on null pointers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: T24gV2VkLCBNYXIgMSwgMjAyMyBhdCAzOjIy4oCvUE0gSmVyZW15IERvcmZtYW4gPGpkb3JmbWFu QGdvb2dsZS5jb20+IHdyb3RlOgo+Cj4gT24gV2VkLCBNYXIgMSwgMjAyMyBhdCAyOjA34oCvUE0g SmFtZXMgQWxtZXIgPGphbXJpYWxAZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiAzLzEvMjAy MyAzOjUwIFBNLCBKZXJlbXkgRG9yZm1hbiB3cm90ZToKPiA+ID4gbnVsbCBwb2ludGVyIGFyaXRo bWV0aWMgaXMgdW5kZWZpbmVkIGJlaGF2aW9yIGluIEMuCj4gPiA+IC0tLQo+ID4gPiAgIGxpYmF2 Y29kZWMvaDI2NGRlYy5jIHwgNCArKy0tCj4gPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2xpYmF2Y29k ZWMvaDI2NGRlYy5jIGIvbGliYXZjb2RlYy9oMjY0ZGVjLmMKPiA+ID4gaW5kZXggMmQ2OTE3MzFj NS4uZWY2OThmMjYzMCAxMDA2NDQKPiA+ID4gLS0tIGEvbGliYXZjb2RlYy9oMjY0ZGVjLmMKPiA+ ID4gKysrIGIvbGliYXZjb2RlYy9oMjY0ZGVjLmMKPiA+ID4gQEAgLTkxMiw4ICs5MTIsOCBAQCBz dGF0aWMgaW50IGZpbmFsaXplX2ZyYW1lKEgyNjRDb250ZXh0ICpoLCBBVkZyYW1lICpkc3QsIEgy NjRQaWN0dXJlICpvdXQsIGludCAqZwo+ID4gPiAgICAgICAgICAgICAgIGF2X2xvZyhoLT5hdmN0 eCwgQVZfTE9HX0RFQlVHLCAiRHVwbGljYXRpbmcgZmllbGQgJWQgdG8gZmlsbCBtaXNzaW5nXG4i LCBmaWVsZCk7Cj4gPiA+Cj4gPiA+ICAgICAgICAgICAgICAgZm9yIChwID0gMDsgcDw0OyBwKysp IHsKPiA+ID4gLSAgICAgICAgICAgICAgICBkc3RfZGF0YVtwXSA9IGYtPmRhdGFbcF0gKyAoZmll bGReMSkqZi0+bGluZXNpemVbcF07Cj4gPiA+IC0gICAgICAgICAgICAgICAgc3JjX2RhdGFbcF0g PSBmLT5kYXRhW3BdICsgIGZpZWxkICAgKmYtPmxpbmVzaXplW3BdOwo+ID4gPiArICAgICAgICAg ICAgICAgIGRzdF9kYXRhW3BdID0gZi0+ZGF0YVtwXSA/IGYtPmRhdGFbcF0gKyAoZmllbGReMSkq Zi0+bGluZXNpemVbcF0gOiBOVUxMOwo+ID4gPiArICAgICAgICAgICAgICAgIHNyY19kYXRhW3Bd ID0gZi0+ZGF0YVtwXSA/IGYtPmRhdGFbcF0gKyAgZmllbGQgICAqZi0+bGluZXNpemVbcF0gOiBO VUxMOwo+ID4gPiAgICAgICAgICAgICAgICAgICBsaW5lc2l6ZXNbcF0gPSAyKmYtPmxpbmVzaXpl W3BdOwo+ID4gPiAgICAgICAgICAgICAgIH0KPiA+Cj4gPiBQcm9iYWJseSBjbGVhbmVyIGFuZCBj bGVhcmVyIHRvIGRvIGl0IGxpa2UgdGhpczoKPiA+Cj4gPiBkc3RfZGF0YVtwXSA9IEZGX1BUUl9B REQoZi0+ZGF0YVtwXSwgKGZpZWxkXjEpKmYtPmxpbmVzaXplW3BdKTsKPiA+IHNyY19kYXRhW3Bd ID0gRkZfUFRSX0FERChmLT5kYXRhW3BdLCAgZmllbGQgICAqZi0+bGluZXNpemVbcF0pOwo+Cj4g VGhhbmsgeW91IGZvciB0aGUgZmVlZGJhY2suIFRoYXQgc2VlbXMgcmVhc29uYWJsZSB0byBtZTsg SSB3YXNuJ3QgYXdhcmUgb2YgRkZfUFRSX0FERC4KPgo+IC0tLQo+ICBsaWJhdmNvZGVjL2gyNjRk ZWMuYyB8IDUgKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9saWJhdmNvZGVjL2gyNjRkZWMuYyBiL2xpYmF2Y29k ZWMvaDI2NGRlYy5jCj4gaW5kZXggMmQ2OTE3MzFjNS4uMGFjMDRiYWE0ZCAxMDA2NDQKPiAtLS0g YS9saWJhdmNvZGVjL2gyNjRkZWMuYwo+ICsrKyBiL2xpYmF2Y29kZWMvaDI2NGRlYy5jCj4gQEAg LTMxLDYgKzMxLDcgQEAKPgo+ICAjaW5jbHVkZSAibGliYXZ1dGlsL2F2YXNzZXJ0LmgiCj4gICNp bmNsdWRlICJsaWJhdnV0aWwvaW1ndXRpbHMuaCIKPiArI2luY2x1ZGUgImxpYmF2dXRpbC9pbnRl cm5hbC5oIgo+ICAjaW5jbHVkZSAibGliYXZ1dGlsL29wdC5oIgo+ICAjaW5jbHVkZSAibGliYXZ1 dGlsL3RocmVhZC5oIgo+ICAjaW5jbHVkZSAibGliYXZ1dGlsL3ZpZGVvX2VuY19wYXJhbXMuaCIK PiBAQCAtOTEyLDggKzkxMyw4IEBAIHN0YXRpYyBpbnQgZmluYWxpemVfZnJhbWUoSDI2NENvbnRl eHQgKmgsIEFWRnJhbWUgKmRzdCwgSDI2NFBpY3R1cmUgKm91dCwgaW50ICpnCj4gICAgICAgICAg ICAgIGF2X2xvZyhoLT5hdmN0eCwgQVZfTE9HX0RFQlVHLCAiRHVwbGljYXRpbmcgZmllbGQgJWQg dG8gZmlsbCBtaXNzaW5nXG4iLCBmaWVsZCk7Cj4KPiAgICAgICAgICAgICAgZm9yIChwID0gMDsg cDw0OyBwKyspIHsKPiAtICAgICAgICAgICAgICAgIGRzdF9kYXRhW3BdID0gZi0+ZGF0YVtwXSAr IChmaWVsZF4xKSpmLT5saW5lc2l6ZVtwXTsKPiAtICAgICAgICAgICAgICAgIHNyY19kYXRhW3Bd ID0gZi0+ZGF0YVtwXSArICBmaWVsZCAgICpmLT5saW5lc2l6ZVtwXTsKPiArICAgICAgICAgICAg ICAgIGRzdF9kYXRhW3BdID0gRkZfUFRSX0FERChmLT5kYXRhW3BdLCAoZmllbGReMSkqZi0+bGlu ZXNpemVbcF0pOwo+ICsgICAgICAgICAgICAgICAgc3JjX2RhdGFbcF0gPSBGRl9QVFJfQUREKGYt PmRhdGFbcF0sICBmaWVsZCAgICpmLT5saW5lc2l6ZVtwXSk7Cj4gICAgICAgICAgICAgICAgICBs aW5lc2l6ZXNbcF0gPSAyKmYtPmxpbmVzaXplW3BdOwo+ICAgICAgICAgICAgICB9Cj4KCkkgYXBv bG9naXplIGZvciB0aGUgbWFuZ2xlZCBwYXRjaCBhbmQgc3BhbS4gSG9wZWZ1bGx5IHRoaXMgY29t ZXMKdGhyb3VnaCBhcyB0ZXh0L3BsYWluIHdpdGhvdXQgdGhlIGNvcnJ1cHRlZCBwYXRjaDoKCi0t LQogbGliYXZjb2RlYy9oMjY0ZGVjLmMgfCA1ICsrKy0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYmF2Y29kZWMvaDI2NGRl Yy5jIGIvbGliYXZjb2RlYy9oMjY0ZGVjLmMKaW5kZXggMmQ2OTE3MzFjNS4uMGFjMDRiYWE0ZCAx MDA2NDQKLS0tIGEvbGliYXZjb2RlYy9oMjY0ZGVjLmMKKysrIGIvbGliYXZjb2RlYy9oMjY0ZGVj LmMKQEAgLTMxLDYgKzMxLDcgQEAKCiAjaW5jbHVkZSAibGliYXZ1dGlsL2F2YXNzZXJ0LmgiCiAj aW5jbHVkZSAibGliYXZ1dGlsL2ltZ3V0aWxzLmgiCisjaW5jbHVkZSAibGliYXZ1dGlsL2ludGVy bmFsLmgiCiAjaW5jbHVkZSAibGliYXZ1dGlsL29wdC5oIgogI2luY2x1ZGUgImxpYmF2dXRpbC90 aHJlYWQuaCIKICNpbmNsdWRlICJsaWJhdnV0aWwvdmlkZW9fZW5jX3BhcmFtcy5oIgpAQCAtOTEy LDggKzkxMyw4IEBAIHN0YXRpYyBpbnQgZmluYWxpemVfZnJhbWUoSDI2NENvbnRleHQgKmgsIEFW RnJhbWUKKmRzdCwgSDI2NFBpY3R1cmUgKm91dCwgaW50ICpnCiAgICAgICAgICAgICBhdl9sb2co aC0+YXZjdHgsIEFWX0xPR19ERUJVRywgIkR1cGxpY2F0aW5nIGZpZWxkICVkIHRvCmZpbGwgbWlz c2luZ1xuIiwgZmllbGQpOwoKICAgICAgICAgICAgIGZvciAocCA9IDA7IHA8NDsgcCsrKSB7Ci0g ICAgICAgICAgICAgICAgZHN0X2RhdGFbcF0gPSBmLT5kYXRhW3BdICsgKGZpZWxkXjEpKmYtPmxp bmVzaXplW3BdOwotICAgICAgICAgICAgICAgIHNyY19kYXRhW3BdID0gZi0+ZGF0YVtwXSArICBm aWVsZCAgICpmLT5saW5lc2l6ZVtwXTsKKyAgICAgICAgICAgICAgICBkc3RfZGF0YVtwXSA9IEZG X1BUUl9BREQoZi0+ZGF0YVtwXSwgKGZpZWxkXjEpKmYtPmxpbmVzaXplW3BdKTsKKyAgICAgICAg ICAgICAgICBzcmNfZGF0YVtwXSA9IEZGX1BUUl9BREQoZi0+ZGF0YVtwXSwgIGZpZWxkICAgKmYt PmxpbmVzaXplW3BdKTsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdApmZm1wZWctZGV2ZWxAZmZtcGVnLm9yZwpo dHRwczovL2ZmbXBlZy5vcmcvbWFpbG1hbi9saXN0aW5mby9mZm1wZWctZGV2ZWwKClRvIHVuc3Vi c2NyaWJlLCB2aXNpdCBsaW5rIGFib3ZlLCBvciBlbWFpbApmZm1wZWctZGV2ZWwtcmVxdWVzdEBm Zm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgo=