Re: [FFmpeg-devel] Graphprint Patches Overview

[Kieran Kunhya via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

It's obvious basic testing was not done on this patchset seeing the scale
of memory leaks.

I would like the TC to decide on reverting and proper resubmission later.

Kieran

On Wed, 21 May 2025, 21:37 softworkz ., <softworkz-at-hotmail.com@ffmpeg.org>
wrote:

>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> softworkz .
> > Sent: Mittwoch, 21. Mai 2025 22:20
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] Graphprint Patches Overview
> >
> >
> >
> > > -----Original Message-----
> > > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Kyle
> > Swanson
> > > Sent: Mittwoch, 21. Mai 2025 22:11
> > > To: FFmpeg development discussions and patches <
> ffmpeg-devel@ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] Graphprint Patches Overview
> > >
> > > Hi,
> > >
> > > On Wed, May 21, 2025 at 4:00 AM Kieran Kunhya via ffmpeg-devel
> > > <ffmpeg-devel@ffmpeg.org> wrote:
> > > > Can we just revert the whole set until it's cleaned up properly?
> > > >
> > > > There are more patches to fix issues than the set itself. This is
> > > > understandable if it's a bit architectural change like threading but
> it's
> > > > not.
> > >
> > > I agree with Kieran, revert. This was not ready to be pushed IMO.
> > >
> > > Thanks,
> > > Kyle
> > > _______________________________________________
> >
> > I think the least that can be expected from somebody making such a
> > request is that they provide specific reasoning after having taken
> > a closer look - which the two of you apparently haven't.
> >
> > Thanks
> > sw
> >
> > _______________________________________________
>
> Here's a branch with the pending fixes included:
>
> https://github.com/softworkz/FFmpeg/tree/submit_graphprint_allfixes
>
> Please explain specifically what you want to have reverted and why.
>
> Thanks
> sw
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".