From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5E06E4C3F4 for ; Mon, 4 Aug 2025 00:08:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EAC4C6881AC; Mon, 4 Aug 2025 03:08:48 +0300 (EEST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 70A206881AC for ; Mon, 4 Aug 2025 03:08:42 +0300 (EEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-7170344c100so22873587b3.0 for ; Sun, 03 Aug 2025 17:08:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754266121; x=1754870921; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AvNeqkuTEcHbas4ETvHNC5cFRa1c3iJth+Tqt6GMQKE=; b=O77zOXH7ur0pyiqVSh0o39+9/6eWaOSv1zSH8JwS9Eg2JP+3w8kKAA39HF0uGtn/uA jC09UAGPD0URNR5t/l31JpUBJHpeT6BLzXGlO/0bLKyvtqtg3f0BdB8usQpj2OwWPpn/ 1Za1ByHfsTMGRTr+o8wYJAbQ+UQj+3axtnk8yrl/WHVvH2eCEOnTT/xJMGqII0Tph65G JhBFeU9z9dvvnQgomAJKi7q2VJrxoCRr/w3TnNaumVt9OFErWC9ARa7NgivcPIzWES4R N7x4IUtnICnvm9uwbXhq09a/bB4MMlPc1ENVgIkh11Pc1QqfCBCYXiobZNC5MzuYuJxg QZ/w== X-Gm-Message-State: AOJu0YwNcc3Nv6CSCRtwx3kMJf2UxWwSfn8KXVaOZW1PX8PpMMvQ4n9Z snTkCm0d/RzP3mpYHGMVUoxXhFWNO9WqP8zpiyCn6QoCmGEzDGpcHZENNx0Cs6Bg05aauyOLFNo 68KdEmm5KExdysSzOzuoNDAYWTvC2nsph4g== X-Gm-Gg: ASbGncvZEmfZnSwk8eXap2MMq5x1bffbxjb1XTwvlYXD1Kz74Njm3+D86YzpQ/um1YR GC6Ce+7LWUiGLVJvyzoRDPkwmwCd4o4hKoZN3WtXwHzzSu4N9k8yRjw3xzE0l7T+uilLfun73hS lxhujCAM0jDkCQeADkSB+mJkjN+axfhSETc3EZbUiQBMKczJ/4nPGI567h8pl7OKkDKL09kqgsN wkIP3M= X-Google-Smtp-Source: AGHT+IFb3HUdlNYogrY3BzUVrqHki5OaZxFGo5JIyCF3bpZxp8HzXflD/lfjAy4qVLgpgDvy6E4MzV9TwsyvTXf7xnY= X-Received: by 2002:a05:690c:4d06:b0:71a:251e:36ee with SMTP id 00721157ae682-71b7f0b03e4mr95933967b3.39.1754266120812; Sun, 03 Aug 2025 17:08:40 -0700 (PDT) MIME-Version: 1.0 References: <20250803233127.4888-1-jiashengjiangcool@gmail.com> In-Reply-To: <20250803233127.4888-1-jiashengjiangcool@gmail.com> Date: Mon, 4 Aug 2025 01:08:31 +0100 X-Gm-Features: Ac12FXzk8mJdEBL9qfO817pEg1qQeGjQz6UNUnW7moiqrvD7LuUJzSgRLrvxdFA Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kieran Kunhya via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Kieran Kunhya , Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 4 Aug 2025, 00:31 Jiasheng Jiang, wrote: > Add av_free() to free s.temp_dwt_buffer and s.temp_idwt_buffer at the end > of the function to avoid memory leak. > > Fixes: 5d48e4eafa ("Merge commit > 'a6a750c7ef240b72ce01e9653343a0ddf247d196'") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/tests/snowenc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tests/snowenc.c b/libavcodec/tests/snowenc.c > index eb4e64f377..311374e5d4 100644 > --- a/libavcodec/tests/snowenc.c > +++ b/libavcodec/tests/snowenc.c > @@ -45,7 +45,8 @@ int main(void){ > > if (!s.temp_dwt_buffer || !s.temp_idwt_buffer) { > fprintf(stderr, "Failed to allocate memory\n"); > - return 1; > + ret = 1; > + goto end; > } > > av_lfg_init(&prng, 1); > @@ -145,5 +146,9 @@ int main(void){ > } > > } > + > +end: > + av_free(s.temp_dwt_buffer); > + av_free(s.temp_idwt_buffer); > return ret; > } > -- > 2.25.1 > Is this AI written? Kieran > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".