From: Kieran Kunhya via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Kieran Kunhya <kieran618@googlemail.com>, Jiasheng Jiang <jiashengjiangcool@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak Date: Mon, 4 Aug 2025 01:08:31 +0100 Message-ID: <CABGuwEmgw83kD2oWE5gewT6=_2GUVbGkj=Ld2DQaCxyL9st4hw@mail.gmail.com> (raw) In-Reply-To: <20250803233127.4888-1-jiashengjiangcool@gmail.com> On Mon, 4 Aug 2025, 00:31 Jiasheng Jiang, <jiashengjiangcool@gmail.com> wrote: > Add av_free() to free s.temp_dwt_buffer and s.temp_idwt_buffer at the end > of the function to avoid memory leak. > > Fixes: 5d48e4eafa ("Merge commit > 'a6a750c7ef240b72ce01e9653343a0ddf247d196'") > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com> > --- > libavcodec/tests/snowenc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tests/snowenc.c b/libavcodec/tests/snowenc.c > index eb4e64f377..311374e5d4 100644 > --- a/libavcodec/tests/snowenc.c > +++ b/libavcodec/tests/snowenc.c > @@ -45,7 +45,8 @@ int main(void){ > > if (!s.temp_dwt_buffer || !s.temp_idwt_buffer) { > fprintf(stderr, "Failed to allocate memory\n"); > - return 1; > + ret = 1; > + goto end; > } > > av_lfg_init(&prng, 1); > @@ -145,5 +146,9 @@ int main(void){ > } > > } > + > +end: > + av_free(s.temp_dwt_buffer); > + av_free(s.temp_idwt_buffer); > return ret; > } > -- > 2.25.1 > Is this AI written? Kieran > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-08-04 0:08 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-08-03 23:31 Jiasheng Jiang 2025-08-04 0:08 ` Kieran Kunhya via ffmpeg-devel [this message] [not found] ` <ACA0005D-801C-4B43-8524-B680A994DBC9@hxcore.ol> 2025-08-04 0:18 ` Kieran Kunhya via ffmpeg-devel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABGuwEmgw83kD2oWE5gewT6=_2GUVbGkj=Ld2DQaCxyL9st4hw@mail.gmail.com' \ --to=ffmpeg-devel@ffmpeg.org \ --cc=jiashengjiangcool@gmail.com \ --cc=kieran618@googlemail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git