From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E36414C07F for ; Sun, 7 Dec 2025 23:53:52 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'3v9RJIZAXKZgy/j6ACoXbmak8KKKKiOwn83HlW/zbZA=', expected b'97zDVseWHC5Wql8w0APv/UrQHLOakEDOPr25kkEOIKc=')) header.d=googlemail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1765151621; h=mime-version : references : in-reply-to : date : message-id : to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=GKd3rYmTfXr1sK6WO23ns982DveXRtOgLlgY+ru2o9Q=; b=tMAlwOJSB6GaVWqINnzvg3Y6952crdrMCbLS9pT5cX/jZaULe8OmpECnNxJ2GQHmdlg4A 8Xat15joa4S5GdN7ol0a76vWDnYDXaq6zSYNhvR4Dz2xLRwct82GXHc6XYQUwGQ4qP2OXox XG+Qgv06ewY0UdTLk5hsftfUCbqhopTUp/Mruibush4bE1J5dJ1E3viDPlaMu4Mj+8gTRLT QpxQBnFd6sjnxtlgfNRM5R3S4sDb2nUO+rH2GyFoMUm+rfKpGS44Vwh5i1xtO1Ub9ZanlZ9 nxy8O33if+ej4MWMFiasUkn/SuIrMkD2XWEHsmOotjglwf1OiRW3F50m4Tew== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 55943690627; Mon, 8 Dec 2025 01:53:41 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1765151606; b=qIQFqagGHEqIaipHl2Pl4/WJ2Xb1WXjrEmos4jLBuM+HOdkks93iY9mbVl9XeJcWt5EAF xhZ9nMPkJ/cmM2O4uhOZwtyke60re4TZ38VC0rViiNnYv3JeHjjyFfW1ZVnEGrqjhYEAr31 wqN/14fl6G7d3CeXwb0hsFtrwkhNZlz5Lpduu7GcTbgh/6wJ2Dj73WRFDYih+3C9ckxxmZp vljwZC4diCVBzIB4ACmeWbII6BIE/4B5p+erZIYbVIaZTXkjByoHS1ypXJQA7hA/HmGP5j3 5t0r/Pbh6EGKRL276RH8YJuHWzvTV0OVl3PRkgbYaBxz10g3bUwk3ekXYJyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1765151606; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=3v9RJIZAXKZgy/j6ACoXbmak8KKKKiOwn83HlW/zbZA=; b=OeTz3JpIjZ/RGKFRk46+nB3yTI78UwicxJIEZW+fPyUPlztGzj77CRVHmMJ7iV1T9kark J4DCIvioodlfaiHdMo4yn4/LAmqddUl8auxLoXgIGcbzuZxI5ssTrSioaYMldqkKPAHSy8H LXGKlVeXB94WJXiqUr5C/vuowvPgTwX5HCK150ctOgSeu5k2znq2FIRUCx+GgR2cpra/BD0 ypuFYyUZG21WTLrvl+tCc7zs9XwMRJUtBVyU8UG90kJYZuaLxbg6Z2372p8/hV1tDe7x4TD cHOuN0Ja5tZAjG8HK0KazS9WJt9zH5xgPTu0MQugczM+B43xbiK5NxLs0LMw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=googlemail.com; arc=none; dmarc=pass header.from=googlemail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=googlemail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=googlemail.com policy.dmarc=quarantine Received: from mail-yx1-f41.google.com (mail-yx1-f41.google.com [74.125.224.41]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 845CB6905BE for ; Mon, 8 Dec 2025 01:53:13 +0200 (EET) Received: by mail-yx1-f41.google.com with SMTP id 956f58d0204a3-63f97c4eccaso3439583d50.2 for ; Sun, 07 Dec 2025 15:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1765151591; x=1765756391; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=97zDVseWHC5Wql8w0APv/UrQHLOakEDOPr25kkEOIKc=; b=e/8K9wgTAz713l+US0vArhYc4+Was/X1HWecWBB/WgfzM4kAqzDTSweb/vi7USo4t+ Cgtv1XxhBfFeRs/P5S4iDWxjARcl381FA5lkf5UMwKOpl7zHfKZ0xp/UL3WujBmSQyJN WcXtumun51cLy+jEeGPzcHyRo1r3jb8oX2dI+ftTMDxTTTFg3Pxw0az6gMED+6KflUST 8kQKyifHw4iI0cAnnYuaiENb/4TPgUqGMrwxpO59YzFvHfh1XmtFowrezI4XfOG0zoLU 14SOhnz+QtLNBOCm+8y7T41VwYOdCo/D3dAnS1Gi5fV3+0j5A0LOU43VT86L2S/IyIPO f0cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765151591; x=1765756391; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=97zDVseWHC5Wql8w0APv/UrQHLOakEDOPr25kkEOIKc=; b=n4ZqX7V8pJGZTozUtgXiEKhwuGUkc1ujtWZZgDdYjoAaaqHakCpnCYU5JZYRpLVqDw gtBJQ3vn+MZEqDWoQodwNxHTlVbg+Oqr2mPwhMHL//nS1//6rSOqOvm/+xAf+Ky8jWF7 2SgncGDQoXJag8TDek/dfm8QkpErb+tufB5Up0eZR/rAaVcGFr74Px0dQJl6Qs56w5Gl vAtWRyaIcBHGeITKTuwP8Ehx5OVY/BHdtBoTPiIJE2nlhkbu1e0IpQndi2TxI7h7XQyf TsnMj8CUqV1C0pRgWrCtItuJlDX+dFmKjG3v6/y5sxXia7R/CVBTbA3ZjyqB/BZldd6S r+UQ== X-Gm-Message-State: AOJu0YzfGBP0FIOKb1sed+Ahm2uAwSnuQqSI8BJLQCfzay5LBEU+bJxf T6tUpgNFMtf8Z75LbedfZ7Dy+zUCFrROIQMrnDsA92/dvq4CRNb02Fcl4aNQlpmwqosgH6l6771 KFc8OlfB3y7BuFDJpI9turJohv8hnOanb2C0Q X-Gm-Gg: ASbGncuA4pEhBKCeKRsDHw6plAhZXvLLI8fsjROiUq0dVfjP+fiH83omUfuWTf0y1xe WbGuCzj3ChGUM/x1+IDbI89wCIAJmsshU/jnyWpnpeK2C4UuJh3cKGcLhbuxm9uyIjbnwkVbibW j/mnHv8VBB/dZi3VMm3usCdyKONicptF5VjFEdHDJ6CT8ia+LSWumyT03qTkIM3+ZZRpST3tguw paI7rGB4ZLfDVxBp9OoxVWRCmnzABswLOwwcIT8uLPSpqsfV6kM3rJ38ZgNByXGX/iNju01zS7x MYuy5Y9oylCuI3mG0P7GmLR0 X-Google-Smtp-Source: AGHT+IGYdeFRWfm5QFyGdFEBQ4pAAGJahGZ4KOvK1HSFPewoRMObdYmi9HLQ0lCkp7HFgp62EyJ5jhAP1LpEZqlLiQg= X-Received: by 2002:a05:690e:1408:b0:641:f5bc:698b with SMTP id 956f58d0204a3-6444e7d743emr5168224d50.71.1765151591154; Sun, 07 Dec 2025 15:53:11 -0800 (PST) MIME-Version: 1.0 References: <176473190828.39.10800347272176878664@2cb04c0e5124> In-Reply-To: <176473190828.39.10800347272176878664@2cb04c0e5124> Date: Sun, 7 Dec 2025 23:53:02 +0000 X-Gm-Features: AQt7F2oWGzzTc0NUbEgTDHcveXY5wT2k096en-GsS893GrjVsLUC9w3SOlIOXXI Message-ID: To: FFmpeg development discussions and patches Message-ID-Hash: 6CS4MIDBR2AHFAUVSIL44YMTTVBMNQMI X-Message-ID-Hash: 6CS4MIDBR2AHFAUVSIL44YMTTVBMNQMI X-MailFrom: SRS0=wjrs=6N=googlemail.com=kieran618@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] libavcodec/prores_raw: Fix heap-buffer-overflow in decode_frame (PR #21085) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Kieran Kunhya via ffmpeg-devel Cc: oliverchang , Kieran Kunhya Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: On Wed, 3 Dec 2025, 04:18 oliverchang via ffmpeg-devel, < ffmpeg-devel@ffmpeg.org> wrote: > PR #21085 opened by oliverchang > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21085 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21085.patch > > Fixes a heap-buffer-overflow in `decode_frame` where `header_len` read > from the bitstream was not validated against the remaining bytes in the > input buffer (`gb`). This allowed `gb_hdr` to be initialized with a size > exceeding the actual packet data, leading to an out-of-bounds read. > > The fix adds a check to ensure `bytestream2_get_bytes_left(&gb)` is > greater than or equal to `header_len - 2` before initializing `gb_hdr`. > > Fixes: https://issues.oss-fuzz.com/issues/439711053 > > > >From ac7bdf8326e0747758ef1ceb03f4ff8abf225283 Mon Sep 17 00:00:00 2001 > From: Oliver Chang > Date: Wed, 3 Dec 2025 02:57:43 +0000 > Subject: [PATCH] libavcodec/prores_raw: Fix heap-buffer-overflow in > decode_frame > > Fixes a heap-buffer-overflow in `decode_frame` where `header_len` read > from the bitstream was not validated against the remaining bytes in the > input buffer (`gb`). This allowed `gb_hdr` to be initialized with a size > exceeding the actual packet data, leading to an out-of-bounds read. > > The fix adds a check to ensure `bytestream2_get_bytes_left(&gb)` is > greater than or equal to `header_len - 2` before initializing `gb_hdr`. > > Fixes: https://issues.oss-fuzz.com/issues/439711053 > --- > libavcodec/prores_raw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/prores_raw.c b/libavcodec/prores_raw.c > index 01f1bbd2fb..8be566ed36 100644 > --- a/libavcodec/prores_raw.c > +++ b/libavcodec/prores_raw.c > @@ -360,7 +360,7 @@ static int decode_frame(AVCodecContext *avctx, > return AVERROR_INVALIDDATA; > > int header_len = bytestream2_get_be16(&gb); > - if (header_len < 62) > + if (header_len < 62 || bytestream2_get_bytes_left(&gb) < header_len - > 2) > return AVERROR_INVALIDDATA; > > GetByteContext gb_hdr; > -- > 2.49.1 > Seems fine > _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org