Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Kieran Kunhya via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Kieran Kunhya <kieran618@googlemail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version
Date: Fri, 18 Jul 2025 13:46:05 +0100
Message-ID: <CABGuwEkqASv75hEoQ=4ajEEqTYWt=nC8qypkD0HZk75MbYXA_w@mail.gmail.com> (raw)
In-Reply-To: <CABPLAST3K2DTL9JY4eQVhxmXh1ukZgx6qNfw9GoLTQPePR+q1g@mail.gmail.com>

On Fri, Jul 18, 2025 at 1:41 PM Kacper Michajlow <kasper93@gmail.com> wrote:
>
> On Fri, 18 Jul 2025 at 14:14, Kieran Kunhya via ffmpeg-devel
> <ffmpeg-devel@ffmpeg.org> wrote:
> >
> > > blackdetect8_c:                                        820.8 ( 1.00x)
> > > blackdetect8_avx2:                                     219.2 ( 3.74x)
> > > blackdetect16_c:                                       372.8 ( 1.00x)
> > > blackdetect16_avx2:                                    201.4 ( 1.85x)
> > >
> > > Again, sorry for being pedantic here, but it gives the wrong
> > > impression especially if you look at this from outside.
> >
> > Also misleading as far as I understand because GCC doesn't have
> > runtime detection like FFmpeg.
>
> Speak of... actually GCC does have runtime detection. All you have to
> do is mark the function with `target_clones` with requested
> architectures and it will dispatch automatically during runtime the
> best function to use.
>
> See for more information:
> https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-target_005fclones-function-attribute

It's not as sophisticated as our runtime detection (e.g avx512 vs
avx512icl which we support).
Comparing C vs autovectorised code that works only on some platforms
with forced compilation settings is also unfair.

Kieran
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-07-18 12:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 10:45 Niklas Haas
2025-07-17 10:45 ` [FFmpeg-devel] [PATCH v2 2/2] tests/checkasm: add test for vf_blackdetect Niklas Haas
2025-07-18 11:35 ` [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version Zhao Zhili
2025-07-18 11:36 ` Kacper Michajlow
2025-07-18 12:14   ` Kieran Kunhya via ffmpeg-devel
2025-07-18 12:28     ` Kacper Michajlow
2025-07-18 12:41     ` Kacper Michajlow
2025-07-18 12:46       ` Kieran Kunhya via ffmpeg-devel [this message]
2025-07-18 13:21         ` Kacper Michajlow
2025-07-18 13:33           ` Kieran Kunhya via ffmpeg-devel
2025-07-18 14:16             ` Kacper Michajlow
2025-07-18 14:36               ` Kieran Kunhya via ffmpeg-devel
2025-07-18 12:26   ` Zhao Zhili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABGuwEkqASv75hEoQ=4ajEEqTYWt=nC8qypkD0HZk75MbYXA_w@mail.gmail.com' \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=kieran618@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git