From: Kieran Kunhya via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Kieran Kunhya <kieran618@googlemail.com> Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/h264chroma_template: Replace variable by constant in chroma mc Date: Mon, 14 Jul 2025 17:49:19 +0100 Message-ID: <CABGuwEkO+hOOGjvzK=iEYKMEZQoymHG428FOu9KavGf_hUJbKQ@mail.gmail.com> (raw) In-Reply-To: <20250713011030.1156550-3-michael@niedermayer.cc> On Sun, 13 Jul 2025, 02:11 Michael Niedermayer, <michael@niedermayer.cc> wrote: > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavcodec/h264chroma_template.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/libavcodec/h264chroma_template.c > b/libavcodec/h264chroma_template.c > index b9d24f5a0cd..b20811a71ae 100644 > --- a/libavcodec/h264chroma_template.c > +++ b/libavcodec/h264chroma_template.c > @@ -54,7 +54,7 @@ static void FUNCC(OPNAME ## h264_chroma_mc1)(uint8_t > *_dst /*align 8*/, const ui > }\ > } else {\ > for(i=0; i<h; i++){\ > - OP(dst[0], (A*src[0]));\ > + OP(dst[0], (64*src[0]));\ > dst+= stride;\ > src+= stride;\ > }\ > @@ -91,8 +91,8 @@ static void FUNCC(OPNAME ## h264_chroma_mc2)(uint8_t > *_dst /*align 8*/, const ui > }\ > } else {\ > for ( i = 0; i < h; i++){\ > - OP(dst[0], A * src[0]);\ > - OP(dst[1], A * src[1]);\ > + OP(dst[0], 64 * src[0]);\ > + OP(dst[1], 64 * src[1]);\ > dst += stride;\ > src += stride;\ > }\ > @@ -134,10 +134,10 @@ static void FUNCC(OPNAME ## h264_chroma_mc4)(uint8_t > *_dst /*align 8*/, const ui > }\ > } else {\ > for ( i = 0; i < h; i++){\ > - OP(dst[0], A * src[0]);\ > - OP(dst[1], A * src[1]);\ > - OP(dst[2], A * src[2]);\ > - OP(dst[3], A * src[3]);\ > + OP(dst[0], 64 * src[0]);\ > + OP(dst[1], 64 * src[1]);\ > + OP(dst[2], 64 * src[2]);\ > + OP(dst[3], 64 * src[3]);\ > dst += stride;\ > src += stride;\ > }\ > @@ -187,14 +187,14 @@ static void FUNCC(OPNAME ## h264_chroma_mc8)(uint8_t > *_dst /*align 8*/, const ui > }\ > } else {\ > for ( i = 0; i < h; i++){\ > - OP(dst[0], A * src[0]);\ > - OP(dst[1], A * src[1]);\ > - OP(dst[2], A * src[2]);\ > - OP(dst[3], A * src[3]);\ > - OP(dst[4], A * src[4]);\ > - OP(dst[5], A * src[5]);\ > - OP(dst[6], A * src[6]);\ > - OP(dst[7], A * src[7]);\ > + OP(dst[0], 64 * src[0]);\ > + OP(dst[1], 64 * src[1]);\ > + OP(dst[2], 64 * src[2]);\ > + OP(dst[3], 64 * src[3]);\ > + OP(dst[4], 64 * src[4]);\ > + OP(dst[5], 64 * src[5]);\ > + OP(dst[6], 64 * src[6]);\ > + OP(dst[7], 64 * src[7]);\ > dst += stride;\ > src += stride;\ > }\ > -- > 2.49.0 > Some explanation of what this is for would help. Kieran > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-14 16:52 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-07-13 1:10 [FFmpeg-devel] [PATCH 1/5] avformat/flvdec: Check for EOF in AudioPacketTypeMultichannelConfig Michael Niedermayer 2025-07-13 1:10 ` [FFmpeg-devel] [PATCH 2/5] avformat/concatdec: Clip duration in one more case in get_best_effort_duration() Michael Niedermayer 2025-07-13 1:10 ` [FFmpeg-devel] [PATCH 3/5] avcodec/h264chroma_template: Replace variable by constant in chroma mc Michael Niedermayer 2025-07-14 16:49 ` Kieran Kunhya via ffmpeg-devel [this message] 2025-07-13 1:10 ` [FFmpeg-devel] [PATCH 4/5] avcodec/mpegvideo_dec: Fix lowres=3 field select interlaced mpeg4 frame Michael Niedermayer 2025-07-13 17:34 ` Andreas Rheinhardt 2025-07-14 18:52 ` Michael Niedermayer 2025-07-13 1:10 ` [FFmpeg-devel] [PATCH 5/5] avcodec/osq: Fix 32bit sample overflow Michael Niedermayer 2025-07-13 17:37 ` Andreas Rheinhardt 2025-07-14 18:58 ` Michael Niedermayer 2025-07-13 11:42 ` [FFmpeg-devel] [PATCH 1/5] avformat/flvdec: Check for EOF in AudioPacketTypeMultichannelConfig Timo Rothenpieler 2025-07-14 19:21 ` Michael Niedermayer 2025-07-14 19:25 ` Timo Rothenpieler 2025-07-14 20:00 ` Timo Rothenpieler 2025-07-14 22:01 ` Michael Niedermayer 2025-07-14 22:28 ` Timo Rothenpieler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABGuwEkO+hOOGjvzK=iEYKMEZQoymHG428FOu9KavGf_hUJbKQ@mail.gmail.com' \ --to=ffmpeg-devel@ffmpeg.org \ --cc=kieran618@googlemail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git