* [FFmpeg-devel] [PATCH] libavformat/mpegts: fix network pid is 0 in pat_cb
@ 2025-11-27 10:52 ganqiuye via ffmpeg-devel
2025-11-27 13:16 ` [FFmpeg-devel] " Kieran Kunhya via ffmpeg-devel
2025-11-28 5:21 ` [FFmpeg-devel] [PATCH v2] avformat/mpegts: fix the issue where the PMT table can't be retrieved ganqiuye via ffmpeg-devel
0 siblings, 2 replies; 3+ messages in thread
From: ganqiuye via ffmpeg-devel @ 2025-11-27 10:52 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: ganqiuye
When analysing PAT, if network PID is 0, it won't get the PMT PID.
Signed-off-by: ganqiuye <ganqiuye@gmail.com>
---
libavformat/mpegts.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 33f2914104..f6d860007f 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -2590,14 +2590,13 @@ static void pat_cb(MpegTSFilter *filter, const uint8_t *section, int section_len
break;
pmt_pid &= 0x1fff;
- if (pmt_pid == ts->current_pid)
- break;
-
av_log(ts->stream, AV_LOG_TRACE, "sid=0x%x pid=0x%x\n", sid, pmt_pid);
if (sid == 0x0000) {
/* NIT info */
} else {
+ if (pmt_pid == ts->current_pid)
+ break;
MpegTSFilter *fil = ts->pids[pmt_pid];
struct Program *prg;
program = av_new_program(ts->stream, sid);
--
2.45.1.windows.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [FFmpeg-devel] Re: [PATCH] libavformat/mpegts: fix network pid is 0 in pat_cb
2025-11-27 10:52 [FFmpeg-devel] [PATCH] libavformat/mpegts: fix network pid is 0 in pat_cb ganqiuye via ffmpeg-devel
@ 2025-11-27 13:16 ` Kieran Kunhya via ffmpeg-devel
2025-11-28 5:21 ` [FFmpeg-devel] [PATCH v2] avformat/mpegts: fix the issue where the PMT table can't be retrieved ganqiuye via ffmpeg-devel
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Kunhya via ffmpeg-devel @ 2025-11-27 13:16 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Kieran Kunhya
On Thu, 27 Nov 2025, 10:53 ganqiuye via ffmpeg-devel, <
ffmpeg-devel@ffmpeg.org> wrote:
> When analysing PAT, if network PID is 0, it won't get the PMT PID.
>
> Signed-off-by: ganqiuye <ganqiuye@gmail.com>
> ---
> libavformat/mpegts.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
> index 33f2914104..f6d860007f 100644
> --- a/libavformat/mpegts.c
> +++ b/libavformat/mpegts.c
> @@ -2590,14 +2590,13 @@ static void pat_cb(MpegTSFilter *filter, const
> uint8_t *section, int section_len
> break;
> pmt_pid &= 0x1fff;
>
> - if (pmt_pid == ts->current_pid)
> - break;
> -
> av_log(ts->stream, AV_LOG_TRACE, "sid=0x%x pid=0x%x\n", sid,
> pmt_pid);
>
> if (sid == 0x0000) {
> /* NIT info */
> } else {
> + if (pmt_pid == ts->current_pid)
> + break;
> MpegTSFilter *fil = ts->pids[pmt_pid];
> struct Program *prg;
> program = av_new_program(ts->stream, sid);
> --
> 2.45.1.windows.1
>
Needs some comment to explain why as PID 0 is for PAT.
Kieran
>
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [FFmpeg-devel] [PATCH v2] avformat/mpegts: fix the issue where the PMT table can't be retrieved.
2025-11-27 10:52 [FFmpeg-devel] [PATCH] libavformat/mpegts: fix network pid is 0 in pat_cb ganqiuye via ffmpeg-devel
2025-11-27 13:16 ` [FFmpeg-devel] " Kieran Kunhya via ffmpeg-devel
@ 2025-11-28 5:21 ` ganqiuye via ffmpeg-devel
1 sibling, 0 replies; 3+ messages in thread
From: ganqiuye via ffmpeg-devel @ 2025-11-28 5:21 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: ganqiuye
When analysing PAT, if sid 0 and pmt_pid 0 (current_pid 0 as pat_pid),
it will break out of the loop, so it can't retrieve the next pmt_pid.
Signed-off-by: ganqiuye <ganqiuye@gmail.com>
---
libavformat/mpegts.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 33f2914104..f6d860007f 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -2590,14 +2590,13 @@ static void pat_cb(MpegTSFilter *filter, const uint8_t *section, int section_len
break;
pmt_pid &= 0x1fff;
- if (pmt_pid == ts->current_pid)
- break;
-
av_log(ts->stream, AV_LOG_TRACE, "sid=0x%x pid=0x%x\n", sid, pmt_pid);
if (sid == 0x0000) {
/* NIT info */
} else {
+ if (pmt_pid == ts->current_pid)
+ break;
MpegTSFilter *fil = ts->pids[pmt_pid];
struct Program *prg;
program = av_new_program(ts->stream, sid);
--
2.45.1.windows.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-28 5:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-27 10:52 [FFmpeg-devel] [PATCH] libavformat/mpegts: fix network pid is 0 in pat_cb ganqiuye via ffmpeg-devel
2025-11-27 13:16 ` [FFmpeg-devel] " Kieran Kunhya via ffmpeg-devel
2025-11-28 5:21 ` [FFmpeg-devel] [PATCH v2] avformat/mpegts: fix the issue where the PMT table can't be retrieved ganqiuye via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git