[FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak

[FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak

[Jiasheng Jiang]

Add av_free() to free s.temp_dwt_buffer and s.temp_idwt_buffer at the end of the function to avoid memory leak.

Fixes: 5d48e4eafa ("Merge commit 'a6a750c7ef240b72ce01e9653343a0ddf247d196'")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libavcodec/tests/snowenc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/libavcodec/tests/snowenc.c b/libavcodec/tests/snowenc.c
index eb4e64f377..311374e5d4 100644
--- a/libavcodec/tests/snowenc.c
+++ b/libavcodec/tests/snowenc.c
@@ -45,7 +45,8 @@ int main(void){
 
     if (!s.temp_dwt_buffer || !s.temp_idwt_buffer) {
         fprintf(stderr, "Failed to allocate memory\n");
-        return 1;
+        ret = 1;
+        goto end;
     }
 
     av_lfg_init(&prng, 1);
@@ -145,5 +146,9 @@ int main(void){
         }
 
     }
+
+end:
+    av_free(s.temp_dwt_buffer);
+    av_free(s.temp_idwt_buffer);
     return ret;
 }
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak

[Kieran Kunhya via ffmpeg-devel]

On Mon, 4 Aug 2025, 00:31 Jiasheng Jiang, <jiashengjiangcool@gmail.com>
wrote:

> Add av_free() to free s.temp_dwt_buffer and s.temp_idwt_buffer at the end
> of the function to avoid memory leak.
>
> Fixes: 5d48e4eafa ("Merge commit
> 'a6a750c7ef240b72ce01e9653343a0ddf247d196'")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
>  libavcodec/tests/snowenc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/tests/snowenc.c b/libavcodec/tests/snowenc.c
> index eb4e64f377..311374e5d4 100644
> --- a/libavcodec/tests/snowenc.c
> +++ b/libavcodec/tests/snowenc.c
> @@ -45,7 +45,8 @@ int main(void){
>
>      if (!s.temp_dwt_buffer || !s.temp_idwt_buffer) {
>          fprintf(stderr, "Failed to allocate memory\n");
> -        return 1;
> +        ret = 1;
> +        goto end;
>      }
>
>      av_lfg_init(&prng, 1);
> @@ -145,5 +146,9 @@ int main(void){
>          }
>
>      }
> +
> +end:
> +    av_free(s.temp_dwt_buffer);
> +    av_free(s.temp_idwt_buffer);
>      return ret;
>  }
> --
> 2.25.1
>

Is this AI written?

Kieran

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak

[Kieran Kunhya via ffmpeg-devel]

On Mon, 4 Aug 2025, 01:14 jiashengjiangcool@gmail.com, <
jiashengjiangcool@gmail.com> wrote:

> This patch was not written by AI. I used a static analysis tool to detect
> several similar issues, which led to a number of similar-looking
> submissions.
>
> -Jiasheng
>

Sorry about that, thank you for the contribution!

Kieran




> *From: *Kieran Kunhya <kieran618@googlemail.com>
> *Date: *Sunday, August 3, 2025 at 20:08
> *To: *FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> *Cc: *Jiasheng Jiang <jiashengjiangcool@gmail.com>
> *Subject: *Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add
> av_free() to avoid memory leak
>
>
>
> On Mon, 4 Aug 2025, 00:31 Jiasheng Jiang, <jiashengjiangcool@gmail.com>
> wrote:
>
> Add av_free() to free s.temp_dwt_buffer and s.temp_idwt_buffer at the end
> of the function to avoid memory leak.
>
> Fixes: 5d48e4eafa ("Merge commit
> 'a6a750c7ef240b72ce01e9653343a0ddf247d196'")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
>  libavcodec/tests/snowenc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/tests/snowenc.c b/libavcodec/tests/snowenc.c
> index eb4e64f377..311374e5d4 100644
> --- a/libavcodec/tests/snowenc.c
> +++ b/libavcodec/tests/snowenc.c
> @@ -45,7 +45,8 @@ int main(void){
>
>      if (!s.temp_dwt_buffer || !s.temp_idwt_buffer) {
>          fprintf(stderr, "Failed to allocate memory\n");
> -        return 1;
> +        ret = 1;
> +        goto end;
>      }
>
>      av_lfg_init(&prng, 1);
> @@ -145,5 +146,9 @@ int main(void){
>          }
>
>      }
> +
> +end:
> +    av_free(s.temp_dwt_buffer);
> +    av_free(s.temp_idwt_buffer);
>      return ret;
>  }
> --
> 2.25.1
>
>
> Is this AI written?
>
> Kieran
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".