From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6ED104C5B9 for ; Mon, 4 Aug 2025 00:18:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 96E6F68C30D; Mon, 4 Aug 2025 03:18:25 +0300 (EEST) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8DB0F687D64 for ; Mon, 4 Aug 2025 03:18:18 +0300 (EEST) Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-e8e014c1d19so2098176276.3 for ; Sun, 03 Aug 2025 17:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754266697; x=1754871497; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uBzuUvCb3QCPdQ2dcMwl64nOUeVdov73P1BM3KoKn2Y=; b=n09LshD2w7SYPWiC0PFGA+Yvc065dEHxl2abmzx2sqxekk/uQ1NlLcwv1X/CsmuSwu 0Eq00AAKvx3b4WRj16NlGpUqM58CAThv5/LSTCZvtj9++ZrTH1Ghf1SnieQae2sTNEwO W28hYSsnPFRb9R8G9UWbXRok2TmI2OcuK+Vu2MNTnIhRgj19+zRTjKqx8L7Jw9qk9DPb WoAuTJflZdzOZpixDWZKFycHwAZm4DcqVbYEipBzuWn5pr/sHbOku+Sq5MJk1fl7xxoV b6zOUudEBuHFIKnBzVA7Htk46DDXnHVcRCC7Nqm8QcIFrFQmYKhwvZ2SKICaPmn19Zu0 ttPA== X-Gm-Message-State: AOJu0YwQktK5LiXY+0EpHyuNvvHc6Cu6Tnl3SzfNBX9zDMf5xPEfCpAU 9E0nbd4IiqzS6+6ljVgVx75K5y+2JYSWqWEO4DiSoC6iavsdE8l2fZCcp+xxbus8UKsZaZacEFo NxOUc8rRmC+O+2yw979R+3JKQ9P0es3o= X-Gm-Gg: ASbGncuTuoGv95m+ns8421yQYPw8YkbwqeDggu6dNiE+6ZkvgqTDybIT+QGrK+gCxMY YRgn0fR0lwLeL14I5Fjokd0IrsBj42EBHVqbemhSN7t26SZmpO+Sslg3mkBoXaijYoZgZgHSZ73 Fr1bqM8s0rZJdoQkeeha0vios0u9AnZfaLniTKztVpeo4ec89j6UTt9AEiLvdzlNtjcsShn/np1 YotE3A= X-Google-Smtp-Source: AGHT+IElXN6xTx/NeJodrMO28JlHJk6TrIvJzk294zXVTCD6h/GWUoUiiAsLhXnU6FsZng6mGq5yomTUH7re5kQSxXo= X-Received: by 2002:a05:690c:f87:b0:719:ff33:9265 with SMTP id 00721157ae682-71b7ef65546mr94222667b3.19.1754266697105; Sun, 03 Aug 2025 17:18:17 -0700 (PDT) MIME-Version: 1.0 References: <20250803233127.4888-1-jiashengjiangcool@gmail.com> In-Reply-To: Date: Mon, 4 Aug 2025 01:18:08 +0100 X-Gm-Features: Ac12FXxBFJj9Prbe1GSJKCfOZckSreX9roBSF6rzOOO1KYBOJfC1FIr1yykmLMg Message-ID: To: jiashengjiangcool@gmail.com X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add av_free() to avoid memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kieran Kunhya via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Kieran Kunhya , FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 4 Aug 2025, 01:14 jiashengjiangcool@gmail.com, < jiashengjiangcool@gmail.com> wrote: > This patch was not written by AI. I used a static analysis tool to detect > several similar issues, which led to a number of similar-looking > submissions. > > -Jiasheng > Sorry about that, thank you for the contribution! Kieran > *From: *Kieran Kunhya > *Date: *Sunday, August 3, 2025 at 20:08 > *To: *FFmpeg development discussions and patches > *Cc: *Jiasheng Jiang > *Subject: *Re: [FFmpeg-devel] [PATCH] libavcodec/tests/snowenc: Add > av_free() to avoid memory leak > > > > On Mon, 4 Aug 2025, 00:31 Jiasheng Jiang, > wrote: > > Add av_free() to free s.temp_dwt_buffer and s.temp_idwt_buffer at the end > of the function to avoid memory leak. > > Fixes: 5d48e4eafa ("Merge commit > 'a6a750c7ef240b72ce01e9653343a0ddf247d196'") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/tests/snowenc.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/tests/snowenc.c b/libavcodec/tests/snowenc.c > index eb4e64f377..311374e5d4 100644 > --- a/libavcodec/tests/snowenc.c > +++ b/libavcodec/tests/snowenc.c > @@ -45,7 +45,8 @@ int main(void){ > > if (!s.temp_dwt_buffer || !s.temp_idwt_buffer) { > fprintf(stderr, "Failed to allocate memory\n"); > - return 1; > + ret = 1; > + goto end; > } > > av_lfg_init(&prng, 1); > @@ -145,5 +146,9 @@ int main(void){ > } > > } > + > +end: > + av_free(s.temp_dwt_buffer); > + av_free(s.temp_idwt_buffer); > return ret; > } > -- > 2.25.1 > > > Is this AI written? > > Kieran > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".