[FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello,

The following 2 commits break the build with a deployment target of 10.9 on
macOS.

I agree that 10.9 is quite old, but the rest of the code worked perfectly
fine, so were those 2 commits really necessary?

* 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
vf_yadif_videotoolbox (Aman Karmani)
* ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
(Aman Karmani)

Can you make that code conditional?


The error messages I get during the compile run are:

In file included from libavfilter/metal/utils.m:20:
./libavfilter/metal/utils.h:25:43: error: 'MTLDevice' is only available on
macOS 10.11 or newer [-Werror,-Wunguarded-availability]
void ff_metal_compute_encoder_dispatch(id<MTLDevice> device,
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/
Metal.framework/Headers/MTLCaptureScope.h:14:11:
note: 'MTLDevice' has been marked as being introduced in macOS
      10.11 here, but the deployment target is macOS 10.9.0
@protocol MTLDevice;
          ^
./libavfilter/metal/utils.h:25:6: note: annotate
'ff_metal_compute_encoder_dispatch' with an availability attribute to
silence this warning
void ff_metal_compute_encoder_dispatch(id<MTLDevice> device,
     ^
./libavfilter/metal/utils.h:26:43: error: 'MTLComputePipelineState' is only
available on macOS 10.11 or newer [-Werror,-Wunguarded-availability]
                                       id<MTLComputePipelineState> pipeline,
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/
Metal.framework/Headers/MTLArgumentEncoder.h:17:11:
note: 'MTLComputePipelineState' has been marked as being
      introduced in macOS 10.11 here, but the deployment target is macOS 10.9.
0
@protocol MTLComputePipelineState;
          ^

[snip - way too many messages to paste them all]

Cheers,
  K. C.

- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHA9hIACgkQvgmFNJ1E
3QB0aw//Wsns6KOrT2vlw3RWIyAS1dIrVHO3bBM7NAwl0lYbHkKM6wQpE5sVsSdq
tjAxWH+XikERU2jnHCCZqUormA40iei+WFXKAbZOgrobvrKMeXe/uuQaAmOL3Gkn
o5jvf1+v/Oh3Wd9rSYqdPu+b7VWyz0qj5y8jgBxPtrapfIBh35HBt/41JbVln/PY
d3+h+siAHuBUk1jLHTVep0qe5o3q+mB6m0As9bpGBoQD8oPhQvJxBMqzzzos3mOx
bgVA36NowZEiH8YpEXBMaHk8Ek6k1/37kexinvlRBCmk59mfACShfBJc8J0EC+ii
BVMF6OQvoQ3mHXT79fcd5xV7dueXzLGNAbaK+FQ7ZvAjQ2aEh7xVghH5I8hgRUKT
8JS1RS6e817+IsSlxFA0UvZ6waF/HINfUXpL0Ca4hFirFKSHRxaMIF/49EPgLk4g
mK/NSvNVIbEN6tpz0Kt0t3cvVEp0O5AoKPAwEuCTWa8io13hgHxlOX0TFMS+3d2A
CRuqROxEpAcOjYo92wWa/S1VFl4lDNBcxHnszA9sLRai7QTdxKmojoU+ti8PqTJa
iDoMVIiH4psyzMMqod7kas06w+KSnr7IyW3bKE50atUBY0P9BCqH1e7/mZ+gn0JM
ZSb61Lo9k0aYbHG7rTtXR4Wvtiao9NFCbD8NbHWPfrSRgs9jqP4=
=/fRX
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Ridley Combs]

Could you try with this patch and let me know if it works for you then? https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43 <https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43>

If you can test actual deployment on a 10.9 or 10.10 system that'd be great.

> On Dec 20, 2021, at 15:30, Helmut K. C. Tessarek <tessarek@evermeet.cx> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Hello,
> 
> The following 2 commits break the build with a deployment target of 10.9 on
> macOS.
> 
> I agree that 10.9 is quite old, but the rest of the code worked perfectly
> fine, so were those 2 commits really necessary?
> 
> * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
> vf_yadif_videotoolbox (Aman Karmani)
> * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
> (Aman Karmani)
> 
> Can you make that code conditional?
> 
> 
> The error messages I get during the compile run are:
> 
> In file included from libavfilter/metal/utils.m:20:
> ./libavfilter/metal/utils.h:25:43: error: 'MTLDevice' is only available on
> macOS 10.11 or newer [-Werror,-Wunguarded-availability]
> void ff_metal_compute_encoder_dispatch(id<MTLDevice> device,
>                                          ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/
> Metal.framework/Headers/MTLCaptureScope.h:14:11:
> note: 'MTLDevice' has been marked as being introduced in macOS
>      10.11 here, but the deployment target is macOS 10.9.0
> @protocol MTLDevice;
>          ^
> ./libavfilter/metal/utils.h:25:6: note: annotate
> 'ff_metal_compute_encoder_dispatch' with an availability attribute to
> silence this warning
> void ff_metal_compute_encoder_dispatch(id<MTLDevice> device,
>     ^
> ./libavfilter/metal/utils.h:26:43: error: 'MTLComputePipelineState' is only
> available on macOS 10.11 or newer [-Werror,-Wunguarded-availability]
>                                       id<MTLComputePipelineState> pipeline,
>                                          ^
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/
> Metal.framework/Headers/MTLArgumentEncoder.h:17:11:
> note: 'MTLComputePipelineState' has been marked as being
>      introduced in macOS 10.11 here, but the deployment target is macOS 10.9.
> 0
> @protocol MTLComputePipelineState;
>          ^
> 
> [snip - way too many messages to paste them all]
> 
> Cheers,
>  K. C.
> 
> - -- 
> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
> 
> /*
>   Thou shalt not follow the NULL pointer for chaos and madness
>   await thee at its end.
> */
> -----BEGIN PGP SIGNATURE-----
> 
> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHA9hIACgkQvgmFNJ1E
> 3QB0aw//Wsns6KOrT2vlw3RWIyAS1dIrVHO3bBM7NAwl0lYbHkKM6wQpE5sVsSdq
> tjAxWH+XikERU2jnHCCZqUormA40iei+WFXKAbZOgrobvrKMeXe/uuQaAmOL3Gkn
> o5jvf1+v/Oh3Wd9rSYqdPu+b7VWyz0qj5y8jgBxPtrapfIBh35HBt/41JbVln/PY
> d3+h+siAHuBUk1jLHTVep0qe5o3q+mB6m0As9bpGBoQD8oPhQvJxBMqzzzos3mOx
> bgVA36NowZEiH8YpEXBMaHk8Ek6k1/37kexinvlRBCmk59mfACShfBJc8J0EC+ii
> BVMF6OQvoQ3mHXT79fcd5xV7dueXzLGNAbaK+FQ7ZvAjQ2aEh7xVghH5I8hgRUKT
> 8JS1RS6e817+IsSlxFA0UvZ6waF/HINfUXpL0Ca4hFirFKSHRxaMIF/49EPgLk4g
> mK/NSvNVIbEN6tpz0Kt0t3cvVEp0O5AoKPAwEuCTWa8io13hgHxlOX0TFMS+3d2A
> CRuqROxEpAcOjYo92wWa/S1VFl4lDNBcxHnszA9sLRai7QTdxKmojoU+ti8PqTJa
> iDoMVIiH4psyzMMqod7kas06w+KSnr7IyW3bKE50atUBY0P9BCqH1e7/mZ+gn0JM
> ZSb61Lo9k0aYbHG7rTtXR4Wvtiao9NFCbD8NbHWPfrSRgs9jqP4=
> =/fRX
> -----END PGP SIGNATURE-----
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Thanks for the rwply.

On 2021-12-20 18:25, Ridley Combs wrote:
> Could you try with this patch and let me know if it works for you then? 
> https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43

I've applied your patch and get the following now:

CC	libavfilter/scale_eval.o
CC	libavfilter/scene_sad.o
libavfilter/metal/vf_yadif_videotoolbox.metal:47:1: error: constant sampler
must be declared constexpr
const sampler s(coord::pixel);
^
constexpr
libavfilter/metal/vf_yadif_videotoolbox.metal:122:14: error: use of
undeclared identifier 'max3'
    T diff = max3(tdiff0, tdiff1, tdiff2);
             ^
libavfilter/metal/vf_yadif_videotoolbox.metal:152:9: note: in instantiation
of function template specialization 'temporal_predictor<float>' requested here
        temporal_predictor(A.x, B.x, C.x, D.x, E.x, F.x,
        ^
libavfilter/metal/vf_yadif_videotoolbox.metal:125:18: error: use of
undeclared identifier 'max3'
        T maxi = max3(p2 - p3, p2 - p1, min(p0 - p1, p4 - p3));
                 ^
libavfilter/metal/vf_yadif_videotoolbox.metal:126:18: error: use of
undeclared identifier 'min3'
        T mini = min3(p2 - p3, p2 - p1, max(p0 - p1, p4 - p3));
                 ^
libavfilter/metal/vf_yadif_videotoolbox.metal:217:12: error: no matching
function for call to 'temporal_predictor'
    return temporal_predictor(A, B, C, D, E, F, G, H, I, J, K, L,
           ^~~~~~~~~~~~~~~~~~
libavfilter/metal/vf_yadif_videotoolbox.metal:233:16: note: in instantiation
of function template specialization 'yadif_compute_temporal<float>'
requested here
        return yadif_compute_temporal(cur, prev, cur, next, next,
spatial_pred, params.skip_spatial_check, pos);
               ^
libavfilter/metal/vf_yadif_videotoolbox.metal:265:23: note: in instantiation
of function template specialization 'yadif<float>' requested here
        pred = float2(yadif<float>(dst, prev, cur, next, params, pos));
                      ^
libavfilter/metal/vf_yadif_videotoolbox.metal:108:3: note: candidate
template ignored: substitution failure [with T = float]
T temporal_predictor(T A, T B, T C, T D, T E, T F,
  ^
5 errors generated.
make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1
make: *** Waiting for unfinished jobs....
libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:'
not found (return type defaults to 'id') [-Wobjc-method-access]
        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
                    ^~~~~~~~~~~~~~
libavfilter/metal/utils.m:33:36: error: use of undeclared identifier
'MTLGPUFamilyCommon3'
        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
                                   ^
1 warning and 1 error generated.
make: *** [libavfilter/metal/utils.o] Error 1
Error compiling ffmpeg...

> If you can test actual deployment on a 10.9 or 10.10 system that'd be
> great.

Unfortunately I don't have a 10.9 or 10.10 system. I compile on macOS 1.14
with export MACOSX_DEPLOYMENT_TARGET=10.9

Cheers,
  K. C.

- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBFpsACgkQvgmFNJ1E
3QDapA//WmxnoAqIGCqliaSIUpRkL/KxhSpj9ULJzL1h9yw6Ls0DIYT39Pa66hTk
IABKgLiTNxe1hNTC9kbXf6HdNqJw7KGGUlCGu777RHhh7wySq355g7b89f1wrSJa
1RwCkb9EoyC/DzeSnayDk6oOO7duJxCibkdTXEsYW9VgA9QGSriTHIRSG666UgXO
NC6EyjiOfGqlVkTr9Ott+r2t30H/0faihttbIhLwV6y/Dd/vx4mdG4y61B0PXLX1
rAQwDP9GYkAa302XLeLSTTJ/IHzsV7xD1eE+I3QcB63gbzKlujfbSBiOf9Czv6Vs
M1xoRbcqYkTi7zK45t7w+FuAMn/her/P5cCjmXbEQIHBZEfX3r2MKtkdIAhHsUPl
vDvR7Zmi90gRorQnyQ1fy/LaIcZt6E6CFPKQrIVkBsOnIuXvnrx4fxsvo4rYO32p
goyhtmBMyg9zIZy4eSUn/3M5NKMifgSQrYdUIIKrJZr4ENesKTGB/EZXS30v5VF4
7GrObWDT1oR+VoUiMSYrGPSBlF8R/NHJGU/BL7iVFtF7CfFRnHmfgzyII8RlS6G+
V5stD8eKNr/8fzI3sjQfiROEMtLFKJz4Zkf6qmBT7zeDizNJp/xaGc2egsC7LMzX
or7vCtN6YKPXhQimhsrxDvIXLdvt2ZsCwcbNpq5ZzEMi8mDgwCs=
=DJOy
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Ridley Combs]

Try with this as well: https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e <https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e>


> On Dec 20, 2021, at 17:49, Helmut K. C. Tessarek <tessarek@evermeet.cx> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> Thanks for the rwply.
> 
> On 2021-12-20 18:25, Ridley Combs wrote:
>> Could you try with this patch and let me know if it works for you then? 
>> https://gist.github.com/7362df8a689c41b9174ac50fdeda3e43
> 
> I've applied your patch and get the following now:
> 
> CC	libavfilter/scale_eval.o
> CC	libavfilter/scene_sad.o
> libavfilter/metal/vf_yadif_videotoolbox.metal:47:1: error: constant sampler
> must be declared constexpr
> const sampler s(coord::pixel);
> ^
> constexpr
> libavfilter/metal/vf_yadif_videotoolbox.metal:122:14: error: use of
> undeclared identifier 'max3'
>    T diff = max3(tdiff0, tdiff1, tdiff2);
>             ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:152:9: note: in instantiation
> of function template specialization 'temporal_predictor<float>' requested here
>        temporal_predictor(A.x, B.x, C.x, D.x, E.x, F.x,
>        ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:125:18: error: use of
> undeclared identifier 'max3'
>        T maxi = max3(p2 - p3, p2 - p1, min(p0 - p1, p4 - p3));
>                 ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:126:18: error: use of
> undeclared identifier 'min3'
>        T mini = min3(p2 - p3, p2 - p1, max(p0 - p1, p4 - p3));
>                 ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:217:12: error: no matching
> function for call to 'temporal_predictor'
>    return temporal_predictor(A, B, C, D, E, F, G, H, I, J, K, L,
>           ^~~~~~~~~~~~~~~~~~
> libavfilter/metal/vf_yadif_videotoolbox.metal:233:16: note: in instantiation
> of function template specialization 'yadif_compute_temporal<float>'
> requested here
>        return yadif_compute_temporal(cur, prev, cur, next, next,
> spatial_pred, params.skip_spatial_check, pos);
>               ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:265:23: note: in instantiation
> of function template specialization 'yadif<float>' requested here
>        pred = float2(yadif<float>(dst, prev, cur, next, params, pos));
>                      ^
> libavfilter/metal/vf_yadif_videotoolbox.metal:108:3: note: candidate
> template ignored: substitution failure [with T = float]
> T temporal_predictor(T A, T B, T C, T D, T E, T F,
>  ^
> 5 errors generated.
> make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1
> make: *** Waiting for unfinished jobs....
> libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:'
> not found (return type defaults to 'id') [-Wobjc-method-access]
>        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
>                    ^~~~~~~~~~~~~~
> libavfilter/metal/utils.m:33:36: error: use of undeclared identifier
> 'MTLGPUFamilyCommon3'
>        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
>                                   ^
> 1 warning and 1 error generated.
> make: *** [libavfilter/metal/utils.o] Error 1
> Error compiling ffmpeg...
> 
>> If you can test actual deployment on a 10.9 or 10.10 system that'd be
>> great.
> 
> Unfortunately I don't have a 10.9 or 10.10 system. I compile on macOS 1.14
> with export MACOSX_DEPLOYMENT_TARGET=10.9
> 
> Cheers,
>  K. C.
> 
> - -- 
> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
> 
> /*
>   Thou shalt not follow the NULL pointer for chaos and madness
>   await thee at its end.
> */
> -----BEGIN PGP SIGNATURE-----
> 
> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBFpsACgkQvgmFNJ1E
> 3QDapA//WmxnoAqIGCqliaSIUpRkL/KxhSpj9ULJzL1h9yw6Ls0DIYT39Pa66hTk
> IABKgLiTNxe1hNTC9kbXf6HdNqJw7KGGUlCGu777RHhh7wySq355g7b89f1wrSJa
> 1RwCkb9EoyC/DzeSnayDk6oOO7duJxCibkdTXEsYW9VgA9QGSriTHIRSG666UgXO
> NC6EyjiOfGqlVkTr9Ott+r2t30H/0faihttbIhLwV6y/Dd/vx4mdG4y61B0PXLX1
> rAQwDP9GYkAa302XLeLSTTJ/IHzsV7xD1eE+I3QcB63gbzKlujfbSBiOf9Czv6Vs
> M1xoRbcqYkTi7zK45t7w+FuAMn/her/P5cCjmXbEQIHBZEfX3r2MKtkdIAhHsUPl
> vDvR7Zmi90gRorQnyQ1fy/LaIcZt6E6CFPKQrIVkBsOnIuXvnrx4fxsvo4rYO32p
> goyhtmBMyg9zIZy4eSUn/3M5NKMifgSQrYdUIIKrJZr4ENesKTGB/EZXS30v5VF4
> 7GrObWDT1oR+VoUiMSYrGPSBlF8R/NHJGU/BL7iVFtF7CfFRnHmfgzyII8RlS6G+
> V5stD8eKNr/8fzI3sjQfiROEMtLFKJz4Zkf6qmBT7zeDizNJp/xaGc2egsC7LMzX
> or7vCtN6YKPXhQimhsrxDvIXLdvt2ZsCwcbNpq5ZzEMi8mDgwCs=
> =DJOy
> -----END PGP SIGNATURE-----

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 2021-12-20 19:06, Ridley Combs wrote:
> Try with this as well:
> https://gist.github.com/499380d8ea03a86fc89eb48803ff7b2e

Getting closer...

CC	libavfilter/generate_wave_table.o
CC	libavfilter/graphdump.o
CC	libavfilter/graphparser.o
CC	libavfilter/lavfutils.o
CC	libavfilter/lswsutils.o
OBJCC	libavfilter/metal/utils.o
HOSTLD	ffbuild/bin2c
xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air
CC	libavfilter/motion_estimation.o
CC	libavfilter/pthread.o
CC	libavfilter/qp_table.o
CC	libavfilter/scale_eval.o
CC	libavfilter/scene_sad.o
LLVM ERROR: Error opening
'/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchai
n/usr/metal/ios/bin/../lib/clang/902.9/lib/darwin/libmetal_rt_osx_air1.8.a':
No such file or directory!
metal: error: metallib command failed with exit code 1 (use -v to see
invocation)
make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1
make: *** Waiting for unfinished jobs....
libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:'
not found (return type defaults to 'id') [-Wobjc-method-access]
        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
                    ^~~~~~~~~~~~~~
libavfilter/metal/utils.m:33:36: error: use of undeclared identifier
'MTLGPUFamilyCommon3'
        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
                                   ^
1 warning and 1 error generated.
make: *** [libavfilter/metal/utils.o] Error 1



- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBHDAACgkQvgmFNJ1E
3QB1JA//bYQtbCqvB7/o0+W6VoUMiXi3XAV5OdP1sFwZg0ILSh+ARBfzPGhoFgPe
CLwKQ93+K0bmzICFgFaXjVRoVOvHyDR07/nMNc0nnXWjrIL59hRioJbx/AKFXMzs
EjXKwTfXiySI3L+8s2z/m3UQAaNbzdGcWBZgWsFVKeD/Lwl8W8ziGQvY3VeyNd2j
FXjCG9X3hN5rw8uXUFHx/xMDu6gNQa+0FMQaTdsWw5AmHmvVW/Xmg5p+h155PTHJ
UoYFtZ/RF36/i0HrA9IomppJj6Mpgy27z8YdAGn3AupWABxb+uraMHIODgq0OJVL
zgZFYCDtNT9ujxe4EF8s7MKQMCUUK8kP4NVka0miE4keCp8TjdLZzpP+HHcEqh1P
xENKjaF0D3RhrRdfu53miE4NCj0KyaWTALwC3mg7R+yPhqVaxqTm0ADYGmUruP2d
+8qzkhctRpmnoFvy+Ar07924py0kcLX4retDiw+qel5H3KjLi5HtNkycgpDx1KGN
cHtxqUm8xC6NA6vVw0xNmfz0aSWe/ANJ5HepqBbdqzr4YH5ykKGWr65ynVxRh/gP
muc/EG77T+UoXN9cRmXVqSLRNh0I+IxtqvSZFFDHTWSLJPGpq9MjlKGj7gTLOZpU
Qp0X5Q+E9zU0URXaLOktN+QPbTL7uUHTOddGkzjwyl+rg5Qkp9Q=
=Wsah
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek <tessarek@evermeet.cx>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hello,
>
> The following 2 commits break the build with a deployment target of 10.9 on
> macOS.
>
> I agree that 10.9 is quite old, but the rest of the code worked perfectly
> fine, so were those 2 commits really necessary?
>
> * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
> vf_yadif_videotoolbox (Aman Karmani)
> * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
> (Aman Karmani)
>
> Can you make that code conditional?
>

To tack on to this, I currently am also experiencing issues with those
commits, but am running on 10.15, however, my issue isn't necessarily that
the code isn't compiling, but rather it seems it's failing to link with

xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air
air-lld: error: library not found for -lmetal_rt_osx_air2.2
metal: error: air-lld command failed with exit code 1 (use -v to see
invocation)
make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1

currently running a fresh clone of FFmpeg and only ran ./configure and then
make. If I run

xcrun metal
-L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin
libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air

then it succeeds, I don't think there's currently a way to export LDFLAGS
to metal as the rule for it is a simple `$(METALCC) $< -o $@`

So I've exported "LIBRARY_PATH" to
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin"
in the profile since I can't easily update that on all of my CI
configurations.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Aman Karmani]

On Mon, Dec 20, 2021 at 4:12 PM Christopher Degawa <ccom@randomderp.com>
wrote:

> On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek <
> tessarek@evermeet.cx>
> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> > Hello,
> >
> > The following 2 commits break the build with a deployment target of 10.9
> on
> > macOS.
> >
> > I agree that 10.9 is quite old, but the rest of the code worked perfectly
> > fine, so were those 2 commits really necessary?
> >
> > * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
> > vf_yadif_videotoolbox (Aman Karmani)
> > * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
> > (Aman Karmani)
> >
> > Can you make that code conditional?
> >
>
> To tack on to this, I currently am also experiencing issues with those
> commits, but am running on 10.15, however, my issue isn't necessarily that
> the code isn't compiling, but rather it seems it's failing to link with
>
> xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air
> air-lld: error: library not found for -lmetal_rt_osx_air2.2
> metal: error: air-lld command failed with exit code 1 (use -v to see
> invocation)
> make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1
>
> currently running a fresh clone of FFmpeg and only ran ./configure and then
> make. If I run
>
> xcrun metal
>
> -L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin
> libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air
>
> then it succeeds, I don't think there's currently a way to export LDFLAGS
> to metal as the rule for it is a simple `$(METALCC) $< -o $@`
>
> So I've exported "LIBRARY_PATH" to
>
> "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin"
> in the profile since I can't easily update that on all of my CI
> configurations.
>

Could you share the output of `xcrun metal -v`



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 6:39 PM Aman Karmani <ffmpeg@tmm1.net> wrote:

>
> Could you share the output of `xcrun metal -v`
>
>
xcrun metal -v
Apple LLVM version 31001.43 (metalfe-31001.43)
Target: air64-apple-darwin19.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Aman Karmani]

On Mon, Dec 20, 2021 at 4:43 PM Christopher Degawa <ccom@randomderp.com>
wrote:

> On Mon, Dec 20, 2021 at 6:39 PM Aman Karmani <ffmpeg@tmm1.net> wrote:
>
> >
> > Could you share the output of `xcrun metal -v`
> >
> >
> xcrun metal -v
> Apple LLVM version 31001.43 (metalfe-31001.43)
> Target: air64-apple-darwin19.6.0
> Thread model: posix
> InstalledDir:
>
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
>

Thanks. Here's mine:

Apple metal version 31001.332 (metalfe-31001.332)
Target: air64-apple-darwin20.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin

Somehow yours is defaulting to the iOS binary. Do you have some environment
variable set that could be causing this?

Aman


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 2021-12-20 19:50, Aman Karmani wrote:
> Somehow yours is defaulting to the iOS binary. Do you have some
> environment variable set that could be causing this?

Even though this question was addressed to Christopher, my output also shows
ios. And I certainly do not have anything set or exported that could have to
do with ios. I never touch any ios or ipados crap.


- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJdoACgkQvgmFNJ1E
3QCz7g//axGIusrkxtgXhwNO6RxBUB0xh4rpapBY+OvzRtx7Dus5gxaVZ09RPDIl
nn+dIY43xranJUgAZp9WPQM5qVwWD/UKyriD3xi+0GpXBafv/6VVZkRL6vngPWZT
TjStpcqzFDmAyI0CaonH5wrVuH2yhMvMLbI6uul63cMARA6i02qAf24ty1B4wj0N
Pg1bOArOf2Q5QiQQRJn0H0uGs+2ocLuGlGFrRtXMcdIEu9RD9F1702a57ORgXvlr
AKWU6VtE+0SvKYCD6ell8gO+UOD+RrH6Az8u1yh132HLYTpcbzQzLJYrRFzbvjDr
UdEFTzFGRv7CriO3DSHLtZ/O5xNiVV90i+awYl5D7ZcNOxHxNYsJjj+wJi7yukGd
Rg0PlfCi+g2dEl+IFwtNDIFKVwWjWk718LiQCIYbttThMoa+a67q/Ce6QLoa3Nyl
VRhG6b8G854ZDvBkVuNb0QSENBKMadDGPCVWLdExOrup7FJEuOYkyarIlqgIqG97
7g3d6ekDHAoilFjjd/qwER2/xPnrZHQvNwlLaZgLQHjdYBOV/yH9lNo5NJ/uZBkB
mREcP/JJNVtOc862bjY68FhruGsBHKq/KHMggS7oFiNimnXOEvVNua0gCowhuVUe
k8dnYLqtgsVJ3d77s8wnxURZ3SOGjTWYN3HfOrQq/vYwibs7TBU=
=Bp9l
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



On 2021-12-20 19:38, Aman Karmani wrote:
> Could you share the output of `xcrun metal -v`

$ xcrun metal -v
Apple LLVM version 902.9 (metalfe-902.9.61)
Target: air64-apple-darwin18.7.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
/usr/metal/ios/bin

- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJUsACgkQvgmFNJ1E
3QC1ABAAmoeEXNt0/GKbKI2dc6VXiRugw7B6HoCf13BD3cemZ3FYZSeOwBGEOOi3
FfPWivhvbY1KvDl2nFX/hTrNWHuKUX1XEF7W4cmTyIcDxqwP7jKMShCWzo8wgEpE
DUj7ExdQbQlIYEL+1OitRinuuxR2bLkk5tOIHnDAqlTSq3Qp+WyBwNzuDTyJtPHH
uHBZV8dFpIwpUBfyEA5zZzOWIZpDoEzZZ1HWijktME/AVV0EaYVwTB8LiYELCL5w
zMcHfGt6Ujy1MglTnjJnzeoi9LciHw6+AFd+jsWwvYdGxe47XbN+EBN/XK/A5VAm
Gxw9NVNt+CIyoFN2Mk4nDxwpFzlerM9oZy1LpFOQ9teQB9xpdlhrQRvB72B1+IMM
j1Yot1qGY53CFeEi4k4Q/ng8rDPilxcYA4MYk85I3r27hr7l1V7+4mh6WWdklPEj
GZmQZwkjzlFHgehz3XkJfKvjQ8uMI8IA/hWSMsiSav8S1UUafwvpSPIx1qce6yc4
SLFkb52C0QobesSH0PlR2UclyuapTp9+vBOnznNmW0oIWrD2nLG38ijQBMhp3E5C
2DuXUhhTpgM4GmphaVptwG5U2VNbqE1/zh6shXV15TAfSJCYp5O9ediUbgCDM8RA
MshlAoAZE3T42pnh28DQpuxoXTDrvWtXOEsTZOHvopdRFEQO/y4=
=ZwX1
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Aman Karmani]

On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <tessarek@evermeet.cx>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> On 2021-12-20 19:38, Aman Karmani wrote:
> > Could you share the output of `xcrun metal -v`
>
> $ xcrun metal -v
> Apple LLVM version 902.9 (metalfe-902.9.61)
> Target: air64-apple-darwin18.7.0
> Thread model: posix
> InstalledDir:
>
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
> /usr/metal/ios/bin
>

I am able to get the ios binary too, but only when I request is explicitly
as follows:

$ xcrun -sdk $(xcodebuild -sdk iphoneos -version Path) metal -v

Apple metal version 31001.325 (metalfe-31001.325)
Target: air64-apple-darwin20.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin


>
> - --
> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
>
> /*
>    Thou shalt not follow the NULL pointer for chaos and madness
>    await thee at its end.
> */
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJUsACgkQvgmFNJ1E
> 3QC1ABAAmoeEXNt0/GKbKI2dc6VXiRugw7B6HoCf13BD3cemZ3FYZSeOwBGEOOi3
> FfPWivhvbY1KvDl2nFX/hTrNWHuKUX1XEF7W4cmTyIcDxqwP7jKMShCWzo8wgEpE
> DUj7ExdQbQlIYEL+1OitRinuuxR2bLkk5tOIHnDAqlTSq3Qp+WyBwNzuDTyJtPHH
> uHBZV8dFpIwpUBfyEA5zZzOWIZpDoEzZZ1HWijktME/AVV0EaYVwTB8LiYELCL5w
> zMcHfGt6Ujy1MglTnjJnzeoi9LciHw6+AFd+jsWwvYdGxe47XbN+EBN/XK/A5VAm
> Gxw9NVNt+CIyoFN2Mk4nDxwpFzlerM9oZy1LpFOQ9teQB9xpdlhrQRvB72B1+IMM
> j1Yot1qGY53CFeEi4k4Q/ng8rDPilxcYA4MYk85I3r27hr7l1V7+4mh6WWdklPEj
> GZmQZwkjzlFHgehz3XkJfKvjQ8uMI8IA/hWSMsiSav8S1UUafwvpSPIx1qce6yc4
> SLFkb52C0QobesSH0PlR2UclyuapTp9+vBOnznNmW0oIWrD2nLG38ijQBMhp3E5C
> 2DuXUhhTpgM4GmphaVptwG5U2VNbqE1/zh6shXV15TAfSJCYp5O9ediUbgCDM8RA
> MshlAoAZE3T42pnh28DQpuxoXTDrvWtXOEsTZOHvopdRFEQO/y4=
> =ZwX1
> -----END PGP SIGNATURE-----
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani <ffmpeg@tmm1.net> wrote:

> On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <
> tessarek@evermeet.cx>
> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> >
> >
> > On 2021-12-20 19:38, Aman Karmani wrote:
> > > Could you share the output of `xcrun metal -v`
> >
> > $ xcrun metal -v
> > Apple LLVM version 902.9 (metalfe-902.9.61)
> > Target: air64-apple-darwin18.7.0
> > Thread model: posix
> > InstalledDir:
> >
> >
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
> > /usr/metal/ios/bin
> >
>
> I am able to get the ios binary too, but only when I request is explicitly
> as follows:
>
> $ xcrun -sdk $(xcodebuild -sdk iphoneos -version Path) metal -v
>
> Apple metal version 31001.325 (metalfe-31001.325)
> Target: air64-apple-darwin20.6.0
> Thread model: posix
> InstalledDir:
>
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
>
>

Running `xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal
libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air` does indeed compile
properly and properly shows macos

xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal -v
Apple LLVM version 31001.143 (metalfe-31001.143)
Target: air64-apple-darwin19.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin

and I can indeed have FFmpeg configure and make with `./configure
--metalcc="xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal"`, but
that would sorta ruin the whole idea of being able to simply clone and
./configure and make.

I tried looking online, and I guess maybe it's not something often asked as
I could not find relevant results to how to set the default xcrun sdk, so
I'm not sure how to make that -sdk flag apply to all xcruns regardless of
configure flags
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Aman Karmani]

On Mon, Dec 20, 2021 at 5:19 PM Christopher Degawa <ccom@randomderp.com>
wrote:

> On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani <ffmpeg@tmm1.net> wrote:
>
> > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <
> > tessarek@evermeet.cx>
> > wrote:
> >
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA512
> > >
> > >
> > >
> > > On 2021-12-20 19:38, Aman Karmani wrote:
> > > > Could you share the output of `xcrun metal -v`
> > >
> > > $ xcrun metal -v
> > > Apple LLVM version 902.9 (metalfe-902.9.61)
> > > Target: air64-apple-darwin18.7.0
> > > Thread model: posix
> > > InstalledDir:
> > >
> > >
> >
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
> > > /usr/metal/ios/bin
> > >
> >
> > I am able to get the ios binary too, but only when I request is
> explicitly
> > as follows:
> >
> > $ xcrun -sdk $(xcodebuild -sdk iphoneos -version Path) metal -v
> >
> > Apple metal version 31001.325 (metalfe-31001.325)
> > Target: air64-apple-darwin20.6.0
> > Thread model: posix
> > InstalledDir:
> >
> >
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
> >
> >
>
> Running `xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal
> libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air` does indeed compile
> properly and properly shows macos
>

Great, thanks for the confirmation!


>
> xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal -v
> Apple LLVM version 31001.143 (metalfe-31001.143)
> Target: air64-apple-darwin19.6.0
> Thread model: posix
> InstalledDir:
>
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin
>
> and I can indeed have FFmpeg configure and make with `./configure
> --metalcc="xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal"`, but
> that would sorta ruin the whole idea of being able to simply clone and
> ./configure and make.
>

Cool, that's also good to hear.

Does this work for you?

$ xcrun --sdk macosx metal -v

If so, then perhaps this patch is enough?

diff --git a/configure b/configure
index d9d41b2273..c4a59e0e3f 100755
--- a/configure
+++ b/configure
@@ -3842,8 +3842,8 @@ host_cc_default="gcc"
 doxygen_default="doxygen"
 install="install"
 ln_s_default="ln -s -f"
-metalcc_default="xcrun metal"
-metallib_default="xcrun metallib"
+metalcc_default="xcrun --sdk macosx metal"
+metallib_default="xcrun --sdk macosx metallib"
 nm_default="nm -g"
 pkg_config_default=pkg-config
 ranlib_default="ranlib"


>
> I tried looking online, and I guess maybe it's not something often asked as
> I could not find relevant results to how to set the default xcrun sdk, so
> I'm not sure how to make that -sdk flag apply to all xcruns regardless of
> configure flags
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 7:25 PM Aman Karmani <ffmpeg@tmm1.net> wrote:

> On Mon, Dec 20, 2021 at 5:19 PM Christopher Degawa <ccom@randomderp.com>
> wrote:
>
> > On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani <ffmpeg@tmm1.net> wrote:
> >
> > > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <
> > > tessarek@evermeet.cx>
> > > wrote:
> > >
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA512
> > > >
> > > >
> > > >
> > > > On 2021-12-20 19:38, Aman Karmani wrote:
> > > > > Could you share the output of `xcrun metal -v`
> > > >
> > > > $ xcrun metal -v
> > > > Apple LLVM version 902.9 (metalfe-902.9.61)
> > > > Target: air64-apple-darwin18.7.0
> > > > Thread model: posix
> > > > InstalledDir:
> > > >
> > > >
> > >
> >
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
> > > > /usr/metal/ios/bin
> > > >
> > >
> > > I am able to get the ios binary too, but only when I request is
> > explicitly
> > > as follows:
> > >
> > > $ xcrun -sdk $(xcodebuild -sdk iphoneos -version Path) metal -v
> > >
> > > Apple metal version 31001.325 (metalfe-31001.325)
> > > Target: air64-apple-darwin20.6.0
> > > Thread model: posix
> > > InstalledDir:
> > >
> > >
> >
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
> > >
> > >
> >
> > Running `xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal
> > libavfilter/metal/vf_yadif_videotoolbox.metal -o
> > libavfilter/metal/vf_yadif_videotoolbox.metal.air` does indeed compile
> > properly and properly shows macos
> >
>
> Great, thanks for the confirmation!
>
>
> >
> > xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal -v
> > Apple LLVM version 31001.143 (metalfe-31001.143)
> > Target: air64-apple-darwin19.6.0
> > Thread model: posix
> > InstalledDir:
> >
> >
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin
> >
> > and I can indeed have FFmpeg configure and make with `./configure
> > --metalcc="xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal"`,
> but
> > that would sorta ruin the whole idea of being able to simply clone and
> > ./configure and make.
> >
>
> Cool, that's also good to hear.
>
> Does this work for you?
>
> $ xcrun --sdk macosx metal -v
>
> If so, then perhaps this patch is enough?
>
> diff --git a/configure b/configure
> index d9d41b2273..c4a59e0e3f 100755
> --- a/configure
> +++ b/configure
> @@ -3842,8 +3842,8 @@ host_cc_default="gcc"
>  doxygen_default="doxygen"
>  install="install"
>  ln_s_default="ln -s -f"
> -metalcc_default="xcrun metal"
> -metallib_default="xcrun metallib"
> +metalcc_default="xcrun --sdk macosx metal"
> +metallib_default="xcrun --sdk macosx metallib"
>  nm_default="nm -g"
>  pkg_config_default=pkg-config
>  ranlib_default="ranlib"
>
>
>
xcrun --sdk macosx metal -v
Apple LLVM version 31001.143 (metalfe-31001.143)
Target: air64-apple-darwin19.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin

That does seem to work indeed

make
xcrun --sdk macosx metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air
xcrun --sdk macosx metallib --split-module-without-linking
libavfilter/metal/vf_yadif_videotoolbox.metal.air -o
libavfilter/metal/vf_yadif_videotoolbox.metallib
BIN2C   libavfilter/metal/vf_yadif_videotoolbox.metallib.c
CC      libavfilter/metal/vf_yadif_videotoolbox.metallib.o
AR      libavfilter/libavfilter.a
LD      ffmpeg_g
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Ridley Combs]

The main thing that confuses me here is that this file does build for me when I use the iOS version of the metal compiler (tbh I didn't even know there was a difference between them).

What Xcode and macOS version are you on?

> On Dec 20, 2021, at 19:18, Christopher Degawa <ccom@randomderp.com> wrote:
> 
> On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani <ffmpeg@tmm1.net <mailto:ffmpeg@tmm1.net>> wrote:
> 
>> On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek <
>> tessarek@evermeet.cx>
>> wrote:
>> 
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA512
>>> 
>>> 
>>> 
>>> On 2021-12-20 19:38, Aman Karmani wrote:
>>>> Could you share the output of `xcrun metal -v`
>>> 
>>> $ xcrun metal -v
>>> Apple LLVM version 902.9 (metalfe-902.9.61)
>>> Target: air64-apple-darwin18.7.0
>>> Thread model: posix
>>> InstalledDir:
>>> 
>>> 
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
>>> /usr/metal/ios/bin
>>> 
>> 
>> I am able to get the ios binary too, but only when I request is explicitly
>> as follows:
>> 
>> $ xcrun -sdk $(xcodebuild -sdk iphoneos -version Path) metal -v
>> 
>> Apple metal version 31001.325 (metalfe-31001.325)
>> Target: air64-apple-darwin20.6.0
>> Thread model: posix
>> InstalledDir:
>> 
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
>> 
>> 
> 
> Running `xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal
> libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air` does indeed compile
> properly and properly shows macos
> 
> xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal -v
> Apple LLVM version 31001.143 (metalfe-31001.143)
> Target: air64-apple-darwin19.6.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin
> 
> and I can indeed have FFmpeg configure and make with `./configure
> --metalcc="xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal"`, but
> that would sorta ruin the whole idea of being able to simply clone and
> ./configure and make.
> 
> I tried looking online, and I guess maybe it's not something often asked as
> I could not find relevant results to how to set the default xcrun sdk, so
> I'm not sure how to make that -sdk flag apply to all xcruns regardless of
> configure flags
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 7:29 PM Ridley Combs <rcombs@rcombs.me> wrote:

> The main thing that confuses me here is that this file does build for me
> when I use the iOS version of the metal compiler (tbh I didn't even know
> there was a difference between them).
>
> What Xcode and macOS version are you on?
>


system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: macOS 10.15.7 (19H1615)
      Kernel Version: Darwin 19.6.0


xcodebuild -version
Xcode 12.3
Build version 12C5020f

xcrun --version
xcrun version 59.

I don't know what other versions might be beneficial here.

I can't (don't want to) upgrade the macOS system version atm since last
time I tried it via softwareupdate, it managed to make the device
unresponsive until someone physically rebooted it and managed to do the
same with an aws mac1.metal instance running 12.0 just today.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 2021-12-20 19:11, Christopher Degawa wrote:
> So I've exported "LIBRARY_PATH" to

I'm sorry to say, this is a workaround but hardly a solution.

Before these 2 commits all worked perfectly. Now it doesn't. Tweaking the
build env is not a solution.
Next time someone commits something, are we supposed to tweak it again?
Where does it end?


- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJ/EACgkQvgmFNJ1E
3QDsJg//WzTdNngpbNhCihB0foMLjtL687/1FWqZKPfsCx5pvvLZq/Xj8cd1G2G5
XJOehG1YYkjKXE+I1oWBrRxxQ/1mkW49DjX6jyzGUFPvEV+e0yf6f6TUPrE9IYDw
nFkIq25rjJMo/+IPxklHw1bIuZxoqo4ohgYHfmcyYJWOPDBXRWCd93GJkbWJy3Cv
fRRp4/gIeQJJzlld1ISqGLP6GDIwrevtW7oUwUZbwIWvnJyl25UdnHLAMl82fQPu
QnCEuWgRODXI1eaYNXf15MwD6gGy39n7njon4AJ5C63678Yc2H0FfVh6wI9lIv1e
LR6WY942ziQx8uqr3y/2IV5wGDSvLZqyEvCMSh199xTcJdfL4WNEZlNS8hlWxN51
TfLHBLpjJHqEq2i6+hyaYF4Y3M9ctRa/JVjv1EjciXFWzMx2Ddhehxv0TPu1tY0A
UxiQ0By0hJhZDDzOPxez9DgCs/ecmIcUxq4mKuk6KXLIBfJqFrNIN/Mzsn7hBOI7
EPLui0+Jo+cWB3AsDRIGNO9UwN+gZAGKxGHt9U9//Af5rzzY0TQ09Z+To14BxD0V
lTqDp69JlsutJIpQfOywkPb5ExaFgX7vYZmXEb1f05zlIScIeBRdPxKJ9Sip2Cyo
AVzTsQIDTGkNM3KUJE8m3EgrX8V+gJOXKtfK+phUr5YvyhP5IpE=
=maKQ
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Aman Karmani]

On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek <tessarek@evermeet.cx>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 2021-12-20 19:11, Christopher Degawa wrote:
> > So I've exported "LIBRARY_PATH" to
>
> I'm sorry to say, this is a workaround but hardly a solution.
>

No one said this is the solution. We are just trying to figure out what is
going on, and this added information is very helpful in that effort.


> Before these 2 commits all worked perfectly. Now it doesn't. Tweaking the
> build env is not a solution.
> Next time someone commits something, are we supposed to tweak it again?
> Where does it end?
>

I'm not sure what your point is. If you are having trouble with those
commits, then you can use an older version?

Or you can compile with `./configure --disable-metal` to disable the new
feature.

Obviously the code worked on both my and Ridley's computers. If it didn't
work, we wouldn't have committed it.

Once we figure out why some computers are using the wrong metal binary,
then we can fix it and commit the fix to master as well.


>
>
> - --
> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
>
> /*
>    Thou shalt not follow the NULL pointer for chaos and madness
>    await thee at its end.
> */
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJ/EACgkQvgmFNJ1E
> 3QDsJg//WzTdNngpbNhCihB0foMLjtL687/1FWqZKPfsCx5pvvLZq/Xj8cd1G2G5
> XJOehG1YYkjKXE+I1oWBrRxxQ/1mkW49DjX6jyzGUFPvEV+e0yf6f6TUPrE9IYDw
> nFkIq25rjJMo/+IPxklHw1bIuZxoqo4ohgYHfmcyYJWOPDBXRWCd93GJkbWJy3Cv
> fRRp4/gIeQJJzlld1ISqGLP6GDIwrevtW7oUwUZbwIWvnJyl25UdnHLAMl82fQPu
> QnCEuWgRODXI1eaYNXf15MwD6gGy39n7njon4AJ5C63678Yc2H0FfVh6wI9lIv1e
> LR6WY942ziQx8uqr3y/2IV5wGDSvLZqyEvCMSh199xTcJdfL4WNEZlNS8hlWxN51
> TfLHBLpjJHqEq2i6+hyaYF4Y3M9ctRa/JVjv1EjciXFWzMx2Ddhehxv0TPu1tY0A
> UxiQ0By0hJhZDDzOPxez9DgCs/ecmIcUxq4mKuk6KXLIBfJqFrNIN/Mzsn7hBOI7
> EPLui0+Jo+cWB3AsDRIGNO9UwN+gZAGKxGHt9U9//Af5rzzY0TQ09Z+To14BxD0V
> lTqDp69JlsutJIpQfOywkPb5ExaFgX7vYZmXEb1f05zlIScIeBRdPxKJ9Sip2Cyo
> AVzTsQIDTGkNM3KUJE8m3EgrX8V+gJOXKtfK+phUr5YvyhP5IpE=
> =maKQ
> -----END PGP SIGNATURE-----
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



On 2021-12-20 20:20, Aman Karmani wrote:
> Once we figure out why some computers are using the wrong metal binary, 
> then we can fix it and commit the fix to master as well.

With the 2 patches from Ridley and your configure patch I run into the
following error now:

OBJCC	libavfilter/metal/utils.o
HOSTLD	ffbuild/bin2c
xcrun --sdk macosx metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
libavfilter/metal/vf_yadif_videotoolbox.metal.air
CC	libavfilter/motion_estimation.o
CC	libavfilter/pthread.o
CC	libavfilter/qp_table.o
CC	libavfilter/scale_eval.o
CC	libavfilter/scene_sad.o
CC	libavfilter/setpts.o
CC	libavfilter/settb.o
CC	libavfilter/split.o
CC	libavfilter/src_movie.o
CC	libavfilter/transform.o
CC	libavfilter/trim.o
CC	libavfilter/vaf_spectrumsynth.o
libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:'
not found (return type defaults to 'id') [-Wobjc-method-access]
        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
                    ^~~~~~~~~~~~~~
libavfilter/metal/utils.m:33:36: error: use of undeclared identifier
'MTLGPUFamilyCommon3'
        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
                                   ^
1 warning and 1 error generated.
CC	libavfilter/vf_addroi.o
make: *** [libavfilter/metal/utils.o] Error 1
make: *** Waiting for unfinished jobs....
rm libavfilter/metal/vf_yadif_videotoolbox.metal.air


- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBL3wACgkQvgmFNJ1E
3QBZ5BAApVGHkKD8ZtnnvqOFY9vPAHUdTtSOPPRu/U7bb/16k+rhz9gW7gPyzVbw
eObR2D5z66I7h2ePmNWbHP+i4cIqRfFlcOS+9eWHy0E5G8y0Lx55xncGFZV5wkhI
7OEe0EOo4GE6D6Ro/XwtOnnsy7cuHIt4oX0xT7rlTiITYYdoe+M2zF9nAVJtjUit
hKX3YHBBfryLRjUvQGQAwWR+EjKRT/LPNwhwf2WgxtSP1BGFH5+oROkq2CAdLUO1
7zFb2GkyS7atVYjysQ8QT0aW7ohTlxBpEaak69GhSEkvarZGWplsC8Z3BVZ58qXP
K0VH/fIF7lDMQqTmHkPw0lEz1bMBoqzEUevKVC7h3nFl+GhXPhM9lS3sR/SeBj0U
YBmeHTdcYJPoh9bD4PiU4X4AmMUaAn4+J2nUn6TmmqI952yZVWv9ZKWVPLhyjiTH
qHqtvc3gK4hYo7JhhIP8sJpNiW2OPSUBLEboXQ67YTI6cp30uJI0c0KdRCvkBhNS
zs19mdfaSOseG4vFSgsD0rOGUWprgU8SRf/9EM88WLF8cBEs/bUxRBcalq41RrwB
bB1D2orQoLLYlcdc1B40Wl+X38GcU4Jv3mFbpF5XhnjrwCg6QMx5BS8p8Zt77jov
IzZHnlqaqLrB66iN17UK5nGiBb1st19xyGEwSXctkzOIcOFOjhc=
=4Pni
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Ridley Combs]

Try this (replacing all previous patches): https://gist.github.com/2b1ea91330a748740d608680b0f8abd2 <https://gist.github.com/2b1ea91330a748740d608680b0f8abd2>


> On Dec 20, 2021, at 19:35, Helmut K. C. Tessarek <tessarek@evermeet.cx> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> 
> 
> On 2021-12-20 20:20, Aman Karmani wrote:
>> Once we figure out why some computers are using the wrong metal binary, 
>> then we can fix it and commit the fix to master as well.
> 
> With the 2 patches from Ridley and your configure patch I run into the
> following error now:
> 
> OBJCC	libavfilter/metal/utils.o
> HOSTLD	ffbuild/bin2c
> xcrun --sdk macosx metal libavfilter/metal/vf_yadif_videotoolbox.metal -o
> libavfilter/metal/vf_yadif_videotoolbox.metal.air
> CC	libavfilter/motion_estimation.o
> CC	libavfilter/pthread.o
> CC	libavfilter/qp_table.o
> CC	libavfilter/scale_eval.o
> CC	libavfilter/scene_sad.o
> CC	libavfilter/setpts.o
> CC	libavfilter/settb.o
> CC	libavfilter/split.o
> CC	libavfilter/src_movie.o
> CC	libavfilter/transform.o
> CC	libavfilter/trim.o
> CC	libavfilter/vaf_spectrumsynth.o
> libavfilter/metal/utils.m:33:21: warning: instance method '-supportsFamily:'
> not found (return type defaults to 'id') [-Wobjc-method-access]
>        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
>                    ^~~~~~~~~~~~~~
> libavfilter/metal/utils.m:33:36: error: use of undeclared identifier
> 'MTLGPUFamilyCommon3'
>        if ([device supportsFamily:MTLGPUFamilyCommon3]) {
>                                   ^
> 1 warning and 1 error generated.
> CC	libavfilter/vf_addroi.o
> make: *** [libavfilter/metal/utils.o] Error 1
> make: *** Waiting for unfinished jobs....
> rm libavfilter/metal/vf_yadif_videotoolbox.metal.air
> 
> 
> - -- 
> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
> 
> /*
>   Thou shalt not follow the NULL pointer for chaos and madness
>   await thee at its end.
> */
> -----BEGIN PGP SIGNATURE-----
> 
> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBL3wACgkQvgmFNJ1E
> 3QBZ5BAApVGHkKD8ZtnnvqOFY9vPAHUdTtSOPPRu/U7bb/16k+rhz9gW7gPyzVbw
> eObR2D5z66I7h2ePmNWbHP+i4cIqRfFlcOS+9eWHy0E5G8y0Lx55xncGFZV5wkhI
> 7OEe0EOo4GE6D6Ro/XwtOnnsy7cuHIt4oX0xT7rlTiITYYdoe+M2zF9nAVJtjUit
> hKX3YHBBfryLRjUvQGQAwWR+EjKRT/LPNwhwf2WgxtSP1BGFH5+oROkq2CAdLUO1
> 7zFb2GkyS7atVYjysQ8QT0aW7ohTlxBpEaak69GhSEkvarZGWplsC8Z3BVZ58qXP
> K0VH/fIF7lDMQqTmHkPw0lEz1bMBoqzEUevKVC7h3nFl+GhXPhM9lS3sR/SeBj0U
> YBmeHTdcYJPoh9bD4PiU4X4AmMUaAn4+J2nUn6TmmqI952yZVWv9ZKWVPLhyjiTH
> qHqtvc3gK4hYo7JhhIP8sJpNiW2OPSUBLEboXQ67YTI6cp30uJI0c0KdRCvkBhNS
> zs19mdfaSOseG4vFSgsD0rOGUWprgU8SRf/9EM88WLF8cBEs/bUxRBcalq41RrwB
> bB1D2orQoLLYlcdc1B40Wl+X38GcU4Jv3mFbpF5XhnjrwCg6QMx5BS8p8Zt77jov
> IzZHnlqaqLrB66iN17UK5nGiBb1st19xyGEwSXctkzOIcOFOjhc=
> =4Pni
> -----END PGP SIGNATURE-----
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 2021-12-20 20:39, Ridley Combs wrote:
> Try this (replacing all previous patches): 
> https://gist.github.com/2b1ea91330a748740d608680b0f8abd2

This worked splendidly. All good with this patch.

If you want to test the binary on 10.9 or 10.10, here you go:
https://evermeet.cx/pub/tmp/ffmpeg.zip

I will most likely delete this zip file in a week or so.

Cheers,
  K. C.

- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBPHMACgkQvgmFNJ1E
3QDJzg//YtZzziC8XmQT+kn5XF+q7ql58p84QO0kc61m3s2uqZiS0PZzfCdbmGI2
lfgbzXVHD44TZ29puuUnKlqZTRNRp6HieV1jAGhPSWRSSpDZEDaWiefQHVYSmSAg
+UR9n81btjWV/7EZdvoLVcBGeowUnM2U4/XAQ33OuiBwgY4aRtAFRI2wM3UFt+JF
04CXeemQMoTI0UsgMFN5NJZ4ygob92cKaj0e4Q5t+vfvfD7ArJswi8yLfIGq/j28
Ap+I1a2xK6k6baoPSNT60W0T87g6oHjndESzp7wurYd1xbjlRmKgVBnvkEZcW3JR
cs4e76v+WmiQLh/fw0qmcpy0ALBs4WeqwjtlBhfYxKk7QwRPQZ0mhYAGkHV8ScgI
6gbZY+FZEJhGGR/PH+kmZJspuvpLtviMAMX913nExDXdqQzrKidpWIY4bX2zpVg1
GgKAsug6kFTI5pTLYKub3iTQnWcRiXoazAlmXJn/ZksiGRJHfJqpMf6e9+vVqyYb
tKi4E6vjoxSIqttAngaDskqrw58yzuDcg+TUsZMBCHJK4cIhVWvaIZ/C6ZqAnTvw
QeiknYH7LLMe6JRN+zonemg6qk/lOzvVYlYXb9FN9+GhXpYafJAunqKZUwUiHdt6
OAby2YEu3APXlkmCJnLujuJuzPku6hWukk7OXAKjd50YjGIi1Pw=
=tKI6
-----END PGP SIGNATURE-----
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani <ffmpeg@tmm1.net> wrote:

>
>
> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek <
> tessarek@evermeet.cx> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA512
>>
>> On 2021-12-20 19:11, Christopher Degawa wrote:
>> > So I've exported "LIBRARY_PATH" to
>>
>> I'm sorry to say, this is a workaround but hardly a solution.
>>
>
> No one said this is the solution. We are just trying to figure out what is
> going on, and this added information is very helpful in that effort.
>
>
>> Before these 2 commits all worked perfectly. Now it doesn't. Tweaking the
>> build env is not a solution.
>> Next time someone commits something, are we supposed to tweak it again?
>> Where does it end?
>>
>
> I'm not sure what your point is. If you are having trouble with those
> commits, then you can use an older version?
>
> Or you can compile with `./configure --disable-metal` to disable the new
> feature.
>
> Obviously the code worked on both my and Ridley's computers. If it didn't
> work, we wouldn't have committed it.
>
> Once we figure out why some computers are using the wrong metal binary,
> then we can fix it and commit the fix to master as well.
>


Digging a bit into xcrun itself, looking at
https://real-world-systems.com/docs/xcrun.1.html, it says

> The SDK which will be searched defaults to the most recent available SDK

and

xcodebuild -version -sdk | head
iPhoneOS14.3.sdk - iOS 14.3 (iphoneos14.3)
SDKVersion: 14.3
Path:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk
PlatformVersion: 14.3

Which I'm guessing might be the reason, but still doesn't really make
logical sense and running

xcrun --verbose metal -v
...
xcrun: note: SDKROOT = '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk'
...
xcrun: note: lookup resolved in
'/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
'/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
Apple LLVM version 31001.43 (metalfe-31001.43)
Target: air64-apple-darwin19.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin

which also, doesn't make sense.

exporting SDKROOT to `macosx` does make it show

xcrun: note: SDKROOT =
'/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk'

xcrun: note: lookup resolved in
'/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
'/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
Apple LLVM version 31001.143 (metalfe-31001.143)
Target: air64-apple-darwin19.6.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin

so, I'm not sure what conclusion to bring from this.


>
>>
>>
>> - --
>> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
>> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
>>
>> /*
>>    Thou shalt not follow the NULL pointer for chaos and madness
>>    await thee at its end.
>> */
>> -----BEGIN PGP SIGNATURE-----
>>
>> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJ/EACgkQvgmFNJ1E
>> 3QDsJg//WzTdNngpbNhCihB0foMLjtL687/1FWqZKPfsCx5pvvLZq/Xj8cd1G2G5
>> XJOehG1YYkjKXE+I1oWBrRxxQ/1mkW49DjX6jyzGUFPvEV+e0yf6f6TUPrE9IYDw
>> nFkIq25rjJMo/+IPxklHw1bIuZxoqo4ohgYHfmcyYJWOPDBXRWCd93GJkbWJy3Cv
>> fRRp4/gIeQJJzlld1ISqGLP6GDIwrevtW7oUwUZbwIWvnJyl25UdnHLAMl82fQPu
>> QnCEuWgRODXI1eaYNXf15MwD6gGy39n7njon4AJ5C63678Yc2H0FfVh6wI9lIv1e
>> LR6WY942ziQx8uqr3y/2IV5wGDSvLZqyEvCMSh199xTcJdfL4WNEZlNS8hlWxN51
>> TfLHBLpjJHqEq2i6+hyaYF4Y3M9ctRa/JVjv1EjciXFWzMx2Ddhehxv0TPu1tY0A
>> UxiQ0By0hJhZDDzOPxez9DgCs/ecmIcUxq4mKuk6KXLIBfJqFrNIN/Mzsn7hBOI7
>> EPLui0+Jo+cWB3AsDRIGNO9UwN+gZAGKxGHt9U9//Af5rzzY0TQ09Z+To14BxD0V
>> lTqDp69JlsutJIpQfOywkPb5ExaFgX7vYZmXEb1f05zlIScIeBRdPxKJ9Sip2Cyo
>> AVzTsQIDTGkNM3KUJE8m3EgrX8V+gJOXKtfK+phUr5YvyhP5IpE=
>> =maKQ
>> -----END PGP SIGNATURE-----
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Aman Karmani]

On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa <ccom@randomderp.com>
wrote:

>
>
> On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani <ffmpeg@tmm1.net> wrote:
>
>>
>>
>> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek <
>> tessarek@evermeet.cx> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA512
>>>
>>> On 2021-12-20 19:11, Christopher Degawa wrote:
>>> > So I've exported "LIBRARY_PATH" to
>>>
>>> I'm sorry to say, this is a workaround but hardly a solution.
>>>
>>
>> No one said this is the solution. We are just trying to figure out what
>> is going on, and this added information is very helpful in that effort.
>>
>>
>>> Before these 2 commits all worked perfectly. Now it doesn't. Tweaking the
>>> build env is not a solution.
>>> Next time someone commits something, are we supposed to tweak it again?
>>> Where does it end?
>>>
>>
>> I'm not sure what your point is. If you are having trouble with those
>> commits, then you can use an older version?
>>
>> Or you can compile with `./configure --disable-metal` to disable the new
>> feature.
>>
>> Obviously the code worked on both my and Ridley's computers. If it didn't
>> work, we wouldn't have committed it.
>>
>> Once we figure out why some computers are using the wrong metal binary,
>> then we can fix it and commit the fix to master as well.
>>
>
>
> Digging a bit into xcrun itself, looking at
> https://real-world-systems.com/docs/xcrun.1.html, it says
>
> > The SDK which will be searched defaults to the most recent available SDK
>
> and
>
> xcodebuild -version -sdk | head
> iPhoneOS14.3.sdk - iOS 14.3 (iphoneos14.3)
> SDKVersion: 14.3
> Path:
> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk
> PlatformVersion: 14.3
>
> Which I'm guessing might be the reason, but still doesn't really make
> logical sense and running
>
> xcrun --verbose metal -v
> ...
> xcrun: note: SDKROOT =
> '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk'
> ...
> xcrun: note: lookup resolved in
> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
> Apple LLVM version 31001.43 (metalfe-31001.43)
> Target: air64-apple-darwin19.6.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
>
> which also, doesn't make sense.
>
> exporting SDKROOT to `macosx` does make it show
>
> xcrun: note: SDKROOT =
> '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk'
>
> xcrun: note: lookup resolved in
> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
> Apple LLVM version 31001.143 (metalfe-31001.143)
> Target: air64-apple-darwin19.6.0
> Thread model: posix
> InstalledDir:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin
>
> so, I'm not sure what conclusion to bring from this.
>

Thanks for digging in and documenting this behavior.

It seems like a bug in Xcode to me. Perhaps it's fixed in newer XC, which
is why we're not seeing it?

It may be worth filing a radar either way.


>
>
>>
>>>
>>>
>>> - --
>>> regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
>>> Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944
>>>
>>> /*
>>>    Thou shalt not follow the NULL pointer for chaos and madness
>>>    await thee at its end.
>>> */
>>> -----BEGIN PGP SIGNATURE-----
>>>
>>> iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHBJ/EACgkQvgmFNJ1E
>>> 3QDsJg//WzTdNngpbNhCihB0foMLjtL687/1FWqZKPfsCx5pvvLZq/Xj8cd1G2G5
>>> XJOehG1YYkjKXE+I1oWBrRxxQ/1mkW49DjX6jyzGUFPvEV+e0yf6f6TUPrE9IYDw
>>> nFkIq25rjJMo/+IPxklHw1bIuZxoqo4ohgYHfmcyYJWOPDBXRWCd93GJkbWJy3Cv
>>> fRRp4/gIeQJJzlld1ISqGLP6GDIwrevtW7oUwUZbwIWvnJyl25UdnHLAMl82fQPu
>>> QnCEuWgRODXI1eaYNXf15MwD6gGy39n7njon4AJ5C63678Yc2H0FfVh6wI9lIv1e
>>> LR6WY942ziQx8uqr3y/2IV5wGDSvLZqyEvCMSh199xTcJdfL4WNEZlNS8hlWxN51
>>> TfLHBLpjJHqEq2i6+hyaYF4Y3M9ctRa/JVjv1EjciXFWzMx2Ddhehxv0TPu1tY0A
>>> UxiQ0By0hJhZDDzOPxez9DgCs/ecmIcUxq4mKuk6KXLIBfJqFrNIN/Mzsn7hBOI7
>>> EPLui0+Jo+cWB3AsDRIGNO9UwN+gZAGKxGHt9U9//Af5rzzY0TQ09Z+To14BxD0V
>>> lTqDp69JlsutJIpQfOywkPb5ExaFgX7vYZmXEb1f05zlIScIeBRdPxKJ9Sip2Cyo
>>> AVzTsQIDTGkNM3KUJE8m3EgrX8V+gJOXKtfK+phUr5YvyhP5IpE=
>>> =maKQ
>>> -----END PGP SIGNATURE-----
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>
>>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Mon, Dec 20, 2021 at 7:53 PM Aman Karmani <ffmpeg@tmm1.net> wrote:

>
>
> On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa <ccom@randomderp.com>
> wrote:
>
>>
>>
>> On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani <ffmpeg@tmm1.net> wrote:
>>
>>>
>>>
>>> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek <
>>> tessarek@evermeet.cx> wrote:
>>>
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA512
>>>>
>>>> On 2021-12-20 19:11, Christopher Degawa wrote:
>>>> > So I've exported "LIBRARY_PATH" to
>>>>
>>>> I'm sorry to say, this is a workaround but hardly a solution.
>>>>
>>>
>>> No one said this is the solution. We are just trying to figure out what
>>> is going on, and this added information is very helpful in that effort.
>>>
>>>
>>>> Before these 2 commits all worked perfectly. Now it doesn't. Tweaking
>>>> the
>>>> build env is not a solution.
>>>> Next time someone commits something, are we supposed to tweak it again?
>>>> Where does it end?
>>>>
>>>
>>> I'm not sure what your point is. If you are having trouble with those
>>> commits, then you can use an older version?
>>>
>>> Or you can compile with `./configure --disable-metal` to disable the new
>>> feature.
>>>
>>> Obviously the code worked on both my and Ridley's computers. If it
>>> didn't work, we wouldn't have committed it.
>>>
>>> Once we figure out why some computers are using the wrong metal binary,
>>> then we can fix it and commit the fix to master as well.
>>>
>>
>>
>> Digging a bit into xcrun itself, looking at
>> https://real-world-systems.com/docs/xcrun.1.html, it says
>>
>> > The SDK which will be searched defaults to the most recent available
>> SDK
>>
>> and
>>
>> xcodebuild -version -sdk | head
>> iPhoneOS14.3.sdk - iOS 14.3 (iphoneos14.3)
>> SDKVersion: 14.3
>> Path:
>> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk
>> PlatformVersion: 14.3
>>
>> Which I'm guessing might be the reason, but still doesn't really make
>> logical sense and running
>>
>> xcrun --verbose metal -v
>> ...
>> xcrun: note: SDKROOT =
>> '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk'
>> ...
>> xcrun: note: lookup resolved in
>> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
>> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
>> Apple LLVM version 31001.43 (metalfe-31001.43)
>> Target: air64-apple-darwin19.6.0
>> Thread model: posix
>> InstalledDir:
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
>>
>> which also, doesn't make sense.
>>
>> exporting SDKROOT to `macosx` does make it show
>>
>> xcrun: note: SDKROOT =
>> '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk'
>>
>> xcrun: note: lookup resolved in
>> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
>> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
>> Apple LLVM version 31001.143 (metalfe-31001.143)
>> Target: air64-apple-darwin19.6.0
>> Thread model: posix
>> InstalledDir:
>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin
>>
>> so, I'm not sure what conclusion to bring from this.
>>
>
> Thanks for digging in and documenting this behavior.
>
> It seems like a bug in Xcode to me. Perhaps it's fixed in newer XC, which
> is why we're not seeing it?
>
> It may be worth filing a radar either way.
>
>

As an additional note, just spun up a new mac1.metal instance with macOS
10.15 to see if I could compile ffmpeg with nothing in the system other
than build tools and I am getting an error of

xcrun: error: unable to find utility "metal", not a developer tool or in
PATH

and realized that I can't even run xcodebuild because

xcodebuild --version
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer
directory '/Library/Developer/CommandLineTools' is a command line tools
instance


It might be better to first check if `$metalcc --version` even runs first
before enabling or even checking if metal works
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Ridley Combs]

> On Dec 21, 2021, at 00:04, Christopher Degawa <ccom@randomderp.com> wrote:
> 
> On Mon, Dec 20, 2021 at 7:53 PM Aman Karmani <ffmpeg@tmm1.net <mailto:ffmpeg@tmm1.net>> wrote:
> 
>> 
>> 
>> On Mon, Dec 20, 2021 at 5:48 PM Christopher Degawa <ccom@randomderp.com>
>> wrote:
>> 
>>> 
>>> 
>>> On Mon, Dec 20, 2021 at 7:21 PM Aman Karmani <ffmpeg@tmm1.net> wrote:
>>> 
>>>> 
>>>> 
>>>> On Mon, Dec 20, 2021 at 5:03 PM Helmut K. C. Tessarek <
>>>> tessarek@evermeet.cx> wrote:
>>>> 
>>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>>> Hash: SHA512
>>>>> 
>>>>> On 2021-12-20 19:11, Christopher Degawa wrote:
>>>>>> So I've exported "LIBRARY_PATH" to
>>>>> 
>>>>> I'm sorry to say, this is a workaround but hardly a solution.
>>>>> 
>>>> 
>>>> No one said this is the solution. We are just trying to figure out what
>>>> is going on, and this added information is very helpful in that effort.
>>>> 
>>>> 
>>>>> Before these 2 commits all worked perfectly. Now it doesn't. Tweaking
>>>>> the
>>>>> build env is not a solution.
>>>>> Next time someone commits something, are we supposed to tweak it again?
>>>>> Where does it end?
>>>>> 
>>>> 
>>>> I'm not sure what your point is. If you are having trouble with those
>>>> commits, then you can use an older version?
>>>> 
>>>> Or you can compile with `./configure --disable-metal` to disable the new
>>>> feature.
>>>> 
>>>> Obviously the code worked on both my and Ridley's computers. If it
>>>> didn't work, we wouldn't have committed it.
>>>> 
>>>> Once we figure out why some computers are using the wrong metal binary,
>>>> then we can fix it and commit the fix to master as well.
>>>> 
>>> 
>>> 
>>> Digging a bit into xcrun itself, looking at
>>> https://real-world-systems.com/docs/xcrun.1.html, it says
>>> 
>>>> The SDK which will be searched defaults to the most recent available
>>> SDK
>>> 
>>> and
>>> 
>>> xcodebuild -version -sdk | head
>>> iPhoneOS14.3.sdk - iOS 14.3 (iphoneos14.3)
>>> SDKVersion: 14.3
>>> Path:
>>> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.3.sdk
>>> PlatformVersion: 14.3
>>> 
>>> Which I'm guessing might be the reason, but still doesn't really make
>>> logical sense and running
>>> 
>>> xcrun --verbose metal -v
>>> ...
>>> xcrun: note: SDKROOT =
>>> '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk'
>>> ...
>>> xcrun: note: lookup resolved in
>>> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
>>> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
>>> Apple LLVM version 31001.43 (metalfe-31001.43)
>>> Target: air64-apple-darwin19.6.0
>>> Thread model: posix
>>> InstalledDir:
>>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin
>>> 
>>> which also, doesn't make sense.
>>> 
>>> exporting SDKROOT to `macosx` does make it show
>>> 
>>> xcrun: note: SDKROOT =
>>> '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk'
>>> 
>>> xcrun: note: lookup resolved in
>>> '/var/folders/yf/4yc0fdvx7zv1t17w41kxmr0r0000gn/T/xcrun_db' :
>>> '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/metal'
>>> Apple LLVM version 31001.143 (metalfe-31001.143)
>>> Target: air64-apple-darwin19.6.0
>>> Thread model: posix
>>> InstalledDir:
>>> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin
>>> 
>>> so, I'm not sure what conclusion to bring from this.
>>> 
>> 
>> Thanks for digging in and documenting this behavior.
>> 
>> It seems like a bug in Xcode to me. Perhaps it's fixed in newer XC, which
>> is why we're not seeing it?
>> 
>> It may be worth filing a radar either way.
>> 
>> 
> 
> As an additional note, just spun up a new mac1.metal instance with macOS
> 10.15 to see if I could compile ffmpeg with nothing in the system other
> than build tools and I am getting an error of
> 
> xcrun: error: unable to find utility "metal", not a developer tool or in
> PATH
> 
> and realized that I can't even run xcodebuild because
> 
> xcodebuild --version
> xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer
> directory '/Library/Developer/CommandLineTools' is a command line tools
> instance
> 
> 
> It might be better to first check if `$metalcc --version` even runs first
> before enabling or even checking if metal works

Huh, TIL that the metal compiler doesn't exist without Xcode, but the metal framework does! Wacky. Anyway, this patch oughtta fix that (does more or less as you suggested); if this is all fine on your end, I'll go ahead and split this up into a few commits and send them to the list: https://gist.github.com/44e6575fbd4d84c016e63d8ddb1fb52e <https://gist.github.com/44e6575fbd4d84c016e63d8ddb1fb52e>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Christopher Degawa]

On Tue, Dec 21, 2021 at 1:40 AM Ridley Combs <rcombs@rcombs.me> wrote:

> Huh, TIL that the metal compiler doesn't exist without Xcode, but the
> metal framework does! Wacky. Anyway, this patch oughtta fix that (does more
> or less as you suggested); if this is all fine on your end, I'll go ahead
> and split this up into a few commits and send them to the list:
> https://gist.github.com/44e6575fbd4d84c016e63d8ddb1fb52e <
> https://gist.github.com/44e6575fbd4d84c016e63d8ddb1fb52e>
>

That indeed does fix the simple clone configure make triplet and I can now
build without errors and does not break compilation with metal stuff if
Xcode is installed
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".