From: Christopher Degawa <ccom@randomderp.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms
Date: Wed, 19 Oct 2022 19:11:38 -0400
Message-ID: <CABDPGrz4btm_eRUft-zxGgOKWvavpNo7Y0uaqt4CAb6Zh9ERHQ@mail.gmail.com> (raw)
In-Reply-To: <775de53f-d3ba-5dd0-29ee-f97ef68e1a94@gmail.com>
On Wed, Oct 19, 2022 at 7:00 PM James Almer <jamrial@gmail.com> wrote:
> On 10/19/2022 7:47 PM, Christopher Degawa wrote:
> > From: Christopher Degawa <christopher.degawa@intel.com>
> > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> > index 28da206cf8..74dad9892b 100644
> > --- a/libavcodec/libsvtav1.c
> > +++ b/libavcodec/libsvtav1.c
> > @@ -179,7 +179,7 @@ static int
> config_enc_params(EbSvtAv1EncConfiguration *param,
> > param->min_qp_allowed = avctx->qmin;
> > }
> > param->max_bit_rate = avctx->rc_max_rate;
> > - param->vbv_bufsize = avctx->rc_buffer_size;
> > + param->maximum_buffer_size_ms = avctx->rc_buffer_size * 1000 /
> avctx->bit_rate;
>
> 1000LL. The multiplication could overflow otherwise.
>
Thanks, replaced locally.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-19 23:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 22:47 [FFmpeg-devel] [PATCH 1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer Christopher Degawa
2022-10-19 22:47 ` [FFmpeg-devel] [PATCH 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms Christopher Degawa
2022-10-19 22:59 ` James Almer
2022-10-19 23:11 ` Christopher Degawa [this message]
2022-10-21 3:55 ` [FFmpeg-devel] [PATCH v2 1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer Christopher Degawa
2022-10-21 3:55 ` [FFmpeg-devel] [PATCH v2 2/2] avcodec/libsvtav1: replace vbv_bufsize with maximum_buffer_size_ms Christopher Degawa
2022-10-27 15:23 ` [FFmpeg-devel] [PATCH v2 1/2] avcodec/libsvtav1: remove compressed_ten_bit_format and simplify alloc_buffer Christopher Degawa
2022-11-17 23:23 ` Christopher Degawa
2022-11-17 23:29 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABDPGrz4btm_eRUft-zxGgOKWvavpNo7Y0uaqt4CAb6Zh9ERHQ@mail.gmail.com \
--to=ccom@randomderp.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git