From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F2FD9404D8 for ; Tue, 21 Dec 2021 01:32:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C864F68AEF8; Tue, 21 Dec 2021 03:32:15 +0200 (EET) Received: from degawa.com (unknown [174.127.109.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F54A68A5BE for ; Tue, 21 Dec 2021 03:32:09 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomderp.com; s=default; h=Content-Type:Cc:To:Subject:Message-ID:Date: From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ayc6pS7P6OP33Kj63WTIs3UTPfd1l/gXbD8UhLC7Uhs=; b=mzsretCzR4Z/fBpWIeyMZZbrka 1OGKMDb3kTHv0yETDmIOv/by3w5GAqZq9mk7SO0fMmkN2ysmlX2rpF0o0wpy5ljDikX/L68MK8zaW rUbPiT6wo2XNFYahVaw/OR1VyOVVeVqEAP8LKkCxZejj1luGuk2m9CLE24PKwo80WVm2d4Y+kTDjN X+yTu8najWp4G2451jp5trIf7qDrAKjuZTJWzcGaIL/a2JN+xtwoi9XXvCUzFls6kWA5ekvudyjf9 RbSMN9YHX37oRtBYrYvMh0kTFPIms3FKKlTpIaXvStUwJIMZkj4ZivcsL3wG3Tqz9H1T1YrsDBNnH JVQbY0yA==; Received: from mail-ua1-f48.google.com ([209.85.222.48]:43851) by slmp-550-1.slc.westdc.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mzU0e-0003bb-HN for ffmpeg-devel@ffmpeg.org; Mon, 20 Dec 2021 18:32:07 -0700 Received: by mail-ua1-f48.google.com with SMTP id 107so20907259uaj.10 for ; Mon, 20 Dec 2021 17:32:07 -0800 (PST) X-Gm-Message-State: AOAM533s65F7uELR5WYRohKySksqyR4fcpNhcP2QmMF9pcxV3rVBQldF ftbvwdhnCH7zx5+rboq7sYTxmCtKRjZesxIpJsM= X-Google-Smtp-Source: ABdhPJypwedNIqs3Z850JyYShwLapQoXVuVZipNJhSIyCd2gKpKm0QX7vm4p6jEqs/BnW8KN+PfFg24ccngf5pJVDac= X-Received: by 2002:ab0:c10:: with SMTP id a16mr379491uak.51.1640050327171; Mon, 20 Dec 2021 17:32:07 -0800 (PST) MIME-Version: 1.0 References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> <9a5a0645-7743-5f73-2240-d8120a9fa0ec@evermeet.cx> In-Reply-To: From: Christopher Degawa Date: Mon, 20 Dec 2021 19:31:31 -0600 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - slmp-550-1.slc.westdc.net X-AntiAbuse: Original Domain - ffmpeg.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - randomderp.com X-Get-Message-Sender-Via: slmp-550-1.slc.westdc.net: authenticated_id: ccom/from_h X-Authenticated-Sender: slmp-550-1.slc.westdc.net: ccom@randomderp.com X-Source: X-Source-Args: X-Source-Dir: X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Helmut K. C. Tessarek" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Dec 20, 2021 at 7:25 PM Aman Karmani wrote: > On Mon, Dec 20, 2021 at 5:19 PM Christopher Degawa > wrote: > > > On Mon, Dec 20, 2021 at 6:55 PM Aman Karmani wrote: > > > > > On Mon, Dec 20, 2021 at 4:52 PM Helmut K. C. Tessarek < > > > tessarek@evermeet.cx> > > > wrote: > > > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > Hash: SHA512 > > > > > > > > > > > > > > > > On 2021-12-20 19:38, Aman Karmani wrote: > > > > > Could you share the output of `xcrun metal -v` > > > > > > > > $ xcrun metal -v > > > > Apple LLVM version 902.9 (metalfe-902.9.61) > > > > Target: air64-apple-darwin18.7.0 > > > > Thread model: posix > > > > InstalledDir: > > > > > > > > > > > > > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain > > > > /usr/metal/ios/bin > > > > > > > > > > I am able to get the ios binary too, but only when I request is > > explicitly > > > as follows: > > > > > > $ xcrun -sdk $(xcodebuild -sdk iphoneos -version Path) metal -v > > > > > > Apple metal version 31001.325 (metalfe-31001.325) > > > Target: air64-apple-darwin20.6.0 > > > Thread model: posix > > > InstalledDir: > > > > > > > > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/ios/bin > > > > > > > > > > Running `xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal > > libavfilter/metal/vf_yadif_videotoolbox.metal -o > > libavfilter/metal/vf_yadif_videotoolbox.metal.air` does indeed compile > > properly and properly shows macos > > > > Great, thanks for the confirmation! > > > > > > xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal -v > > Apple LLVM version 31001.143 (metalfe-31001.143) > > Target: air64-apple-darwin19.6.0 > > Thread model: posix > > InstalledDir: > > > > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin > > > > and I can indeed have FFmpeg configure and make with `./configure > > --metalcc="xcrun -sdk $(xcodebuild -sdk macosx -version Path) metal"`, > but > > that would sorta ruin the whole idea of being able to simply clone and > > ./configure and make. > > > > Cool, that's also good to hear. > > Does this work for you? > > $ xcrun --sdk macosx metal -v > > If so, then perhaps this patch is enough? > > diff --git a/configure b/configure > index d9d41b2273..c4a59e0e3f 100755 > --- a/configure > +++ b/configure > @@ -3842,8 +3842,8 @@ host_cc_default="gcc" > doxygen_default="doxygen" > install="install" > ln_s_default="ln -s -f" > -metalcc_default="xcrun metal" > -metallib_default="xcrun metallib" > +metalcc_default="xcrun --sdk macosx metal" > +metallib_default="xcrun --sdk macosx metallib" > nm_default="nm -g" > pkg_config_default=pkg-config > ranlib_default="ranlib" > > > xcrun --sdk macosx metal -v Apple LLVM version 31001.143 (metalfe-31001.143) Target: air64-apple-darwin19.6.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/bin That does seem to work indeed make xcrun --sdk macosx metal libavfilter/metal/vf_yadif_videotoolbox.metal -o libavfilter/metal/vf_yadif_videotoolbox.metal.air xcrun --sdk macosx metallib --split-module-without-linking libavfilter/metal/vf_yadif_videotoolbox.metal.air -o libavfilter/metal/vf_yadif_videotoolbox.metallib BIN2C libavfilter/metal/vf_yadif_videotoolbox.metallib.c CC libavfilter/metal/vf_yadif_videotoolbox.metallib.o AR libavfilter/libavfilter.a LD ffmpeg_g _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".