From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 59A4A4045D for ; Tue, 21 Dec 2021 00:12:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87AB768AFF8; Tue, 21 Dec 2021 02:12:29 +0200 (EET) Received: from degawa.com (unknown [174.127.109.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 53F8368AF78 for ; Tue, 21 Dec 2021 02:12:22 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomderp.com; s=default; h=Content-Type:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MLcWywBBQ79G8vurXq9QdawnOyX1qHYVlrzrTtVClDg=; b=i44W5uTBBRIFYsv78nczTBAAJz NFMqG7+2JNwvdGXIlcg35xxhgj5Pgm3vqupZwYMVtgGp5fUxZgZVSOc5gSpYUz4l5NuP4xdz8fAqW v8XBdd46oq0gsv8tWpWk/tTNI4A549srmGn/dr5Pyy8+GkhdUxOOa56SFhk6XAd77q6fFiHv66T9B eczMjXRWElw5ai4w/TZwlhQ7RvwQE9znVwKMDyHOGVzFEBbbDV5QejI08tOYasX15HJKVFC6Go93D fnZN4CMm3soRNoUX5FKT3UXHqFDGTNMhKeGZWPNhnH2wiwY335nLbPr1iOocbtR2KDQIvkOm4dtSC eCe6GmWw==; Received: from mail-vk1-f179.google.com ([209.85.221.179]:44962) by slmp-550-1.slc.westdc.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mzSlQ-0005CH-Np for ffmpeg-devel@ffmpeg.org; Mon, 20 Dec 2021 17:12:20 -0700 Received: by mail-vk1-f179.google.com with SMTP id b77so1736026vka.11 for ; Mon, 20 Dec 2021 16:12:19 -0800 (PST) X-Gm-Message-State: AOAM531Sss06afsbc3lrAgeo3VrdHovegwCMCxSPh4s5xAc31i1gFqDL OrZPJ4hYIb57FVOwgawHL995G+45DuYHbCBvzFg= X-Google-Smtp-Source: ABdhPJxb+nuvEHAkeDb/FMjBqguxrliwjwlVGzHBUnDoB5PB/Xv8fi6wsYRlyuW7e60t3c8cDEEFsOnV/3qGtdLYEZk= X-Received: by 2002:a1f:9f8c:: with SMTP id i134mr231124vke.8.1640045539301; Mon, 20 Dec 2021 16:12:19 -0800 (PST) MIME-Version: 1.0 References: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> In-Reply-To: <5fb60616-5ded-1b3a-255c-14deb44924d9@evermeet.cx> From: Christopher Degawa Date: Mon, 20 Dec 2021 18:11:43 -0600 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - slmp-550-1.slc.westdc.net X-AntiAbuse: Original Domain - ffmpeg.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - randomderp.com X-Get-Message-Sender-Via: slmp-550-1.slc.westdc.net: authenticated_id: ccom/from_h X-Authenticated-Sender: slmp-550-1.slc.westdc.net: ccom@randomderp.com X-Source: X-Source-Args: X-Source-Dir: X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Dec 20, 2021 at 3:31 PM Helmut K. C. Tessarek wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Hello, > > The following 2 commits break the build with a deployment target of 10.9 on > macOS. > > I agree that 10.9 is quite old, but the rest of the code worked perfectly > fine, so were those 2 commits really necessary? > > * 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add > vf_yadif_videotoolbox (Aman Karmani) > * ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities > (Aman Karmani) > > Can you make that code conditional? > To tack on to this, I currently am also experiencing issues with those commits, but am running on 10.15, however, my issue isn't necessarily that the code isn't compiling, but rather it seems it's failing to link with xcrun metal libavfilter/metal/vf_yadif_videotoolbox.metal -o libavfilter/metal/vf_yadif_videotoolbox.metal.air air-lld: error: library not found for -lmetal_rt_osx_air2.2 metal: error: air-lld command failed with exit code 1 (use -v to see invocation) make: *** [libavfilter/metal/vf_yadif_videotoolbox.metal.air] Error 1 currently running a fresh clone of FFmpeg and only ran ./configure and then make. If I run xcrun metal -L/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin libavfilter/metal/vf_yadif_videotoolbox.metal -o libavfilter/metal/vf_yadif_videotoolbox.metal.air then it succeeds, I don't think there's currently a way to export LDFLAGS to metal as the rule for it is a simple `$(METALCC) $< -o $@` So I've exported "LIBRARY_PATH" to "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/metal/macos/lib/clang/31001.143/lib/darwin" in the profile since I can't easily update that on all of my CI configurations. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".