From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 61C684484A for ; Fri, 24 Nov 2023 15:41:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46EFF68CEEF; Fri, 24 Nov 2023 17:41:02 +0200 (EET) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9616368CA18 for ; Fri, 24 Nov 2023 17:40:55 +0200 (EET) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-54b0073d50fso822671a12.2 for ; Fri, 24 Nov 2023 07:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700840454; x=1701445254; darn=ffmpeg.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=UPV2HjpWZnFoXynQu0X7X5TDnzVoMjGG9JIFvEqYSw4=; b=jZdJx9I70b/7PCgawHfIwNkInoxDNggob4PYgZP4Wc63brZ3X6FBwsbOvjC2vwctc6 KtdNvkXnrgFfOzF/NaCMZFWs/cSjWQU5znlGSSWMsjgEFw1pdvRM8H2XML6R1W3NSnZx ttFI8SIUIOzEvDG03hak3JSRnJmp2Qxjx8ZdkdJH39AYO970W6iEtIryHltCmzFtKSX8 DtopRaY6wxajcYYOm6CpnDqELtyV8egWi+DKz8BUZlz41AaB8RGOwEeG0eOik0ik+qGs NI6Srp/icrk9EbAFdnIf69caIA3+oUr6VKx2hWFFaYkA14qFb1o0OOZ6DBgQCOXolY0L 8sAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700840454; x=1701445254; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UPV2HjpWZnFoXynQu0X7X5TDnzVoMjGG9JIFvEqYSw4=; b=OKsXpyjLXxaM5aRVzrLnYNbXBIX2Yq/bj8iMDEXyB5DEnNk/T22zFBvJOhFhYkI4u6 5G1aB037gdOswzSZHAnBNiKwrvu6MwCsf4WTVOrAVHkjVXduYkSzVuPneuL7hUg+2sEN ajzZNlWytTyWM1aub8LOIjUcYLS7N0lcxZdVixIbImJ3INNZtWNMVF1f9G9mmjBtYScX 2WbaRVjoqDYILpxQPo7ON8gxDKhF2AXZ0hdThzE5/7bWDxU73mD5yiav/59DnHdYJCHm DOtN2vDTLBx2jwTshtThieXxNGY8eFRBeG5j+9qtp4icaXrGap5aGg5xwzmNjx6E1Ytj Xvgg== X-Gm-Message-State: AOJu0Yz7iKK0jqQzkO43/zvEEvICds7QoTtGvbRnYS5UIw/Y6eErvtuU UZoeebivikdIOTZJTr+TGGPnSaVWFXigDTkWGu3bPHqRL/A= X-Google-Smtp-Source: AGHT+IHrRRbtwwch8obXDbYyVEDKK/N1wGmiXC5wmooF5QfrsMHsFwyJzSpWEWNuqHWFQ0Jb9xQtstkuWBY4EM7z6Ss= X-Received: by 2002:a17:906:74c2:b0:9e6:da40:50bf with SMTP id z2-20020a17090674c200b009e6da4050bfmr2480509ejl.8.1700840454561; Fri, 24 Nov 2023 07:40:54 -0800 (PST) MIME-Version: 1.0 From: David Bohman Date: Fri, 24 Nov 2023 07:40:43 -0800 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is to fix a build failure on macOS < 10.13. This is a build failure in release 6.1. The issue also exists at the top of the master branch, and the patch applies there. --- libavcodec/videotoolboxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index b0e827d14a..b72eb470fd 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -1172,7 +1172,6 @@ static int vtenc_create_encoder(AVCodecContext *avctx, return AVERROR_EXTERNAL; } } -#endif // Dump the init encoder { @@ -1201,6 +1200,7 @@ static int vtenc_create_encoder(AVCodecContext *avctx, if (encoderID != NULL) CFRelease(encoderID); } +#endif if (avctx->flags & AV_CODEC_FLAG_QSCALE && !vtenc_qscale_enabled()) { av_log(avctx, AV_LOG_ERROR, "Error: -q:v qscale not available for encoder. Use -b:v bitrate instead.\n"); -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".