From: David Bohman <debohman@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.
Date: Sat, 25 Nov 2023 14:13:18 -0800
Message-ID: <CAB9xhmPEVwTdwxopcJbKi6bAaydxGHq0PH60N4wLcz3xz=goZg@mail.gmail.com> (raw)
In-Reply-To: <tencent_EF90B766D467F72A9FD3071C780B8B661A06@qq.com>
On Fri, Nov 24, 2023 at 8:09 PM Zhao Zhili <quinkblack@foxmail.com> wrote:
>
>
>
> > On Nov 25, 2023, at 05:32, David Bohman <debohman@gmail.com> wrote:
> >
> > On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili <quinkblack@foxmail.com> wrote:
> >>
> >>> On Nov 24, 2023, at 23:40, David Bohman <debohman@gmail.com> wrote:
> >>>
> >>> This is to fix a build failure on macOS < 10.13.
> >>>
> >> It looks like kVTCompressionPropertyKey_EncoderID is the root cause of build failure.
> >> I prefer use compat_keys, so it can be build on macOS < 10.13, get the key at runtime
> >> and run on macOS >= 10.13.
> >
> > Correct, kVTCompressionPropertyKey_EncoderID appeared in 10.13,
> > according to the Apple Developer documentation.
> >
> > Are you going to do your own fix?
>
> Could you test the following patch? Thanks.
>
> https://ffmpeg.org/pipermail/ffmpeg-devel/2023-November/317366.html
Looks good.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-11-25 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 15:40 David Bohman
2023-11-24 17:01 ` Zhao Zhili
2023-11-24 21:32 ` David Bohman
2023-11-25 4:08 ` Zhao Zhili
2023-11-25 22:13 ` David Bohman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB9xhmPEVwTdwxopcJbKi6bAaydxGHq0PH60N4wLcz3xz=goZg@mail.gmail.com' \
--to=debohman@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git