From: David Bohman <debohman@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.
Date: Mon, 1 Jan 2024 14:33:02 -0800
Message-ID: <CAB9xhmOK_cSj9E5dQ7m2K9mF-as+Lw_cb1YC3jyeEnzer-nV+A@mail.gmail.com> (raw)
In-Reply-To: <20E628E1-84B6-4EC4-B3D1-B46D29AC34F8@gmail.com>
On Mon, Jan 1, 2024 at 9:26 AM <epirat07@gmail.com> wrote:
>
>
>
> On 1 Jan 2024, at 15:38, David Bohman wrote:
>
> > This is a build failure in the master branch as a result of commit
> > e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c:
> >
> > There is no type AVMediaType prior to macOS 10.13.
> > ---
> > libavdevice/avfoundation.m | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
> > index 6a57163eb7..5fc5cb61c5 100644
> > --- a/libavdevice/avfoundation.m
> > +++ b/libavdevice/avfoundation.m
> > @@ -761,6 +761,10 @@ static int get_audio_config(AVFormatContext *s)
> > return 0;
> > }
> >
> > +#if TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED < 101300
> > +typedef NSString *AVMediaType;
> > +#endif
>
> AFAICT this is lacking the similar check for iOS
>
Correct. I have built and tested it for / on my system, which is
running macOS 10.12.X.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-01 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 14:38 David Bohman
2024-01-01 17:08 ` Michael Niedermayer
2024-01-01 22:23 ` David Bohman
2024-01-01 17:26 ` epirat07
2024-01-01 22:33 ` David Bohman [this message]
2024-01-01 21:47 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB9xhmOK_cSj9E5dQ7m2K9mF-as+Lw_cb1YC3jyeEnzer-nV+A@mail.gmail.com \
--to=debohman@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git