Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Discord Account via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: Daniel Verkamp <daniel@drv.nu>
Cc: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>,
	Discord Account <cordacct2001@gmail.com>
Subject: [FFmpeg-devel] Re: [PATCH] configure: fix static library suffix for MSVC builds
Date: Tue, 25 Nov 2025 16:57:01 +0530
Message-ID: <CAB7CwxuO+oQ=vBv1sGhuiksj9t=YW9Ezc7=j6XxKJ_Ow9T_DQA@mail.gmail.com> (raw)
In-Reply-To: <CAGFXeQLFeFxfF7rXhT3dLnnkbn7iZZKtpJ=S8k1op9vUaUUwDQ@mail.gmail.com>

Yeah, I just checked, it's patched. Additionally, I tested a bash script I
wrote for the configuration, and it produces files with the '.lib'
extension. So, this patch is unnecessary. Thanks for pointing it out and
referencing previous commits. It's just that it was listed in the bug
tracker under 'open' status.

configuration:
./configure \
    --toolchain=msvc \
    --enable-static \
    --disable-shared \
    --disable-programs \
    --disable-doc \
    --disable-swscale \
    --disable-swresample \
    --disable-postproc \
    --disable-avfilter \
    --disable-avdevice \
    --disable-network \
    --disable-autodetect \
    --disable-d3d12va \
    --disable-d3d11va \
    --disable-dxva2 \
    --disable-everything \
    --enable-decoder=rawvideo \
    --prefix=/c/ffmpeg-test-install

buid_test.bat:
@echo off
set FFMPEG=C:\ffmpeg-test-install

cl.exe /I"%FFMPEG%\include" test_ffmpeg.c ^
    /link /LIBPATH:"%FFMPEG%\lib" ^
    avcodec.lib avformat.lib avutil.lib ^
    /OUT:test.exe

if %ERRORLEVEL% EQU 0 (
    echo.
    echo === BUILD SUCCESS ===
    echo Running test...
    test.exe
) else (
    echo.
    echo === BUILD FAILED ===
)

Output:
D:\ffmpeg\temp>.\buid_test.bat
Microsoft (R) C/C++ Optimizing Compiler Version 19.50.35718 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

test_ffmpeg.c
Microsoft (R) Incremental Linker Version 14.50.35718.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:test_ffmpeg.exe
/LIBPATH:C:\ffmpeg-test-install\lib
avcodec.lib
avformat.lib
avutil.lib
/OUT:test.exe
test_ffmpeg.obj

=== BUILD SUCCESS ===
Running test...
FFmpeg avcodec version: 4068196
FFmpeg avformat version: 4064871
FFmpeg avutil version: 3937124



On Tue, Nov 25, 2025 at 11:14 AM Daniel Verkamp <daniel@drv.nu> wrote:

> On Sat, Nov 22, 2025 at 3:51 PM Practice2001 via ffmpeg-devel
> <ffmpeg-devel@ffmpeg.org> wrote:
> > MSVC static builds currently always use ".a" for static library suffixes
> > (e.g. libavcodec.a, libavformat.a). This causes failures when linking
> > with Visual Studio, which expects ".lib" static libraries.
> >
> > This patch adjusts configure so that when --toolchain=msvc is used,
> > LIBSUF is correctly set to ".lib" instead of the Unix default ".a".
> >
> > This fixes linking with MSVC and Visual Studio-based build systems.
> >
> [...]
>
> Hi,
>
> This appears to have been fixed by commit 8eca3fa619a7 ("configure:
> use proper Windows-style static library naming"), and then re-shuffled
> in commit 671e54d7151b ("configure: add -static suffix to internal
> static libs for test programs").
>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 47f9b31439..596d66ce53 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6067,7 +6067,7 @@ case $target_os in
> >      win32|win64)
> >          disable symver
> >          LIBPREF=""
> > -               LIBSUF=".lib"
> > +        LIBSUF=".lib"
>
> Not really important, but I'm curious what happened here - the
> original doesn't match what was in the repository, even before the
> commits above.
>
> Thanks,
> -- Daniel
>
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      reply	other threads:[~2025-11-25 11:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22 23:50 [FFmpeg-devel] " Practice2001 via ffmpeg-devel
2025-11-25  4:51 ` [FFmpeg-devel] " Daniel Verkamp via ffmpeg-devel
2025-11-25 11:27   ` Discord Account via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB7CwxuO+oQ=vBv1sGhuiksj9t=YW9Ezc7=j6XxKJ_Ow9T_DQA@mail.gmail.com' \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=cordacct2001@gmail.com \
    --cc=daniel@drv.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git