From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D338456A0 for ; Fri, 17 Feb 2023 18:55:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0604268BE25; Fri, 17 Feb 2023 20:55:25 +0200 (EET) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC56B6803E3 for ; Fri, 17 Feb 2023 20:55:18 +0200 (EET) Received: by mail-yb1-f173.google.com with SMTP id 63so1694766ybq.6 for ; Fri, 17 Feb 2023 10:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=98WAFlRkaRdeWayWa0rif+Be8jf37TOh0EI4eCxZdfk=; b=p7b/LSCUf8Fa+6+q+3MPYgP8nDzo+bldpmWg68648fs6U0SU2jj/nLgqviERoX+nk9 4O5okXD1sTw87+3bayQE5jYece0k7pyV6BbOIgQ8hdCQUpgmIDyHR9efN+qQAobWTr/W g4VcgwSqWxm1oktt0O06BRqCVx8Tmb881CK1SOcNWyeE9grf9bUperaAQ+ghfPS5Zm2X tQtAh7igDrVfvb5HQubsGSa+t34Eh4ppoEMaHjhKScBaFvzKxIR9ovgp+zhHsUeFmfWB hntu4rCdRIHaIOWXoQ72Do84XzCcC63KcpaC7VT72qCA7WZKO/D8vx+KWe2Lyk1bU9Gz jHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=98WAFlRkaRdeWayWa0rif+Be8jf37TOh0EI4eCxZdfk=; b=wijcUMouqJjcH/kp9oZBTkiiMM9HjcCaOI0+mfQEc0219ayqBzbsjRsGUlrgEgTyn9 u53z9OOZBaDpbSVggif20CvdEN/dikYwciW8G7Z+e5N+HcCmSGc9BJ0jXMwR1F5Szgc5 rQdgxFQEOkoiq2PRrPFGSrrGnyn4TQeCQXjz4ESi33r2Aljmy3tgcXI/+oU1SeV/qjMX 6QKUtSVKuO3i2LkTWseYadHIGGxdajiZjeg26R/z1mi4VmfF/ex0FWTkCkQizBcMHKbk Viia2GDzXmGyKJHLs9F3h2cfzYxmx1Red3yHtu7kuyHy35xt0TA+gRL5n53Tzk3u2ooE bV5A== X-Gm-Message-State: AO0yUKXZ7T5N1x3qQ1GJJ37EUlUxpiHjCI7q7yhSNvetfHKOhOSBFXQQ 3RXXxqkd8f+ofa1s38QSIokqtr1QAy3PGXtQpXW2J/A+Ci8= X-Google-Smtp-Source: AK7set/E1AxpWOucujPPJgo6K6wfb97W/if2v6XdAUlhWH0OEOQq7zNMKnLUO+Q75HjEiGK1kYIYgPRoiydGETnsTdo= X-Received: by 2002:a25:9010:0:b0:995:ccb:1d56 with SMTP id s16-20020a259010000000b009950ccb1d56mr22943ybl.3.1676660116946; Fri, 17 Feb 2023 10:55:16 -0800 (PST) MIME-Version: 1.0 References: <9135ef14-f767-095d-5ea6-40c9df9e0695@noa-archive.com> <167663206793.1179.18261691439793810470@lain.khirnov.net> In-Reply-To: From: Prakash Date: Fri, 17 Feb 2023 10:55:08 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Logging timestamps is a basic functionality any logging framework/infrastructure should support. If I am using ffmpeg as a binary then I would need this functionality built in. Agree that the code in log.c can definitely be simplified but didn't want to make any changes with potential for breaking the log output. -Prakash On Fri, Feb 17, 2023 at 3:50 AM Lynne wrote: > Feb 17, 2023, 12:08 by anton@khirnov.net: > > > Quoting Prakash (2023-02-17 01:16:04) > > > >> Moved the timestamp to the front (before loglevel but after the prefix > if > >> present, so the timestamp has the same color as log line based on log > >> level). Updated the patch and attached again. > >> > >> > >> From 04857a7bf0d4cf24a479e795a55a61ab2e2f618e Mon Sep 17 00:00:00 2001 > >> From: Prakash Duggaraju > >> Date: Thu, 16 Feb 2023 16:06:29 -0800 > >> Subject: [PATCH] libavutil/log: Support for logging timestamps in the > log. > >> Add > >> 'time' flag to the -loglevel option to turn on timestamp logging. > Useful > >> for > >> troubleshooting where time is spent from the log files. > >> > >> Signed-off-by: Prakash Duggaraju > >> --- > >> doc/fftools-common-opts.texi | 4 ++++ > >> fftools/opt_common.c | 6 ++++++ > >> libavutil/log.c | 41 +++++++++++++++++++++++++----------- > >> libavutil/log.h | 8 +++++++ > >> 4 files changed, 47 insertions(+), 12 deletions(-) > >> > > > > I do not like this patch. > > > > The default logging callback should be simple and straightforward, not a > > kitchen sink of all possible functionality. > > > > Callers who need this can and should implement this themselves. > > > > Same, having the class pointer makes it already quite busy. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".