From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3A2C04035A for ; Sun, 23 Jan 2022 00:05:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C19C068AED0; Sun, 23 Jan 2022 02:05:35 +0200 (EET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D4F068AED0 for ; Sun, 23 Jan 2022 02:05:29 +0200 (EET) Received: by mail-pl1-f170.google.com with SMTP id d1so12119342plh.10 for ; Sat, 22 Jan 2022 16:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=CXOiGimjgXfvFPMv4i6bM4wk3BFntQN+wN9XN3c6JDE=; b=b1LET1qUPQjPhQT+9gs0fg+TsyEcoBG89trlDRGHUZaH4ro2czT7bjp5GxzPjLu8Og qb7OZlJphimGqoFFQ1JKzYwzCCCRz9kpNbt1Z2i/nbxZQktHFbIQTGP3Lf2hX4DFNwJ2 6rwJ8SePgwfmw6ltZf+yaSJaE5xVuQvUxuxkx1MAevsLe7PF1+1+WWLzuXaZyqM7Enl4 oZX1wEeMli92Iixvb9nnrIlxN2KJ/x7MwIhYH7+WFob3YWCnl+0ram1T3y+yPAKFPL9t NO2rYsI6BpkMOHDRsvDWI5YSkzD1482hcPHaK3SZlLXB90lnmk6TFsTOBtZwGSvEkv4J Uapw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=CXOiGimjgXfvFPMv4i6bM4wk3BFntQN+wN9XN3c6JDE=; b=yYkAnzw9UlRUnq5QV81dlEzchh4ABAKgNS80YhdG/UXbeXzmqrHKpfvT8oq5Ep9OWt 00Hc0emduJCgylvA7v99k1UtL3lxgVv0t3c7CfuerNg+gNmaARz6kaDcQHb5G/5MFTxA BPoFCqPQUKmubSFAXCJp85WWvzYp1z6vD8SstMaGo6Z/T6XAtJxQZv4VakiZfgHb6da+ VGesblsrssvjalqy68U/czX4eM6cfrVdsxHzYTDDXrfeJVaVSwz4q59nUDupiyc7P1WL MM82BD5XbJqqm0c4+ONOQnEEIBmQs/haPivIav8grSvncdmKNbqQE8NPPM7qRK4krYHz JGsQ== X-Gm-Message-State: AOAM531Q84CMvJhM8jhUJIWL2Y1ac7UbvNSQQD3y0L7G4KDpsa2kP/kO o4HenueZpON6PlKkTVESB/HU2+5tBHB4gcRXGpOAKfzRoxQ= X-Google-Smtp-Source: ABdhPJx1W8b1N7F/WTCJdoakCB+Wlv0Z8fxrnAYosxIrZxQdtne49Wz+sxcEUU1skf3CrUlzpafyUcdFzibrqFcfWe8= X-Received: by 2002:a17:90b:33d0:: with SMTP id lk16mr6955305pjb.45.1642896327182; Sat, 22 Jan 2022 16:05:27 -0800 (PST) MIME-Version: 1.0 References: <755fd91b4ae6c9327668f339acfc67fcdd02c0bd.1631867851.git.pross@xvid.org> <54d14822e998e9f1ac99e919fe223433d3c509e2.1631867851.git.pross@xvid.org> In-Reply-To: <54d14822e998e9f1ac99e919fe223433d3c509e2.1631867851.git.pross@xvid.org> From: Carl Eugen Hoyos Date: Sun, 23 Jan 2022 01:01:58 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/img2dec: add GEM Raster image demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am Fr., 17. Sept. 2021 um 10:39 Uhr schrieb Peter Ross : > +static int gem_probe(const AVProbeData *p) > +{ > + const uint8_t *b = p->buf; > + int ret = 0; > + if ( AV_RB16(b ) >= 1 && AV_RB16(b ) <= 3 && > + AV_RB16(b + 2) >= 8 && AV_RB16(b + 2) <= 779 && > + (AV_RB16(b + 4) > 0 || AV_RB16(b + 4) <= 8) && > + (AV_RB16(b + 6) > 0 || AV_RB16(b + 6) <= 8) && > + AV_RB16(b + 8) && > + AV_RB16(b + 10) && > + AV_RB16(b + 12) && > + AV_RB16(b + 14)) { > + ret = AVPROBE_SCORE_EXTENSION / 4; Without running probetest, this score looks too high to me. (1, 2 or 3 followed by anything not 0 with some restrictions?) Why is the above sufficient? Are there files in the wild without the fourcc's below? > + if (AV_RN32(b + 16) == AV_RN32("STTT") || > + AV_RN32(b + 16) == AV_RN32("TIMG") || > + AV_RN32(b + 16) == AV_RN32("XIMG")) > + ret += 1; Should be EXTENSION + 1 Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".