From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1113C44FA3 for ; Tue, 13 Dec 2022 19:12:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64A6268BE44; Tue, 13 Dec 2022 21:12:43 +0200 (EET) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 415B368BE1F for ; Tue, 13 Dec 2022 21:12:37 +0200 (EET) Received: by mail-ej1-f51.google.com with SMTP id t17so39014827eju.1 for ; Tue, 13 Dec 2022 11:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=68JiGzrPrpvZEZTemXDTupWItz8cI+0UVLtMvTCTw60=; b=USjQsJUU9lDKpTQwveEO92N1YXI+az05YzwNR/3GPl+qrTnezvybUHdiekqcdkSm68 nWex+ANrr0NKWEKgs0GVHGA9+c5sB7zMtbk3uJ2uNCleoBwrCzZsL2FzXuDsjj7tdSqb qX/Tj4WY0qCd3g76YMjQx2wochWWO+PJPToAHrGlbkrqXhOm2DG+y7X6DfSG9yxF3iOD bfT9VsJR2xfdtxjZnyLbVJXhWz5BCTZ4IgoGQwX4qXlqkdegeIIg5HhsELx35GOQ3Q9q vfi1hruQjGjjDYqVlqG9WflGLjWAhj9WZWdpwpsZA7vEqonZ00/wrIFzwSacEoFZvYhy DCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=68JiGzrPrpvZEZTemXDTupWItz8cI+0UVLtMvTCTw60=; b=LDHSwDdQSuEXixpWAHHDUm2papFayXIXnez0V+09DJHMvOUFgz0MVW8PvJbSuH4FLV Hcg2QcUdTM/w1X8IXMra0s/EypsQjQTR8sM4O32JOruSNIAnA+NczBzHzziHMIp7s/63 XKNMztNGG5qiT9XLDExhDsZb4WSm9ZRpHTIMJMf/Eonw1AGSnYcBuLVMfSvtyvBTULf4 r2HxsVfHt1vOdblYUgcEBquqziyTpep7uEFBNTCl0Yx1H2TQwaKfG/EWsxbT/Ivk+xtQ g7GlLWW80ZGeXHRaIiFAvOcqka8AqcPQ72OA+iRR6qMyO4YM7CalgGlSDefXNIUSRssc BNjw== X-Gm-Message-State: ANoB5pkbWVB7hNUCiInvgwEl/KV/iE1Q5UPQ4ptFw+E5oo38Ph/Ow2mb 3spA/G/BMiT0Vr+zikIdwuwXTyO+rpwvdGR6VtSwHa8c X-Google-Smtp-Source: AA0mqf7y7cde1rHLhHXadn5IkSb3SFToVW+dtf8cmplMoryRKIKsPqRkCdj6v3ICe4NGcxfhTzj4m6m8o0xxWTOhVdA= X-Received: by 2002:a17:906:809:b0:7c0:e4b8:7587 with SMTP id e9-20020a170906080900b007c0e4b87587mr16949351ejd.593.1670958756701; Tue, 13 Dec 2022 11:12:36 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Carl Eugen Hoyos Date: Tue, 13 Dec 2022 20:11:14 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am Di., 13. Dez. 2022 um 20:03 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Am Di., 13. Dez. 2022 um 16:02 Uhr schrieb Andreas Rheinhardt > > : > >> > >> Andreas Rheinhardt: > >>> Should fix ticket #9909, fixing a regression since > >>> bfb28b5ce89f3e950214b67ea95b45e3355c2caf. > >>> > >>> Thanks to Carl Eugen Hoyos for analyzing the issue. > >>> > >>> Signed-off-by: Andreas Rheinhardt > >>> --- > >>> This would be my solution. What do you think of it? > >>> > >>> libavcodec/x86/Makefile | 7 +++++-- > >>> 1 file changed, 5 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile > >>> index 4e448623af..41ca864849 100644 > >>> --- a/libavcodec/x86/Makefile > >>> +++ b/libavcodec/x86/Makefile > >>> @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP) += x86/qpeldsp.o \ > >>> X86ASM-OBJS-$(CONFIG_RV34DSP) += x86/rv34dsp.o > >>> X86ASM-OBJS-$(CONFIG_VC1DSP) += x86/vc1dsp_loopfilter.o \ > >>> x86/vc1dsp_mc.o > >>> -X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o \ > >>> - x86/simple_idct.o > >>> +ifdef ARCH_X86_64 > >>> +X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o > >>> +else > >>> +X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct.o > >>> +endif > >>> X86ASM-OBJS-$(CONFIG_VIDEODSP) += x86/videodsp.o > >>> X86ASM-OBJS-$(CONFIG_VP3DSP) += x86/vp3dsp.o > >>> X86ASM-OBJS-$(CONFIG_VP8DSP) += x86/vp8dsp.o \ > >> > >> It seems like that there are linkers out there that complain about empty > >> object files like x86/simple_idct.o ("ranlib: file: > >> libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by > >> BBB); the above patch is still needed to fix this. I will therefore > >> apply it tonight (with an updated commit message) unless there are > >> objections. > > > > (Three hours is not a lot) > > > > Which toolchain broke? > > "Broke" is the wrong word; Xcode emits warnings for empty object files. It does. (I did not consider this an issue when I saw it.) I consider this unmaintainable, an argument that in the past was used to object significantly more important patches (in cases where maintenance was imo no problem). Anyway: No objection. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".