From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 70013430DF for ; Sun, 18 Dec 2022 00:46:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 227A068B7F1; Sun, 18 Dec 2022 02:46:06 +0200 (EET) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34DE168096A for ; Sun, 18 Dec 2022 02:45:59 +0200 (EET) Received: by mail-ej1-f45.google.com with SMTP id m18so14151109eji.5 for ; Sat, 17 Dec 2022 16:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=BRceWzhmcJicz6Lt83MkXlNS8MYq8yzj+GUA9N7Oi7A=; b=hMSWrxcvmbWIo3aLt6fQKAu2oAvJ17IH8qn0GnhGU4pFGC+9Qe/a/0162pVkKNlRa7 Gwbu3ikBXerKUAanl9Q92DBIQzpX6NJOSml6ec1FSuXtK+/JrPlEIC9OkjTrO47GeUeD MQFNMnxC7n50pxz06AnCq2oWHPQDh3R0/S1CM6lpx9D0WD9WFaJPzH4Um8u0aMx4zXBL 7Qk32QJo9eaZpH/Wz0v9jLTs9n6JpCVkSKhsXygnLjp+PP0tLBeLflbs0YmVf7EzzWle Y8zTBixyfunWPeS4FHcwcZIAT+NV3rbvKHZUJRItG7wHzhF7c8Sc/UyedQlo0IIKfr1J xU6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRceWzhmcJicz6Lt83MkXlNS8MYq8yzj+GUA9N7Oi7A=; b=HBH4p7Y+o4yRGYCy0sjf0lwhzgISOzK7Ox7AlDviwqxtqlK+AteRb7oX7zieaOt4VD Zmc9cNuha6FVjL0r3x5WCwEZnRm8xp2VVSfcvmPnI29TC5XKEgKTY6eAeT/H/lBveETi AHxy3olggsaAHOwg+voMb0/e1wM/F90OaguyOqw3wgfhNlktzv+1Jc0baNQqd1+CBpe1 rlaz8R9jHoCjHlGmFPITgDCnoeM/J2wIK7lnsd1Lc4nmY8B/1q3mfT5s4p52Qx9ZnkkB m+7piavDWh48uWfSZLL3obOJb0BDBoayIRkAbFJrtX8dy+HTuPxroEe8HIfwTlEbBK+f bPCQ== X-Gm-Message-State: ANoB5plYFDummJCzdDAaIOg22iwpS5TmUX4L+0yEeZg9AJPyUFEzVIZu i2biLk+itmzAmUpvLOVAwrc3tekM7R4lZ5WxeNKvpdkP X-Google-Smtp-Source: AA0mqf4HsT7Ggp+eVMv6pn+jH/qHMpoUJ4bYoZgTPEI3+LTR7+aNFSQOZygerayom4qex5WXLDWnbnwBo3CwEBCdXTk= X-Received: by 2002:a17:907:2949:b0:7c1:4e70:1f96 with SMTP id et9-20020a170907294900b007c14e701f96mr2383066ejc.277.1671324358620; Sat, 17 Dec 2022 16:45:58 -0800 (PST) MIME-Version: 1.0 References: <1f01a2a041ba4e809ec8d9175fde8d8e@huawei.com> In-Reply-To: <1f01a2a041ba4e809ec8d9175fde8d8e@huawei.com> From: Carl Eugen Hoyos Date: Sun, 18 Dec 2022 01:45:47 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -safe to replace the user name and password in the protocol address X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am Sa., 17. Dez. 2022 um 08:36 Uhr schrieb Wujian(Chin) : > > The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. Please add a sentence explaining why this is an issue. > The -safe parameter option is added to replace the user name and password in the command line with the asterisk (*). > > Signed-off-by: wujian_nanjing > --- > doc/ffmpeg.texi | 7 +++++++ > doc/ffplay.texi | 8 ++++++++ > doc/ffprobe.texi | 7 +++++++ > fftools/cmdutils.c | 47 +++++++++++++++++++++++++++++++++++++++++++---- > fftools/cmdutils.h | 15 +++++++++++++++ > fftools/ffmpeg.c | 16 +++++++++++++--- > fftools/ffplay.c | 15 +++++++++++++-- > fftools/ffprobe.c | 18 ++++++++++++++---- > 8 files changed, 120 insertions(+), 13 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index 0367930..e905542 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi > @@ -50,6 +50,13 @@ output files. Also do not mix options which belong to different files. All > options apply ONLY to the next input or output file and are reset between files. > > @itemize > +@item -safe > +The Protocol address may contain the user name and password. The ps -ef command may expose the plaintext. > +The -safe parameter option is added to replace the user name and password in the command line with the asterisk (*). > +@example > +ffmpeg -safe -i rtsp://username@password.xxxx.com I believe this should be example.com Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".