From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DC88042636 for ; Sun, 23 Oct 2022 18:54:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8433B68BC9D; Sun, 23 Oct 2022 21:54:30 +0300 (EEST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA0E8689F20 for ; Sun, 23 Oct 2022 21:54:24 +0300 (EEST) Received: by mail-ed1-f45.google.com with SMTP id m15so23908118edb.13 for ; Sun, 23 Oct 2022 11:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=uyHTp/3Y/FVaEckgq+2ke3bP+szhkqxYvMLExFvfO4c=; b=FuUtK4FCNysJTKU2Y6plaV5XvWvqzzVRWKKhYanDGhmTXeohnTTveZpOHtpdqVDLdP binAFNxW1wXr5EKkTYk9XSOXBbSnDcVFzq6daKQpzadm13F2gc//PQSNwssMLsnAdRWv wEwKlUCP7FOzFTDutPLhbEhek2VLNie09Ks3KzD54kaeoiw/muCf/qyWc3SpKPhrXCBM 613RIEo3+PVPRX1xK/OERONBqiB3GuWkySyAFyg/a55XlM3ximol+X9l/lpBlce966hV vv5xEKeWex6PVpzM9EWhxm/1twipX387SpMNHJ3UaQiWB029iizZUixKsAJOUP8p5tau uwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uyHTp/3Y/FVaEckgq+2ke3bP+szhkqxYvMLExFvfO4c=; b=tecpkFKskm/NQFjgPqpNnULpHYLpGwgCKOOJmCDyVWPsS3XFyxCNaL09Otpt90WJPi c6injiVQ36Q53OSb9D6K6q795dlZPzvy1u88LDz9CoWImJkpmepGQLRzForpv63nYbfD E/7pSVv0NK/La9HCqOSvIEIbfT3qod8PMhbZUO8g3/odOKCbDMQGU2oRlAJcpao6HwUz KJEaQA3fosZOpAl5KeHz9Kc+tI58eUms3hyBeYjyCGwwqEGdzqcIBhGKjFvwPdRY9Aib KlZJCqhWAgqxFKzBsNz3HkcO9200CALzru6EAWLrP4PugOcSZZUnioPKcqoaMjIdQAEi /lTA== X-Gm-Message-State: ACrzQf0nseZM1I9AvFn6zmX82f/1fKjoBWAre4RtDyYFAoaKGrbKnSOG gE14ZmiNMrVjw6xkELpFQTql3BFV6UtI/46m/hvYE7Sg X-Google-Smtp-Source: AMsMyM61Jbl2igKAvdmTjXaj47cdxivgt7QRY3bkp6XjTn84yTD5RdmW8FxSCG9jETcKqa8K81IWy7lx3IhvFkIcX1E= X-Received: by 2002:a17:907:3d8f:b0:78d:b46e:eadd with SMTP id he15-20020a1709073d8f00b0078db46eeaddmr24905559ejc.277.1666551264067; Sun, 23 Oct 2022 11:54:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carl Eugen Hoyos Date: Sun, 23 Oct 2022 20:46:57 +0200 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="00000000000018621505ebb834f8" Subject: Re: [FFmpeg-devel] [RFC]lavc/tiff: Support dng cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000018621505ebb834f8 Content-Type: text/plain; charset="UTF-8" Am So., 23. Okt. 2022 um 16:35 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > I tried to implement dng cropping, it unfortunately can only work with > -flags +unaligned, is there an alternative to simply print a warning > if the flag was not supplied? New patch with more parentheses attached. Please comment, Carl Eugen --00000000000018621505ebb834f8 Content-Type: application/octet-stream; name="0001-lavc-tiff-Support-dng-cropping-needs-flags-unaligned.patch" Content-Disposition: attachment; filename="0001-lavc-tiff-Support-dng-cropping-needs-flags-unaligned.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l9lpbp6j0 RnJvbSAxYmZlMDY1NTY0NjA0NjU5Yjc3MDNlNzViMWJiNzUwYzAzMWZkYzgxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYXJsIEV1Z2VuIEhveW9zIDxjZWZmbXBlZ0BnbWFpbC5jb20+ CkRhdGU6IFN1biwgMjMgT2N0IDIwMjIgMTY6MzE6NTMgKzAyMDAKU3ViamVjdDogW1BBVENIXSBs YXZjL3RpZmY6IFN1cHBvcnQgZG5nIGNyb3BwaW5nLCBuZWVkcyAtZmxhZ3MgK3VuYWxpZ25lZAoK Rml4ZXMgc2FtcGxlcyBtZW50aW9uZWQgaW4gdGlja2V0ICM0MzY0LgotLS0KIGxpYmF2Y29kZWMv dGlmZi5jIHwgODMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKIGxpYmF2Y29kZWMvdGlmZi5oIHwgIDMgKysKIDIgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpYmF2Y29kZWMvdGlmZi5jIGIvbGliYXZjb2RlYy90aWZm LmMKaW5kZXggZmQ5ZGIxOGMwYi4uMzNlZGZmODIxMyAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy90 aWZmLmMKKysrIGIvbGliYXZjb2RlYy90aWZmLmMKQEAgLTE0OTIsNiArMTQ5Miw4OSBAQCBzdGF0 aWMgaW50IHRpZmZfZGVjb2RlX3RhZyhUaWZmQ29udGV4dCAqcywgQVZGcmFtZSAqZnJhbWUpCiAg ICAgY2FzZSBETkdfV0hJVEVfTEVWRUw6CiAgICAgICAgIHMtPndoaXRlX2xldmVsID0gdmFsdWU7 CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgRE5HX0NST1BfT1JJR0lOOgorICAgICAgICBpZiAo Y291bnQgIT0gMiB8fCB0eXBlICE9IFRJRkZfU0hPUlQgJiYgdHlwZSAhPSBUSUZGX0xPTkcgJiYg dHlwZSAhPSBUSUZGX1JBVElPTkFMKSB7CisgICAgICAgICAgICBhdl9sb2cocy0+YXZjdHgsIEFW X0xPR19XQVJOSU5HLCAiSW52YWxpZCBjcm9wIG9yaWdpbiAoY291bnQ6ICVkLCB0eXBlOiAlZClc biIsIGNvdW50LCB0eXBlKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAg IGlmICh0eXBlID09IFRJRkZfUkFUSU9OQUwpIHsKKyAgICAgICAgICAgIHVuc2lnbmVkIGRlbnVt MSwgZGVudW0yOworICAgICAgICAgICAgdmFsdWUgID0gZmZfdGdldCgmcy0+Z2IsIFRJRkZfTE9O Rywgcy0+bGUpOworICAgICAgICAgICAgZGVudW0xID0gZmZfdGdldCgmcy0+Z2IsIFRJRkZfTE9O Rywgcy0+bGUpOworICAgICAgICAgICAgdmFsdWUyID0gZmZfdGdldCgmcy0+Z2IsIFRJRkZfTE9O Rywgcy0+bGUpOworICAgICAgICAgICAgZGVudW0yID0gZmZfdGdldCgmcy0+Z2IsIFRJRkZfTE9O Rywgcy0+bGUpOworICAgICAgICAgICAgaWYgKGRlbnVtMSAhPSAxIHx8IGRlbnVtMiAhPSAxKSB7 CisgICAgICAgICAgICAgICAgYXZfbG9nKHMtPmF2Y3R4LCBBVl9MT0dfV0FSTklORywgIlVuc3Vw cG9ydGVkIGNyb3Agb3JpZ2luXG4iKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHZhbHVlICA9IGZmX3RnZXQoJnMt PmdiLCB0eXBlLCBzLT5sZSk7CisgICAgICAgICAgICB2YWx1ZTIgPSBmZl90Z2V0KCZzLT5nYiwg dHlwZSwgcy0+bGUpOworICAgICAgICB9CisgICAgICAgIGF2X2xvZyhzLT5hdmN0eCwgQVZfTE9H X0RFQlVHLCAiZG5nIGNyb3Agb3JpZ2luOiAlZC8lZFxuIiwgdmFsdWUsIHZhbHVlMik7CisgICAg ICAgIGlmICh2YWx1ZSA+PSBzLT53aWR0aCB8fCB2YWx1ZTIgPj0gcy0+aGVpZ2h0KSB7CisgICAg ICAgICAgICBhdl9sb2cocy0+YXZjdHgsIEFWX0xPR19XQVJOSU5HLCAiSW52YWxpZCBjcm9wIG9y aWdpbiAoJWQvJWQpXG4iLCB2YWx1ZSwgdmFsdWUyKTsKKyAgICAgICAgICAgIGJyZWFrOworICAg ICAgICB9CisgICAgICAgIGlmICgodmFsdWUgfHwgdmFsdWUyKSAmJiAhKHMtPmF2Y3R4LT5mbGFn cyAmIEFWX0NPREVDX0ZMQUdfVU5BTElHTkVEKSkgeworICAgICAgICAgICAgYXZfbG9nKHMtPmF2 Y3R4LCBBVl9MT0dfV0FSTklORywiQ29ycmVjdCBETkcgY3JvcHBpbmcgbmVlZHMgLWZsYWdzICt1 bmFsaWduZWRcbiIpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgZnJhbWUtPmNyb3Bf bGVmdCA9IHZhbHVlOworICAgICAgICAgICAgZnJhbWUtPmNyb3BfdG9wID0gdmFsdWUyOworICAg ICAgICB9CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgRE5HX0NST1BfU0laRToKKyAgICAgICAg aWYgKGNvdW50ICE9IDIgfHwgdHlwZSAhPSBUSUZGX1NIT1JUICYmIHR5cGUgIT0gVElGRl9MT05H ICYmIHR5cGUgIT0gVElGRl9SQVRJT05BTCkgeworICAgICAgICAgICAgYXZfbG9nKHMtPmF2Y3R4 LCBBVl9MT0dfV0FSTklORywgIkludmFsaWQgY3JvcCBzaXplIChjb3VudDogJWQsIHR5cGU6ICVk KVxuIiwgY291bnQsIHR5cGUpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICAg ICAgaWYgKHR5cGUgPT0gVElGRl9SQVRJT05BTCkgeworICAgICAgICAgICAgdW5zaWduZWQgZGVu dW0xLCBkZW51bTI7CisgICAgICAgICAgICB2YWx1ZSAgPSBmZl90Z2V0KCZzLT5nYiwgVElGRl9M T05HLCBzLT5sZSk7CisgICAgICAgICAgICBkZW51bTEgPSBmZl90Z2V0KCZzLT5nYiwgVElGRl9M T05HLCBzLT5sZSk7CisgICAgICAgICAgICB2YWx1ZTIgPSBmZl90Z2V0KCZzLT5nYiwgVElGRl9M T05HLCBzLT5sZSk7CisgICAgICAgICAgICBkZW51bTIgPSBmZl90Z2V0KCZzLT5nYiwgVElGRl9M T05HLCBzLT5sZSk7CisgICAgICAgICAgICBpZiAoZGVudW0xICE9IDEgfHwgZGVudW0yICE9IDEp IHsKKyAgICAgICAgICAgICAgICBhdl9sb2cocy0+YXZjdHgsIEFWX0xPR19XQVJOSU5HLCAiVW5z dXBwb3J0ZWQgY3JvcCBzaXplXG4iKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHZhbHVlICA9IGZmX3RnZXQoJnMt PmdiLCB0eXBlLCBzLT5sZSk7CisgICAgICAgICAgICB2YWx1ZTIgPSBmZl90Z2V0KCZzLT5nYiwg dHlwZSwgcy0+bGUpOworICAgICAgICB9CisgICAgICAgIGF2X2xvZyhzLT5hdmN0eCwgQVZfTE9H X0RFQlVHLCAiZG5nIGNyb3Agc2l6ZSAlZCB4ICVkXG4iLCB2YWx1ZSwgdmFsdWUyKTsKKyAgICAg ICAgaWYgKHZhbHVlICsgZnJhbWUtPmNyb3BfbGVmdCA+PSBzLT53aWR0aCB8fCB2YWx1ZTIgKyBm cmFtZS0+Y3JvcF90b3AgPj0gcy0+aGVpZ2h0KSB7CisgICAgICAgICAgICBhdl9sb2cocy0+YXZj dHgsIEFWX0xPR19XQVJOSU5HLCAiSW52YWxpZCBjcm9wIHNpemUgKCVkIHggJWQpXG4iLCB2YWx1 ZSwgdmFsdWUyKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAgIGZyYW1l LT5jcm9wX3JpZ2h0ID0gcy0+d2lkdGggLSBmcmFtZS0+Y3JvcF9sZWZ0IC0gdmFsdWU7CisgICAg ICAgIGZyYW1lLT5jcm9wX2JvdHRvbSA9IHMtPmhlaWdodCAtIGZyYW1lLT5jcm9wX3RvcCAtIHZh bHVlMjsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBETkdfQUNUSVZFX0FSRUE6IHsKKyAgICAg ICAgdW5zaWduZWQgdG9wLCBsZWZ0LCBib3R0b20sIHJpZ2h0OworICAgICAgICBpZiAoY291bnQg IT0gNCB8fCB0eXBlICE9IFRJRkZfU0hPUlQgJiYgdHlwZSAhPSBUSUZGX0xPTkcpIHsKKyAgICAg ICAgICAgIGF2X2xvZyhzLT5hdmN0eCwgQVZfTE9HX1dBUk5JTkcsICJJbnZhbGlkIEFjdGl2ZSBB cmVhIChjb3VudDogJWQsIHR5cGU6ICVkKVxuIiwgY291bnQsIHR5cGUpOworICAgICAgICAgICAg YnJlYWs7CisgICAgICAgIH0KKyAgICAgICAgdG9wICAgID0gZmZfdGdldCgmcy0+Z2IsIHR5cGUs IHMtPmxlKTsKKyAgICAgICAgbGVmdCAgID0gZmZfdGdldCgmcy0+Z2IsIHR5cGUsIHMtPmxlKTsK KyAgICAgICAgYm90dG9tID0gZmZfdGdldCgmcy0+Z2IsIHR5cGUsIHMtPmxlKTsKKyAgICAgICAg cmlnaHQgID0gZmZfdGdldCgmcy0+Z2IsIHR5cGUsIHMtPmxlKTsKKyAgICAgICAgaWYgKHRvcCAr IGZyYW1lLT5jcm9wX3RvcCA+PSBzLT5oZWlnaHQgfHwgdG9wID4gZnJhbWUtPmNyb3BfYm90dG9t IHx8IGxlZnQgKyBmcmFtZS0+Y3JvcF9sZWZ0ID49IHMtPndpZHRoIHx8IGxlZnQgPiBmcmFtZS0+ Y3JvcF9yaWdodCkgeworICAgICAgICAgICAgYXZfbG9nKHMtPmF2Y3R4LCBBVl9MT0dfV0FSTklO RywgIkludmFsaWQgQWN0aXZlIEFyZWEgKCVkLyVkLyVkLyVkKVxuIiwgdG9wLCBsZWZ0LCBib3R0 b20sIHJpZ2h0KTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgICAgIGF2X2xv ZyhzLT5hdmN0eCwgQVZfTE9HX0RFQlVHLCAiZG5nIGFjdGl2ZSBhcmVhICVkLyVkLyVkLyVkXG4i LCB0b3AsIGxlZnQsIGJvdHRvbSwgcmlnaHQpOworICAgICAgICBpZiAoKHRvcCB8fCBsZWZ0KSAm JiAhKHMtPmF2Y3R4LT5mbGFncyAmIEFWX0NPREVDX0ZMQUdfVU5BTElHTkVEKSkgeworICAgICAg ICAgICAgYXZfbG9nKHMtPmF2Y3R4LCBBVl9MT0dfV0FSTklORywiQ29ycmVjdCBETkcgY3JvcHBp bmcgbmVlZHMgLWZsYWdzICt1bmFsaWduZWRcbiIpOworICAgICAgICB9IGVsc2UgeworICAgICAg ICAgICAgZnJhbWUtPmNyb3BfdG9wICs9IHRvcDsKKyAgICAgICAgICAgIGZyYW1lLT5jcm9wX2Jv dHRvbSAtPSB0b3A7CisgICAgICAgICAgICBmcmFtZS0+Y3JvcF9sZWZ0ICs9IGxlZnQ7CisgICAg ICAgICAgICBmcmFtZS0+Y3JvcF9yaWdodCAtPSBsZWZ0OworICAgICAgICB9CisgICAgICAgIGJy ZWFrOworICAgIH0KICAgICBjYXNlIFRJRkZfQ0ZBX1BBVFRFUk5fRElNOgogICAgICAgICBpZiAo Y291bnQgIT0gMiB8fCAoZmZfdGdldCgmcy0+Z2IsIHR5cGUsIHMtPmxlKSAhPSAyICYmCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICBmZl90Z2V0KCZzLT5nYiwgdHlwZSwgcy0+bGUpICE9IDIp KSB7CmRpZmYgLS1naXQgYS9saWJhdmNvZGVjL3RpZmYuaCBiL2xpYmF2Y29kZWMvdGlmZi5oCmlu ZGV4IGU2N2M1OWFiYWQuLjk0YTkxNDEyZTUgMTAwNjQ0Ci0tLSBhL2xpYmF2Y29kZWMvdGlmZi5o CisrKyBiL2xpYmF2Y29kZWMvdGlmZi5oCkBAIC0xMDYsNiArMTA2LDggQEAgZW51bSBEbmdUYWdz IHsKICAgICBETkdfTElORUFSSVpBVElPTl9UQUJMRSA9IDB4QzYxOCwKICAgICBETkdfQkxBQ0tf TEVWRUwgICAgICAgICA9IDB4QzYxQSwKICAgICBETkdfV0hJVEVfTEVWRUwgICAgICAgICA9IDB4 QzYxRCwKKyAgICBETkdfQ1JPUF9PUklHSU4gICAgICAgICA9IDB4QzYxRiwKKyAgICBETkdfQ1JP UF9TSVpFICAgICAgICAgICA9IDB4QzYyMCwKICAgICBETkdfQ09MT1JfTUFUUklYMSAgICAgICA9 IDB4QzYyMSwKICAgICBETkdfQ09MT1JfTUFUUklYMiAgICAgICA9IDB4QzYyMiwKICAgICBETkdf Q0FNRVJBX0NBTElCUkFUSU9OMSA9IDB4QzYyMywKQEAgLTExMyw2ICsxMTUsNyBAQCBlbnVtIERu Z1RhZ3MgewogICAgIEROR19BTkFMT0dfQkFMQU5DRSAgICAgID0gMHhDNjI3LAogICAgIEROR19B U19TSE9UX05FVVRSQUwgICAgID0gMHhDNjI4LAogICAgIEROR19BU19TSE9UX1dISVRFX1hZICAg ID0gMHhDNjI5LAorICAgIEROR19BQ1RJVkVfQVJFQSAgICAgICAgID0gMHhDNjhELAogfTsKIAog LyoqIGxpc3Qgb2YgQ2luZW1hRE5HIHRhZ3MgKi8KLS0gCjIuMTcuMQoK --00000000000018621505ebb834f8 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000018621505ebb834f8--