From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E02840E3F for ; Sat, 8 Oct 2022 23:37:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6190E68BC48; Sun, 9 Oct 2022 02:37:37 +0300 (EEST) Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3EB3A68B263 for ; Sun, 9 Oct 2022 02:37:31 +0300 (EEST) Received: by mail-oo1-f51.google.com with SMTP id u19-20020a4a9e93000000b004757198549cso5890725ook.0 for ; Sat, 08 Oct 2022 16:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=SlzOUYnap3TgkslGEqZUYR33SrYV+NLdbG+ZqpzZ5/M=; b=ArO5Cy9Hz6FMf+P2uM1+Ibj7CrRtZK0u10T5LZSmrE+nXml1w118ez9ZoZWixLxCsY ehiD7lKGfrYjrM/yGHjST5iUvnmDXrMsvNufY/4N3xgVXf+u1SPxFyuBYg4femBxwCOJ 0qoqRdY/xWdhDZxzDMDJoK3LtH12gE+zepT0KjOdTBVXs1sErpKniU0sndhRbqW3KlNi TD9T9i8ycLO6k29b3AyebD3HmY+QFTrbB8BYCZzGNqNZ/hBoMQryTTdKl1Vpa/R+vYyW j6YwHOgnn3DylkyKD50rNanQ28KtZcZaQCP/PjMApnaesUjO7woNRXiljTf7BWCU69em RkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SlzOUYnap3TgkslGEqZUYR33SrYV+NLdbG+ZqpzZ5/M=; b=LGa8rYU+3iUbwgCgkkvsOhRZWTCOCqkqOlb3D6xP7kfNOSDs+125mYxUTDDkCUY9mi LJPyccvuK7cIXHNan5TZCGNX5iwjKzgAV0tNJOfPUESCMZMusSVBNrYaTFLTXHdzgg0V BAow3HEanbe9c9CJ0/ravB75jeCPUetMUWobNB/Y24/1/q/jQoRuWkrAGeiRGtVt8S9B S6i4KKu+Hysjs/6a0jmIKRyW6FT++/BdmI0p5OnHjaUHCisRH9FfNwHYFk8iLwEH063m cptn3+afz003mrgZQWvm6Dn0kjX3qvtH0rXzvOm+SsjGzgRrTo1f2aeba6rR45YK9Yz9 zSVQ== X-Gm-Message-State: ACrzQf0R/HODkVEeaTLf+OtoIgm+gm8jchkIES5U5bTK3zU32g2nr4h3 Va47ujCgSOjvLZIrGSsZ8j7jqrDWv2B70Owo8Oxszloo X-Google-Smtp-Source: AMsMyM5CrgKTMxyczGXYUfWlNoCnlCa7JNd7nZR083XGly/jGb+F4yAhsI5FuRpUK38SDwGJ8asH8Kr973h0LCQAqf4= X-Received: by 2002:a9d:6958:0:b0:655:bd99:616b with SMTP id p24-20020a9d6958000000b00655bd99616bmr4970026oto.63.1665272248894; Sat, 08 Oct 2022 16:37:28 -0700 (PDT) MIME-Version: 1.0 References: <20221002234755.3354-1-dev@rocha.red> <20221002234755.3354-2-dev@rocha.red> In-Reply-To: From: Carl Eugen Hoyos Date: Sun, 9 Oct 2022 01:30:16 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am Sa., 8. Okt. 2022 um 10:39 Uhr schrieb Julio C. Rocha : > > On Sun, Oct 2, 2022 at 4:48 PM Julio C. Rocha wrote: > > > --- > > configure | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 6712d045d9..f5f5eb29dd 100755 > > --- a/configure > > +++ b/configure > > @@ -4847,7 +4847,12 @@ probe_cc(){ > > else > > _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d '\r') > > fi > > - _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | > > awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > + if [ "$(grep -i Microsoft /proc/version)" ]; then > > + # Windows Subsystem for Linux > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 > > | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > (!match($$0, / /)) { cmd="/usr/bin/wslpath \x27" $$0 "\x27"; cmd |& getline > > pth; print "$@:", pth } }'\'' > $(@:.o=.d)' > > + else > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 > > | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if > > (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > + fi > > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs' > > _cflags_speed="-O2" > > _cflags_size="-O1" > > -- > > 2.37.0 (Apple Git-136) > > > > > Hi! I'd like to re-request feedback for this patch. > > To clarify, it allows building FFmpeg using MSVC over WSL, without any > dependency on MinGW or MSYS. You write in your own explanations "Succeeds" - this and what the patch is meant to fix are missing from your commit message. Your patch would not work here - sadly, cl.exe does not print "including" for all installations. I build FFmpeg regularly with wsl and msvc and others do as well. Dependency files are simply empty here (because cl.exe prints "Einlesen der Datei" here). Dependency generation works for me with --dep-cc=clang-cl.exe but I normally just build without it. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".