From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 20D8644FA3 for ; Tue, 13 Dec 2022 18:55:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C011268BD06; Tue, 13 Dec 2022 20:55:55 +0200 (EET) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E81D268A8D9 for ; Tue, 13 Dec 2022 20:55:49 +0200 (EET) Received: by mail-ej1-f44.google.com with SMTP id x22so38842371ejs.11 for ; Tue, 13 Dec 2022 10:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=iDsNkioezQPh4JeAg1JkMVL28V1mr8HzKncMGsOCajY=; b=DB3Jpx0tSZx2Gwq2nER5K958/zUekAykE3FYyZO3uOD+KXeHfdKZU5aG+HWpualacN CYafdoN1/RaiNrZdnDbTLW7jN3EaBJTKdPtDmKukfQ/6o9imLVj8fNGTRxv136oWHqQ6 1zz0cRstupxaq+WqdzGHqj4bHGYFU4+Q1uFThCQ/zP3O6foDuyaj8H8GlIhbLcXy0mcO 3RsxedAEm5jUbeaD23GlLp5df9sCWA1qgQyG1PZBULpxgF2gxKLqXOOimaioDupwyztg 4g7FhROWasxfKvpV+vR0iTiF2rFPRC5z9gE9AMFWQva1pVsL122g33BG5P8/kq+KJdqS dVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iDsNkioezQPh4JeAg1JkMVL28V1mr8HzKncMGsOCajY=; b=CjC5s4gTKhEl35HQaPzpBPEU33bZG6qIHLHOi+2RX2Ac08guVP9CZ9vJ76oX+e6RoV c7W7rAmspZ+b2TU0ZP3SkSaNaUNFINvZfDUDHSARXksK3HXNq681YcYtRe9FF/N6lwhB lRGamqFWhp5Vq0VmPM1tgNDeO2CCUqzoQJ/wdGOLxzbeRsv+eSjGQVm1WCe+iSbPDp/g 0ysv99Uv/Q/uPGFbhdBm9o7Rfpf74ZEt0UiNmBtq+dcbUmlIYPKXkdGMFxuadQf8Srh2 TQHx9rsLfWndsxigDuZlb0AXVRbl8YAXZQsLIZ5o1b/JXi7lDA/aY0qmwKxTYNcpRKJi B7Qw== X-Gm-Message-State: ANoB5plCuv3zDeEzvo27GcMqqa+/bOZSGzuksIAhmTCDnq2I7oheX0vQ Bb8RoSMRVauzZWhmY0XHa/6Sh17+u35vyBLxQJe0vCTg X-Google-Smtp-Source: AA0mqf6I09+MWyzRu3vuRWCTNxrPfnCv7Ztm6+zt3pqRknTX0MPGCShpkUiKCS5M5q0LYYZ496MVm9g0R5V227P2hmc= X-Received: by 2002:a17:907:2949:b0:7c1:4e70:1f96 with SMTP id et9-20020a170907294900b007c14e701f96mr1066693ejc.277.1670957749092; Tue, 13 Dec 2022 10:55:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Carl Eugen Hoyos Date: Tue, 13 Dec 2022 19:54:27 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am Di., 13. Dez. 2022 um 16:02 Uhr schrieb Andreas Rheinhardt : > > Andreas Rheinhardt: > > Should fix ticket #9909, fixing a regression since > > bfb28b5ce89f3e950214b67ea95b45e3355c2caf. > > > > Thanks to Carl Eugen Hoyos for analyzing the issue. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > This would be my solution. What do you think of it? > > > > libavcodec/x86/Makefile | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile > > index 4e448623af..41ca864849 100644 > > --- a/libavcodec/x86/Makefile > > +++ b/libavcodec/x86/Makefile > > @@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP) += x86/qpeldsp.o \ > > X86ASM-OBJS-$(CONFIG_RV34DSP) += x86/rv34dsp.o > > X86ASM-OBJS-$(CONFIG_VC1DSP) += x86/vc1dsp_loopfilter.o \ > > x86/vc1dsp_mc.o > > -X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o \ > > - x86/simple_idct.o > > +ifdef ARCH_X86_64 > > +X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o > > +else > > +X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct.o > > +endif > > X86ASM-OBJS-$(CONFIG_VIDEODSP) += x86/videodsp.o > > X86ASM-OBJS-$(CONFIG_VP3DSP) += x86/vp3dsp.o > > X86ASM-OBJS-$(CONFIG_VP8DSP) += x86/vp8dsp.o \ > > It seems like that there are linkers out there that complain about empty > object files like x86/simple_idct.o ("ranlib: file: > libavcodec/libavcodec.a(simple_idct.o) has no symbols" as reported by > BBB); the above patch is still needed to fix this. I will therefore > apply it tonight (with an updated commit message) unless there are > objections. (Three hours is not a lot) Which toolchain broke? Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".