From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 584664C41D for ; Fri, 7 Feb 2025 03:59:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9151F68BA00; Fri, 7 Feb 2025 05:58:59 +0200 (EET) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6059668B6FC for ; Fri, 7 Feb 2025 05:58:52 +0200 (EET) Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-544104cd8e7so203602e87.2 for ; Thu, 06 Feb 2025 19:58:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxyid.net; s=google; t=1738900731; x=1739505531; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0Rogj5KP3+oK1BfHCra8Wyr3mSxMUJOMPxa93GzGUaU=; b=QNv+Ki/4r4a5F+DU5Qy48tjZaZ8ZDNrisAxusEevqOJdYtXFrXg1iE3h4dKL1yiITK keaFe0FiIiWResNmifY7RUzom2f0cPm7DF92zNkDg+bpTASDpn7monLBubuC+JS3Ydev /DKHm5yhOd16grIeR/2fDPjC96PojMmU9I0VxJe2+vGH8oezWVZoWNKC9bQJwJCF8RBk cNoof6LEMD0tRiIgL0XeeK5O1nGpNj05Qsc5TptGbyQaVYJ6sIleh5fsL+gNjOe5nokR cMTq2MZHvX6l57spcubMyIZugjciTc3I9QX2dnEnY7lAgn7fnpwonF3BlGI406Y2C10Q MsYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738900731; x=1739505531; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Rogj5KP3+oK1BfHCra8Wyr3mSxMUJOMPxa93GzGUaU=; b=srwo1/8m2IfeMghRabnieVsy+jrFaUTwfeeL4QsESECSEOkydkVr23O1QpQAM2Nn56 7c2gEw9MqiErxqvMWUnnUzWdxDdWfmQJOzPybRwmNu4oLIrVmwkzMgG1U+qIJX9wO32e aEcYl/KAiBZgk+/ruCydyIaoyMus6LqOUKTHOBMOPXlFsW9PuZsNTDMHMmYqnFBlHIJa MjR+FbPz03oNgQZTXMpuSuCdgmB1kJDHzk+DsYPQ8ME7f8GKtSJLw1rFxpGx48Hbpc1I 0CxILnMZQag3ONCeLdIn7SxyrIvpOb+J4qG4hC4v2WrHqFWiJ1SjUnbe7BD2nYi+we7n Zfww== X-Gm-Message-State: AOJu0Yy03CgyGzPMwxRvjX9tfFfbqoNqT9mG/lVfNIgw69r3wYIZIvmt Krpi+bHs92p6kIHWbJK83pk9Pa0kytxx7xj2DOr80WcUR5jrwMWdH51YPvA5+2a3yGePEKUUHf7 lp7ak6XScG75iUXj3FViSyzQitCy7bGQ9bmylrGjVypzxwMMewmM1nA== X-Gm-Gg: ASbGncvxB3Wi8DpolG9zPhvIkCz4VtBZERqM3MYXUfXDk1evv1Guc6cRTm/JTnwpWK3 H8drS4bIVGAbhwqhzOuMpBjkVIUoVY1ECoFzQEaCZFk0zApwTydaybOHWdVSC/s8uh3D9pVW5 X-Google-Smtp-Source: AGHT+IFrSDcquChZMxglkRZit+FADcx+6F9LBXkTx5DtyPHUJhmz8iQyNf5x1znoNyhIGHy1s9den3P7QGw27Bij4fo= X-Received: by 2002:a2e:be21:0:b0:302:289f:3c5f with SMTP id 38308e7fff4ca-307e5b8d69amr1157291fa.8.1738900730749; Thu, 06 Feb 2025 19:58:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marth64 Date: Thu, 6 Feb 2025 21:58:14 -0600 X-Gm-Features: AWEUYZmFKiDgxE7khXTnTqYpJWnhNQ4lQcoJ1FeUY9Cw8tXFMPppVV3VKTSCytA Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer , softworkz , Soft Works Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: It works good. First pass thoughts: 1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case convention and conveys clearly that the parameter is an `AVBPrint` 2- Option switch: +datetime and +time feels lighter/easier (vs. -ing) 3- Term color: the space after the time keeps the background of the time, which looks odd IMO with terminal emulator color schemes that show the background. Not sure if this is intentional. Let me know if you need a screenshot. 4- (Optional): how would you feel about RFC3339 representation? If machine parsing is a goal for this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".