From: Marth64 <marth64@proxyid.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Michael Niedermayer <michael@niedermayer.cc>,
softworkz <softworkz@hotmail.com>,
Soft Works <softworkz-at-hotmail.com@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing
Date: Thu, 6 Feb 2025 21:58:14 -0600
Message-ID: <CAAhd_PW4DpuEdwDfyjab_Vczw1MXpphPEgLs9K0amhXt0df8UQ@mail.gmail.com> (raw)
In-Reply-To: <pull.37.v3.ffstaging.FFmpeg.1738891595.ffmpegagent@gmail.com>
It works good. First pass thoughts:
1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case
convention and conveys clearly that the parameter is an `AVBPrint`
2- Option switch: +datetime and +time feels lighter/easier (vs. -ing)
3- Term color: the space after the time keeps the background of the
time, which looks odd IMO with terminal emulator color schemes that
show the background.
Not sure if this is intentional. Let me know if you need a screenshot.
4- (Optional): how would you feel about RFC3339 representation? If
machine parsing is a goal for this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-02-07 3:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 19:37 [FFmpeg-devel] [PATCH " ffmpegagent
2022-08-24 19:37 ` [FFmpeg-devel] [PATCH 1/3] avutil/log: support logging of date and timing information softworkz
2022-08-24 19:37 ` [FFmpeg-devel] [PATCH 2/3] fftools/opt_common: add timing and datetiming log flags softworkz
2022-08-24 19:37 ` [FFmpeg-devel] [PATCH 3/3] doc/fftools-common-opts: document log timing flags softworkz
2022-12-12 23:10 ` [FFmpeg-devel] [PATCH 0/3] Add option to log timing Soft Works
2025-01-30 3:53 ` [FFmpeg-devel] [PATCH v2 " ffmpegagent
2025-01-30 3:53 ` [FFmpeg-devel] [PATCH v2 1/3] avutil/log: support logging of date and timing information softworkz
2025-01-30 3:53 ` [FFmpeg-devel] [PATCH v2 2/3] fftools/opt_common: add timing and datetiming log flags softworkz
2025-02-02 1:13 ` Michael Niedermayer
2025-02-02 1:38 ` Soft Works
2025-01-30 3:53 ` [FFmpeg-devel] [PATCH v2 3/3] doc/fftools-common-opts: document log timing flags softworkz
2025-02-07 1:26 ` [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing ffmpegagent
2025-02-07 1:26 ` [FFmpeg-devel] [PATCH v3 1/3] avutil/log: support logging of date and timing information softworkz
2025-02-07 1:26 ` [FFmpeg-devel] [PATCH v3 2/3] fftools/opt_common: add timing and datetiming log flags softworkz
2025-02-07 1:26 ` [FFmpeg-devel] [PATCH v3 3/3] doc/fftools-common-opts: document log timing flags softworkz
2025-02-07 3:58 ` Marth64 [this message]
2025-02-07 4:37 ` [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing Soft Works
2025-02-07 4:47 ` Marth64
2025-02-07 4:53 ` Marth64
2025-02-07 5:05 ` Soft Works
2025-02-07 5:15 ` Marth64
2025-02-07 6:27 ` [FFmpeg-devel] [PATCH v4 " ffmpegagent
2025-02-07 6:27 ` [FFmpeg-devel] [PATCH v4 1/3] avutil/log: support logging of date and timing information softworkz
2025-02-07 6:27 ` [FFmpeg-devel] [PATCH v4 2/3] fftools/opt_common: add timing and datetiming log flags softworkz
2025-02-07 6:46 ` epirat07
2025-02-07 6:54 ` Soft Works
2025-02-07 6:27 ` [FFmpeg-devel] [PATCH v4 3/3] doc/fftools-common-opts: document log timing flags softworkz
2025-02-07 7:57 ` [FFmpeg-devel] [PATCH v5 0/3] Add option to log timing ffmpegagent
2025-02-07 7:57 ` [FFmpeg-devel] [PATCH v5 1/3] avutil/log: support logging of date and time information softworkz
2025-02-07 7:57 ` [FFmpeg-devel] [PATCH v5 2/3] fftools/opt_common: add time and datetime log flags softworkz
2025-02-07 10:42 ` Tobias Rapp
2025-02-07 11:27 ` Soft Works
2025-02-07 7:57 ` [FFmpeg-devel] [PATCH v5 3/3] doc/fftools-common-opts: document log timing flags softworkz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhd_PW4DpuEdwDfyjab_Vczw1MXpphPEgLs9K0amhXt0df8UQ@mail.gmail.com \
--to=marth64@proxyid.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=michael@niedermayer.cc \
--cc=softworkz-at-hotmail.com@ffmpeg.org \
--cc=softworkz@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git