Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Yalda via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Yalda <marth64@proxyid.net>
Subject: [FFmpeg-devel] Re: [GSoC 2026] Qualification Task – SubViewer Decoder Patch
Date: Mon, 26 Jan 2026 12:39:35 -0600
Message-ID: <CAAhd_PVCGmXSOB3P43rAF0cXE73n14s0URzjBktLLr5L0zbCKw@mail.gmail.com> (raw)
In-Reply-To: <CACt+UE4_TsjHEjWR2RHjxr+CNqSUv0hNJtW6jwWO9uvfWVd5Ug@mail.gmail.com>

Hi Nariman,

Thank you for your contribution. Please note that the contribution
process is transitioning to Forgejo (https://code.ffmpeg.org) and
would pivot any future patches there.
With regards to this specific patch can you give some context as to
why you think it is needed? Is there a known fault or trigger? Also
return line needs indentation.
I do not see other subtitle decoders doing this check, and am leaning
toward trusting the API that decode() should not be called as such.

See callee here in the doxygen (and if you follow into the function in
decode.c you can see that avctx is already used)
https://ffmpeg.org/doxygen/trunk/group__lavc__decoding.html#ga5c30b73f0ec105f93d4e86464f541f21
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

  reply	other threads:[~2026-01-26 18:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 14:43 [FFmpeg-devel] " Nariman Sayed via ffmpeg-devel
2026-01-26 18:39 ` Yalda via ffmpeg-devel [this message]
2026-01-26 19:09   ` [FFmpeg-devel] " Nariman Sayed via ffmpeg-devel
2026-01-26 19:21   ` Devin Heitmueller via ffmpeg-devel
2026-01-26 20:15     ` Yalda via ffmpeg-devel
2026-01-28 15:27       ` Devin Heitmueller via ffmpeg-devel
2026-01-31  0:40         ` Yalda via ffmpeg-devel
2026-01-31 15:00           ` Devin Heitmueller via ffmpeg-devel
2026-02-10 15:24             ` Yalda via ffmpeg-devel
2026-02-11 13:51               ` Devin Heitmueller via ffmpeg-devel
2026-02-17 20:56                 ` Nariman Sayed via ffmpeg-devel
2026-02-18  3:28                   ` Yalda via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAhd_PVCGmXSOB3P43rAF0cXE73n14s0URzjBktLLr5L0zbCKw@mail.gmail.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=marth64@proxyid.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git