[FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Thinh Nguyen]

Signed-off-by: Thinh Nguyen <nguyenhuuthinh1997@gmail.com>
---
 libavcodec/hevcdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index d6be8140ff..c8776e9e9d 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -2779,7 +2779,7 @@ static int set_side_data(HEVCContext *s)
             s->sei.common.content_light.present--;
     }
 
-    ret = ff_h2645_sei_to_frame(out, &s->sei.common, AV_CODEC_ID_HEVC, NULL,
+    ret = ff_h2645_sei_to_frame(out, &s->sei.common, AV_CODEC_ID_HEVC, s->avctx,
                                 &s->ps.sps->vui.common,
                                 s->ps.sps->bit_depth, s->ps.sps->bit_depth_chroma,
                                 s->ref->poc /* no poc_offset in HEVC */);
-- 
2.43.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Marth64]

Hello,
Patch fails to apply (looks like a rebase needed since I see the path
of hevcdec.c is older).
Also a sample or context to trigger the condition would be nice to validation.
Thank you
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Thinh Nguyen Huu]

Hello.
I discovered this issue while using the *release/6.1* branch.
Could you try applying the patch on this branch?

On Fri, Feb 7, 2025 at 11:10 AM Marth64 <marth64@proxyid.net> wrote:

> Hello,
> Patch fails to apply (looks like a rebase needed since I see the path
> of hevcdec.c is older).
> Also a sample or context to trigger the condition would be nice to
> validation.
> Thank you
>


-- 
NGUYEN HUU THINH
Phone: 0978813120
Email: nguyenhuuthinh1997@gmail.com
___ University Of Science - VNUHCM ___
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Marth64]

Hello,
Yes I can, thanks for sharing that.
Can you share a sample or steps to reproduce?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Marth64]

Yes, confirmed
Looks like its only present on 6.1. In 7.0+ it is fixed by
d9f1b321cf58a85518d29c5a3d220d67b1a68b92 (which is the same change)
If there is no objection I'll back port that commit in the next few days.

Thanks Thinh.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Marth64]

Planning to backport in 48-72 hours
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[James Almer]

[-- Attachment #1.1.1: Type: text/plain, Size: 132 bytes --]

On 2/7/2025 12:46 PM, Marth64 wrote:
> Planning to backport in 48-72 hours
Backporting it is obviously ok, so no need to wait.


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Marth64]

Re: James
> Backporting it is obviously ok, so no need to wait.
Good deal, will take care of it shortly.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties

[Marth64]

Backported to 6.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".