Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

[Yalda <marth64@proxyid.net>]

Nicolas George:
> Approval full stop is [********]. The only approval worth something comes
> from somebody who knows the code.
>
> How do you know that approval was worth anything?
>
> So as a default, they are maintained by whoever maintains libavfilter

----

I was the one who approved this PR.

I’ve had a high tolerance for remarks like yours, but I will not stand
by anymore as you question the competence of contributors without cause,
a pattern which does nothing but drive people away.

For the record:
1) I reviewed the PR in full, understood the changes, and stand by my
approval.

2) Gatekeeping over trivial or clearly beneficial patches harms the project
and drives contributors away. The only “gain” from it is polishing one’s
own ego.

3) I do not give blind approvals. I am more than capable of understanding,
implementing, and approving changes at and beyond the scope here.
Suggesting otherwise is an insult to my intelligence which I will not
accept.

And since we are being direct: your recent contributions to this project
consist largely of criticizing others without offering substantive
technical work yourself. Even minor contributors today are more in tune
with the project’s direction.

If there are genuine, technical objections to this PR, let’s address them
directly. Otherwise, undermining contributors without adding value only
hurts FFmpeg and the community at large.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".