* [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties @ 2025-02-05 6:27 Thinh Nguyen 2025-02-07 4:09 ` Marth64 0 siblings, 1 reply; 9+ messages in thread From: Thinh Nguyen @ 2025-02-05 6:27 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Thinh Nguyen Signed-off-by: Thinh Nguyen <nguyenhuuthinh1997@gmail.com> --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index d6be8140ff..c8776e9e9d 100644 --- a/libavcodec/hevcdec.c +++ b/libavcodec/hevcdec.c @@ -2779,7 +2779,7 @@ static int set_side_data(HEVCContext *s) s->sei.common.content_light.present--; } - ret = ff_h2645_sei_to_frame(out, &s->sei.common, AV_CODEC_ID_HEVC, NULL, + ret = ff_h2645_sei_to_frame(out, &s->sei.common, AV_CODEC_ID_HEVC, s->avctx, &s->ps.sps->vui.common, s->ps.sps->bit_depth, s->ps.sps->bit_depth_chroma, s->ref->poc /* no poc_offset in HEVC */); -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-05 6:27 [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties Thinh Nguyen @ 2025-02-07 4:09 ` Marth64 2025-02-07 5:16 ` Thinh Nguyen Huu 0 siblings, 1 reply; 9+ messages in thread From: Marth64 @ 2025-02-07 4:09 UTC (permalink / raw) To: FFmpeg development discussions and patches; +Cc: Thinh Nguyen Hello, Patch fails to apply (looks like a rebase needed since I see the path of hevcdec.c is older). Also a sample or context to trigger the condition would be nice to validation. Thank you _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-07 4:09 ` Marth64 @ 2025-02-07 5:16 ` Thinh Nguyen Huu 2025-02-07 5:22 ` Marth64 0 siblings, 1 reply; 9+ messages in thread From: Thinh Nguyen Huu @ 2025-02-07 5:16 UTC (permalink / raw) To: Marth64; +Cc: FFmpeg development discussions and patches Hello. I discovered this issue while using the *release/6.1* branch. Could you try applying the patch on this branch? On Fri, Feb 7, 2025 at 11:10 AM Marth64 <marth64@proxyid.net> wrote: > Hello, > Patch fails to apply (looks like a rebase needed since I see the path > of hevcdec.c is older). > Also a sample or context to trigger the condition would be nice to > validation. > Thank you > -- NGUYEN HUU THINH Phone: 0978813120 Email: nguyenhuuthinh1997@gmail.com ___ University Of Science - VNUHCM ___ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-07 5:16 ` Thinh Nguyen Huu @ 2025-02-07 5:22 ` Marth64 [not found] ` <CAJvo+G=7bB_DGuKaVmDtMeybhjx7y8493ohk45bGb=ZsQP+Wyg@mail.gmail.com> 0 siblings, 1 reply; 9+ messages in thread From: Marth64 @ 2025-02-07 5:22 UTC (permalink / raw) To: Thinh Nguyen Huu; +Cc: FFmpeg development discussions and patches Hello, Yes I can, thanks for sharing that. Can you share a sample or steps to reproduce? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <CAJvo+G=7bB_DGuKaVmDtMeybhjx7y8493ohk45bGb=ZsQP+Wyg@mail.gmail.com>]
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties [not found] ` <CAJvo+G=7bB_DGuKaVmDtMeybhjx7y8493ohk45bGb=ZsQP+Wyg@mail.gmail.com> @ 2025-02-07 5:49 ` Marth64 2025-02-07 15:46 ` Marth64 0 siblings, 1 reply; 9+ messages in thread From: Marth64 @ 2025-02-07 5:49 UTC (permalink / raw) To: Thinh Nguyen Huu; +Cc: FFmpeg development discussions and patches Yes, confirmed Looks like its only present on 6.1. In 7.0+ it is fixed by d9f1b321cf58a85518d29c5a3d220d67b1a68b92 (which is the same change) If there is no objection I'll back port that commit in the next few days. Thanks Thinh. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-07 5:49 ` Marth64 @ 2025-02-07 15:46 ` Marth64 2025-02-07 15:51 ` James Almer 0 siblings, 1 reply; 9+ messages in thread From: Marth64 @ 2025-02-07 15:46 UTC (permalink / raw) To: Thinh Nguyen Huu; +Cc: FFmpeg development discussions and patches Planning to backport in 48-72 hours _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-07 15:46 ` Marth64 @ 2025-02-07 15:51 ` James Almer 2025-02-07 16:03 ` Marth64 0 siblings, 1 reply; 9+ messages in thread From: James Almer @ 2025-02-07 15:51 UTC (permalink / raw) To: ffmpeg-devel [-- Attachment #1.1.1: Type: text/plain, Size: 132 bytes --] On 2/7/2025 12:46 PM, Marth64 wrote: > Planning to backport in 48-72 hours Backporting it is obviously ok, so no need to wait. [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-07 15:51 ` James Almer @ 2025-02-07 16:03 ` Marth64 2025-02-07 18:41 ` Marth64 0 siblings, 1 reply; 9+ messages in thread From: Marth64 @ 2025-02-07 16:03 UTC (permalink / raw) To: FFmpeg development discussions and patches Re: James > Backporting it is obviously ok, so no need to wait. Good deal, will take care of it shortly. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties 2025-02-07 16:03 ` Marth64 @ 2025-02-07 18:41 ` Marth64 0 siblings, 0 replies; 9+ messages in thread From: Marth64 @ 2025-02-07 18:41 UTC (permalink / raw) To: FFmpeg development discussions and patches Backported to 6.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-02-07 18:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-05 6:27 [FFmpeg-devel] [PATCH] lavc/hevcdec: fix crash when ff_h2645_sei_to_frame modifies avctx->properties Thinh Nguyen
2025-02-07 4:09 ` Marth64
2025-02-07 5:16 ` Thinh Nguyen Huu
2025-02-07 5:22 ` Marth64
[not found] ` <CAJvo+G=7bB_DGuKaVmDtMeybhjx7y8493ohk45bGb=ZsQP+Wyg@mail.gmail.com>
2025-02-07 5:49 ` Marth64
2025-02-07 15:46 ` Marth64
2025-02-07 15:51 ` James Almer
2025-02-07 16:03 ` Marth64
2025-02-07 18:41 ` Marth64
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git