From: David Johansen <davejohansen@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio
Date: Thu, 28 Dec 2023 15:49:29 -0700
Message-ID: <CAAcYxUdhOqUa6=dWdpYkjJNEs8x5f-XR90KUKRNRoi_nq_ctdA@mail.gmail.com> (raw)
In-Reply-To: <CADxeRwkueJ+i0eto7OUvCkXFcBxLFn7CoEMipR8re0Eq20noRw@mail.gmail.com>
On Wed, Nov 8, 2023 at 6:38 PM Steven Liu <lingjiujianke@gmail.com> wrote:
> David Johansen <davejohansen@gmail.com> 于2023年11月9日周四 07:47写道:
> >
> > On Fri, Oct 27, 2023 at 1:33 AM Steven Liu <lingjiujianke@gmail.com>
> wrote:
> >
> > > David Johansen <davejohansen@gmail.com> 于2023年10月27日周五 12:03写道:
> > > >
> > > > >
> > > > > LGTM
> > > > >
> > > > >
> > > > > Thanks
> > > > > Steven
> > > > >
> > > >
> > > > I'm new to ffmpeg development so what's the process for this to be
> > > merged?
> > > > Do I need to do something or is it taken care of by a different
> > > > process/someone else?
> > >
> > > Nothing, just leave enough time for more developers review, and will
> > > push this if no more comments.
> > > Don't worry David, this is valuable patch, you did a great job.
> > >
> >
> > I submitted a handful of patches and I believe I've addressed all of
> > the feedback I've seen, so is there anything I need to do to follow up on
> > them and get them merged?
> Will apply this patch after 24 hours if there have no more comments.
>
Thanks for applying this patch. I submitted a handful of other patches for
HLS so can those be merged as well?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-28 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 1:43 Dave Johansen
2023-10-27 2:53 ` Steven Liu
2023-10-27 4:02 ` David Johansen
2023-10-27 7:32 ` Steven Liu
2023-10-27 20:18 ` David Johansen
2023-11-08 23:47 ` David Johansen
2023-11-09 1:37 ` Steven Liu
2023-12-28 22:49 ` David Johansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAcYxUdhOqUa6=dWdpYkjJNEs8x5f-XR90KUKRNRoi_nq_ctdA@mail.gmail.com' \
--to=davejohansen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git