From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 12F804367B for ; Sat, 20 Aug 2022 09:57:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D7A968B972; Sat, 20 Aug 2022 12:57:26 +0300 (EEST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C23E68B69E for ; Sat, 20 Aug 2022 12:57:20 +0300 (EEST) Received: by mail-lj1-f178.google.com with SMTP id l19so3367268ljg.8 for ; Sat, 20 Aug 2022 02:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=+GU+9GP1fMYJ0IWbNUBL+5mMJ2q5AYE6QW9cCyxO0zA=; b=mvNDFu44DMU6QmoEqaFoMk1bDEWdlP+Nv/qDXrpgR0629jjUj/obE8b+6Xyd0nRIpj I5spDhTSoAWDmMcQafsld87w7c2suJXNrtYHogJxvsD9o3hGYOMhzwoi2fmfiitLQFSG yPHFonWxCb4HQxBuPW/d6m+bvxSjM/AaPTN0eF95rFyB6lo+ZFsm0AyVZbDtFijs9hkf WfDUq6c4XrGeLI0llX70c1Kj+S4WjIVNcHzve/o6+HedNlwZF2iremQ459NmD7cR7I65 wY1ZbByvCFLH0irfLto2hlyT/S+XXemK/dpkHaVp32TOZwhVV5z2seh409jVxanSytVt zcbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=+GU+9GP1fMYJ0IWbNUBL+5mMJ2q5AYE6QW9cCyxO0zA=; b=jmpOI1PXEjFXBOlnV7QhnNjhYKSTfbJ3g2xoMhgDGKcFtzbNC+8ymulv6a59nV3iHD p0ZIbX2+SydidwIl2H2lupN4RxiuYVLxPijvRmNtnSe01DwYdz5kYNQpZzc/N0uokT5B ZhD66ScgnYqeNJl5+ymQ8ZWBKdeqWuQwylg3VQVgU31rzImmzxEaUlXVMBZ7oJGhqlYA Rlr37cu10p9IICDO4VK+nPJ7OPiiIl+b1E3k7MqA/xVIfVY1NXaj+lJ0yHmisY50QsoQ vqJbLUqlXbT/DXq0GcLna0PkXz/emJ3xR6+DmVeaewxhNVXsilRCFzTHaZnZV0V3LMQb yZmA== X-Gm-Message-State: ACgBeo3MsuUWeHtS8z4dbghXZ9dQpCcuBKZ6s+L1qHUlye/tAiOIGliS 7UKJgoJ3gt2BQOCQ1KnZzGuaPgBglrXWww9dytZ9WFfo X-Google-Smtp-Source: AA6agR7u+UijP7hgZdCUkzZbGC0mDcc65h2vP0Jf6fJmMruItuFafjqXh7m8jUSX8RjUm3spTwYJwhUAOihuISeL7/E= X-Received: by 2002:a2e:2e1a:0:b0:25e:4c40:48f4 with SMTP id u26-20020a2e2e1a000000b0025e4c4048f4mr3052424lju.421.1660989439146; Sat, 20 Aug 2022 02:57:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: jagad hariseno Date: Sat, 20 Aug 2022 16:57:06 +0700 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Possibly a little bug in af_loudnorm.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: yes you're right. Thanks for your fast response Best Regards jagad On Sat, Aug 20, 2022 at 4:53 PM Jack Waller wrote: > Please check the code:line 209 > > if (c == 0 || fabs(buf[index + c]) > max_peak) > max_peak = fabs(buf[index + c]); > > 'max_peak' is initialized. > > > On Sat, Aug 20, 2022 at 5:39 PM jagad hariseno > wrote: > > > Hi All, > > > > at af_loudnorm.c in line number 188: > > double this, next, max_peak; > > > > max_peak is not initialized with 0. and could be contains any value or > > noise. > > I could be wrong but I think init with 0. should be better: > > > > double this, next, max_peak=0.; > > > > Best Regards > > > > jagad. > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".