From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A8D9042061 for ; Mon, 21 Feb 2022 15:22:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CDCB68AF80; Mon, 21 Feb 2022 17:22:27 +0200 (EET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 33EB0680C3F for ; Mon, 21 Feb 2022 17:22:16 +0200 (EET) Received: by mail-pf1-f180.google.com with SMTP id d187so9151576pfa.10; Mon, 21 Feb 2022 07:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=d3HWUMsvSF64WWSU40o5obRj6/E1Wthvpf/0or6w92Y=; b=Is8pdHKQaVy5qN0JMU7ZKlWBlS92Dedz6JmPs20nXJ3vSdW9fC9n5EAntH/4PCJmW3 Ce8akV2L5ZLwwFphHA4CAz8WedKb292cWSHIkxUNqSjPbul737bu4OESj3WsoMtpb47V D7jUF6+qyuQ54hjkjlYrGQ7xWksxd4zHgSR0aU5b/2D8NLBMtgrABqGDNq+sCEWcVSSH 2ZvQQkySqdx99HD1CSPecTDu/QbOKbZZp+Zi0UoRqblbBqtg2E8Tq8xUrYxQo3oC2h14 kYWtGYweu71R/6j5DRuLseMN4981oPcuZcdxM+ei0KPwW99cYBaTgYk8si0fKTZSHEVo pTJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=d3HWUMsvSF64WWSU40o5obRj6/E1Wthvpf/0or6w92Y=; b=C/czlt9ICY2AI+ik4tE6dnXxzF+j/qk8EjpZ4vYm2Y3RCcA7Y+f7k7QrZr4FzzTgh2 dpwqSEMcwtOkfWPMTjxdcadXgV+XuqEHnoC9q85YP6BVB9kpySyr4okp2qi0vNVKz6A5 bDkB2QC6hWMdbfZ0eBfVFR9TqTh2SH7Hs7NUU8sYHFMK7i8fxZuzGtl5P7Ju/obEMZHQ iTcr/6oGJ1gSbW/N7U1CXdNZ3VwMniWW3Am9wonEyMC7FjF3gWXTQrD9N4RNrJAkhATC U4tOmk6gC33wWNQmCXeO5Opf98NXz3FD+gZteWaTnXgaKgV0PU8FzEek5qz3BELypBea 7I7A== X-Gm-Message-State: AOAM530raAbPBfl9FZtAaHwgSV6sr8l7AB6Ansn0uBGMvVJffo4HETCY AIHvOO5q3zdbqBmbJxfjpWMHI/1KLHEOt780JCgE2KxGw+VMnw== X-Google-Smtp-Source: ABdhPJyCyU83rdPYtQAojI1sRDkPOlSAbfkmbBGkelQHjNYg+yTijgQ79pII9AjfoqljuVVl9Sx2YYVqWRhIloULkd4= X-Received: by 2002:a05:6a00:15c6:b0:4f0:ecec:8214 with SMTP id o6-20020a056a0015c600b004f0ecec8214mr15595001pfu.33.1645456933625; Mon, 21 Feb 2022 07:22:13 -0800 (PST) MIME-Version: 1.0 References: <20220221082055.1526-1-Victoria.Zhislina@intel.com> <164544253625.19727.14104805163737761889@lain.red.khirnov.net> In-Reply-To: <164544253625.19727.14104805163737761889@lain.red.khirnov.net> From: Victoria Zhislina Date: Mon, 21 Feb 2022 18:22:02 +0300 Message-ID: To: FFmpeg development discussions and patches , Victoria Zhislina X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, Anton. Thanks for your input. But the patch does the single thing described in the commit message - improves performance >4 :) Sorry. This patch creation is based on real experience and on real measurement. Please notice I don't write ">40x" so it is not an advertisement :). Right you are, under the hood it does 2 main things and one small additional one combined to achieve the performance gain mentioned in the commit message :) However the changes are extremely local - they cover just a couple of functions in a single file and It doesn't make sense to split them. It seems to me split will make ffmpeg-devel mail list and ffmpeg git log dirtier, not cleaner. So let's wait for the Paul B Mahol opinion - it is his code that I've modified. On Mon, Feb 21, 2022 at 2:22 PM Anton Khirnov wrote: > > libavfilter: zscale performance optimization >4x > > This reads like an advertisement rather than a useful description. It > should say what the patch does, performance improvement numbers should > be mentioned in the commit message body. > > Quoting Victoria Zhislina (2022-02-21 09:20:55) > > By ffmpeg threading support implementation via frame slicing and doing > > zimg_filter_graph_build that used to take 30-60% of each frame processig > > only if necessary (some parameters changed) > > the performance increase vs original version > > in video downscale and color conversion >4x is seen > > on 64 cores Intel Xeon, 3x on i7-6700K (4 cores with HT) > > This implies the patch does multiple unrelated things. Then it should be > split in multiple patches, unless some important factor prevents that > (then that factor should be described in the commit message). > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".