Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Russell Greene <russellgreene8@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers
Date: Sat, 3 May 2025 10:29:28 -0600
Message-ID: <CAAOCm6qAHu+7XwwSo7FvKxYR0kmWuGqzvgBc2dLFJxOavaUDvw@mail.gmail.com> (raw)
In-Reply-To: <CAAOCm6qOQgsteyHgu0XG222B5XtMgo6J8J+W6vSRZDSev5nmww@mail.gmail.com>

Now realizing that there's not really a way to just query all
modifiers, you'd actually need to query all formats for their
modifiers...

Options as I see it are:
1. in init(), create a table of all (vk_format, modifier) pairs and
the `VkDrmFormatModifierPropertiesEXT` information about the pair for
fast lookup during the map code
2. the patch i've already suggested
3. don't support drivers with more than X modifiers per format
4. have a slow path for driver with more than that X modifiers per format

Or maybe some other options I'm not seeing?

> ...that's exactly what I posted.
> Set array to non-NULL, set nb to the array size you're giving it, and
> you'll get UP TO nb, no more, even if the driver has more.

Right, but what if the modifier you need info on is after nb?

On Sat, May 3, 2025 at 10:11 AM Russell Greene <russellgreene8@gmail.com> wrote:
>
> > > If we're OK with a practical "we don't support drivers with more than
> > > X modifiers because we doubt it'll ever exist" then that's a valid
> > > answer as well.
> > If that's your concern, just fetch all info for all modifiers in the
> > init function.
>
> Works for me. I'm new to ffmpeg devel, I assume I should write a v2
> and send it to this list?
>
> Also, apologies for my mailing list sins (top posting, failing to
> reply to the correct message)
>
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-05-03 16:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-01  5:05 Russell Greene
2025-05-02  0:09 ` Lynne
2025-05-03  2:39   ` Russell Greene
2025-05-03  7:24     ` Lynne
2025-05-03 15:01       ` Russell Greene
2025-05-03 15:24         ` Lynne
2025-05-03 16:11           ` Russell Greene
2025-05-03 16:29             ` Russell Greene [this message]
2025-05-10 14:56               ` Russell Greene
  -- strict thread matches above, loose matches on Subject: below --
2025-04-29 20:33 Russell Greene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAOCm6qAHu+7XwwSo7FvKxYR0kmWuGqzvgBc2dLFJxOavaUDvw@mail.gmail.com \
    --to=russellgreene8@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git