From: James Dutton <james.dutton@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/segment: strftime date sub-directories
Date: Tue, 21 Dec 2021 21:45:46 +0000
Message-ID: <CAAMvbhEb_NxHMo6iVxwcP_8XtV=D6mb3bLbN9jsazAxbZXASig@mail.gmail.com> (raw)
In-Reply-To: <CAAMvbhFbaW2Nv81hd4TeJ=OwchczZvJ_ydNqKO7eo2u2xuHROg@mail.gmail.com>
Hi,
This is a follow on from:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/CAAMvbhG9QsKSXfUzrt3REsRR89J5scYd84ec6OLEARqx4CUD-A@mail.gmail.com/
On Tue, 21 Dec 2021 at 21:39, James Dutton <james.dutton@gmail.com> wrote:
>
> Automatically create sub-directories if needed based on date.
> E.g.
> ffmpeg ... -timelimit 2147483647 -f segment -strftime 1 -segment_time
> 10 "%Y/%m/%d/%Y-%m-%d_%H-%M-%S.mkv"
>
> Signed-off-by: James Courtier-Dutton <james.dutton@gmail.com>
> ---
> libavformat/segment.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/libavformat/segment.c b/libavformat/segment.c
> index e9b0aa4fa8..86ca243ae6 100644
> --- a/libavformat/segment.c
> +++ b/libavformat/segment.c
> @@ -198,12 +198,27 @@ static int set_segment_filename(AVFormatContext *s)
> if (seg->use_strftime) {
> time_t now0;
> struct tm *tm, tmpbuf;
> + const char *dir;
> + char *fn_copy;
> time(&now0);
> tm = localtime_r(&now0, &tmpbuf);
> if (!strftime(buf, sizeof(buf), s->url, tm)) {
> av_log(oc, AV_LOG_ERROR, "Could not get segment filename
> with strftime\n");
> return AVERROR(EINVAL);
> }
> + /* Automatically create directories if needed */
> + /* E.g. %Y/%m/%d/%Y-%m-%d_%H-%M-%S.mkv */
> + fn_copy = av_strdup(buf);
> + if (!fn_copy) {
> + return AVERROR(ENOMEM);
> + }
> + dir = av_dirname(fn_copy);
> + if (ff_mkdir_p(dir) == -1 && errno != EEXIST) {
> + av_log(oc, AV_LOG_ERROR, "Could not create directory %s
> with use_localtime_mkdir\n", dir);
> + av_free(fn_copy);
> + return AVERROR(errno);
> + }
> + av_free(fn_copy);
> } else if (av_get_frame_filename(buf, sizeof(buf),
> s->url, seg->segment_idx) < 0) {
> av_log(oc, AV_LOG_ERROR, "Invalid segment filename template
> '%s'\n", s->url);
> --
> 2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2021-12-21 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 21:39 James Dutton
2021-12-21 21:45 ` James Dutton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAMvbhEb_NxHMo6iVxwcP_8XtV=D6mb3bLbN9jsazAxbZXASig@mail.gmail.com' \
--to=james.dutton@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git