From: Wang Bin <wbsecg1@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/vvc/vvcdsp_init: fix unresolved external symbol on ARCH_X86_32
Date: Wed, 7 Feb 2024 17:47:32 +0800
Message-ID: <CAA4bkHaSWKZ5OZrUtrLNRTY9CgHemm47dfkJKB+uRKqkCrAyyA@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB0744F28876159F87A664B5E88F472@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Andreas Rheinhardt <andreas.rheinhardt@outlook.com> 于2024年2月5日周一 20:04写道：
> toqsxw@outlook.com:
> > From: Wu Jianhua <toqsxw@outlook.com>
> >
> > Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
> > ---
> > libavcodec/x86/vvc/vvcdsp_init.c | 78 ++++++++++++++++----------------
> > 1 file changed, 40 insertions(+), 38 deletions(-)
> >
> > diff --git a/libavcodec/x86/vvc/vvcdsp_init.c
> b/libavcodec/x86/vvc/vvcdsp_init.c
> > index 909ef9f56b..8ee4074350 100644
> > --- a/libavcodec/x86/vvc/vvcdsp_init.c
> > +++ b/libavcodec/x86/vvc/vvcdsp_init.c
> > @@ -31,6 +31,7 @@
> > #include "libavcodec/vvc/vvcdsp.h"
> > #include "libavcodec/x86/h26x/h2656dsp.h"
> >
> > +#if ARCH_X86_64
> > #define FW_PUT(name, depth, opt) \
> > static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst,
> const uint8_t *src, ptrdiff_t srcstride, \
> > int height, const
> int8_t *hf, const int8_t *vf, int width) \
> > @@ -204,51 +205,52 @@ AVG_FUNCS(16, 12, avx2)
> > c->inter.avg = bf(avg, bd, opt);
> \
> > c->inter.w_avg = bf(w_avg, bd, opt);
> \
> > } while (0)
> > +#endif
> >
> > void ff_vvc_dsp_init_x86(VVCDSPContext *const c, const int bd)
> > {
> > +#if ARCH_X86_64
> > const int cpu_flags = av_get_cpu_flags();
> >
> > - if (ARCH_X86_64) {
> > - if (bd == 8) {
> > - if (EXTERNAL_SSE4(cpu_flags)) {
> > - MC_LINK_SSE4(8);
> > - }
> > - if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> > - MC_LINKS_AVX2(8);
> > - }
> > - } else if (bd == 10) {
> > - if (EXTERNAL_SSE4(cpu_flags)) {
> > - MC_LINK_SSE4(10);
> > - }
> > - if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> > - MC_LINKS_AVX2(10);
> > - MC_LINKS_16BPC_AVX2(10);
> > - }
> > - } else if (bd == 12) {
> > - if (EXTERNAL_SSE4(cpu_flags)) {
> > - MC_LINK_SSE4(12);
> > - }
> > - if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> > - MC_LINKS_AVX2(12);
> > - MC_LINKS_16BPC_AVX2(12);
> > - }
> > + if (bd == 8) {
> > + if (EXTERNAL_SSE4(cpu_flags)) {
> > + MC_LINK_SSE4(8);
> > }
> > + if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> > + MC_LINKS_AVX2(8);
> > + }
> > + } else if (bd == 10) {
> > + if (EXTERNAL_SSE4(cpu_flags)) {
> > + MC_LINK_SSE4(10);
> > + }
> > + if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> > + MC_LINKS_AVX2(10);
> > + MC_LINKS_16BPC_AVX2(10);
> > + }
> > + } else if (bd == 12) {
> > + if (EXTERNAL_SSE4(cpu_flags)) {
> > + MC_LINK_SSE4(12);
> > + }
> > + if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> > + MC_LINKS_AVX2(12);
> > + MC_LINKS_16BPC_AVX2(12);
> > + }
> > + }
> >
> > - if (EXTERNAL_AVX2(cpu_flags)) {
> > - switch (bd) {
> > - case 8:
> > - AVG_INIT(8, avx2);
> > - break;
> > - case 10:
> > - AVG_INIT(10, avx2);
> > - break;
> > - case 12:
> > - AVG_INIT(12, avx2);
> > - break;
> > - default:
> > - break;
> > - }
> > + if (EXTERNAL_AVX2(cpu_flags)) {
> > + switch (bd) {
> > + case 8:
> > + AVG_INIT(8, avx2);
> > + break;
> > + case 10:
> > + AVG_INIT(10, avx2);
> > + break;
> > + case 12:
> > + AVG_INIT(12, avx2);
> > + break;
> > + default:
> > + break;
> > }
> > }
> > +#endif
> > }
>
> Are really all of these functions unavailable for 32bit?
>
> - Andreas
>
>
http://fate.ffmpeg.org/log.cgi?time=20240207055809&slot=x86_32-msvc14-dll-md-windows-native&log=compile
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-02-07 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:59 toqsxw
2024-02-05 12:06 ` Andreas Rheinhardt
2024-02-05 12:11 ` [FFmpeg-devel] 回复: " Wu Jianhua
2024-02-07 10:02 ` Andreas Rheinhardt
2024-02-07 14:58 ` Nuo Mi
2024-02-07 9:47 ` Wang Bin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4bkHaSWKZ5OZrUtrLNRTY9CgHemm47dfkJKB+uRKqkCrAyyA@mail.gmail.com \
--to=wbsecg1@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git