From: Wang Bin <wbsecg1@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/pthread_frame: avoid leaving stale hwaccel state in worker threads
Date: Mon, 12 Sep 2022 10:02:27 +0800
Message-ID: <CAA4bkHZtNFVOdwT45hdgyBpRYB6wPoOfmpUAU19cLaZuOZRiiA@mail.gmail.com> (raw)
In-Reply-To: <20220903183930.9223-2-anton@khirnov.net>
>
>
> av_packet_unref(p->avpkt);
> @@ -655,6 +670,14 @@ void ff_thread_finish_setup(AVCodecContext *avctx) {
> async_lock(p->parent);
> }
>
> + /* save hwaccel state for passing to the next thread;
> + * this is done here so that this worker thread can wipe its own
> hwaccel
> + * state after decoding, without requiring synchronization */
> + av_assert0(!p->parent->stash_hwaccel);
> + p->parent->stash_hwaccel = avctx->hwaccel;
> + p->parent->stash_hwaccel_context = avctx->hwaccel_context;
> + p->parent->stash_hwaccel_priv = avctx->internal->hwaccel_priv_data;
>
Assertion failure when seeking. Step to reproduce:
./ffmpeg -stream_loop -1 -an -hwaccel vaapi -i test.mp4 -f null >/dev/null
Regards
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-12 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 20:59 [FFmpeg-devel] [PATCH] " Anton Khirnov
2022-09-02 21:12 ` Andreas Rheinhardt
2022-09-03 18:25 ` Anton Khirnov
2022-09-03 18:39 ` [FFmpeg-devel] [PATCH 1/2] lavc: fix and extend AVCodecContext.hwaccel_context doxy Anton Khirnov
2022-09-03 18:39 ` [FFmpeg-devel] [PATCH 2/2] lavc/pthread_frame: avoid leaving stale hwaccel state in worker threads Anton Khirnov
2022-09-12 2:02 ` Wang Bin [this message]
2022-09-12 6:59 ` Wang Bin
2022-09-15 8:12 ` Marvin Scholz
2022-09-05 5:42 ` [FFmpeg-devel] [PATCH] " Steve Lhomme
2022-09-05 5:53 ` Anton Khirnov
2022-09-05 19:36 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA4bkHZtNFVOdwT45hdgyBpRYB6wPoOfmpUAU19cLaZuOZRiiA@mail.gmail.com \
--to=wbsecg1@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git