Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

From: Steven Hartland <stevenmhartland@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata
Date: Thu, 14 Jul 2022 22:46:59 +0100
Message-ID: <CAA38peZLNSg45-n7hfKRegxwhmRoKetaGewkGArAw8ef1=+xag@mail.gmail.com> (raw)
In-Reply-To: <CAA38peYs4XDY96WNy6ctA8pSGLxL_TxPQVsZWisMi5rEj8=Avw@mail.gmail.com>

Any thoughts on my previous reply?

On Mon, 4 Jul 2022 at 23:33, Steven Hartland <stevenmhartland@gmail.com>
wrote:

> I'm not sure we're on the same page, so let me try and clarify.
>
> The files have multiple tracks, the standard audio and video and 3
> metadata tracks. I'm using the command line option -map
> 0:m:handler_name:"<name>" to identify the tracks to copy. Given a single
> file this works as expected, but as soon as concat has multiple files the
> track metadata is lost and the handler_name match fails due to this early
> return.
>
> Each of the tracks I'm selected are able to be concatenated just fine,
> much like the a/v tracks. It's not about the file metadata, it's the track
> metadata which is needed for track identification which I'm looking to
> preserve.
>
> Does that make sense?
>
>    Regards
>    Steve
>
> On Sun, 3 Jul 2022 at 14:50, Nicolas George <george@nsup.org> wrote:
>
>> Andreas Rheinhardt (12022-07-03):
>> > > For example, with your change, if you concatenate a file with metadata
>> > > "start_time=12:00" and another with "start_time=12:01", it will
>> generate
>> > > a file with both metadata entries instead of just the first one as
>> would
>> > > be desirable.
>>
>> > Actually, the newer entry will overwrite the older entry; if you want
>> > multiple keys with the same value, you have to use the AV_DICT_MULTIKEY
>> > flag.
>>
>> I stand corrected, thanks. This is still not the most logical behavior,
>> though.
>>
>> Regards,
>>
>> --
>>   Nicolas George
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".