From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 51F6749A25 for ; Wed, 27 Mar 2024 16:48:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BE5268D693; Wed, 27 Mar 2024 18:48:28 +0200 (EET) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C06B868D056 for ; Wed, 27 Mar 2024 18:48:21 +0200 (EET) Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-430d3fcc511so5021cf.1 for ; Wed, 27 Mar 2024 09:48:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711558100; x=1712162900; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nt3GYDj0sriZTv7s+Ew6Te2xaZrT9WVj/ETxfWtAhA8=; b=oEx9DmAytPOu1k+iN37JqjG433Q7bPGGJoryWq2UVgimYztQtB/TOS2MojmttIteqg VxQN6FxwXH3CiRnF4NIK2OLfGvEcw5ah1no2ze+kKuU11CEfKxdFu43avugB0jwY8OQA /eIKol87aGUnYbgXS9VEX93YD2sKeYXvFRtbs1Ba5GTGs9SKgLXI0nMBc3J272LMOP9H /1kz3JAfohg1eQzE3RMcFJCUR6ZfiM4vZDuTMcF7NJ8p6XKsD8GwZWcVA6nYOSVyNQkR Japneqz6rcS7t9/ZUrNInjhCaY/ZGSW4/HATs4NwGlTaK1o63H/fMr0dQm2ZzhcHimjB imdA== X-Gm-Message-State: AOJu0YzXjtwYQm/PTSEaH7oBVPn1b76CBJExJuQwQlzmJlaXDhiycvr9 oNrPdYsapwZ/bZm09ntjiqgAr0Tc6jTvKhvcEE8rRirtwi9O+Xvh0zYG1EnW4EDsUs92p6+HIWR PPJHVvqgebUasmGCuDnVAWVTsBOFarciGfyAQ4oGaEF/wB4Cu1SuL X-Google-Smtp-Source: AGHT+IFE1rilu7GeKY9F33KCn6PDi7sTkEVubMpgESOjRAM7pUEJZikaYaD0bcTTwl4F5+C0+ZaD9y8MMzuvbJfIOkY= X-Received: by 2002:a05:622a:4288:b0:42f:3b05:dc8f with SMTP id cr8-20020a05622a428800b0042f3b05dc8fmr207392qtb.8.1711558100226; Wed, 27 Mar 2024 09:48:20 -0700 (PDT) MIME-Version: 1.0 References: <20240326230757.282319-1-asoulier@google.com> <20240326230757.282319-2-asoulier@google.com> In-Reply-To: Date: Wed, 27 Mar 2024 09:48:09 -0700 Message-ID: To: FFmpeg development discussions and patches , Antoine Soulier X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Antoine Soulier via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Antoine Soulier Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: do you need to reset/free the encoder in case of failure? If this is > the case you need to unset/free here or in the close function Nothing to do with the encoder in case of failure. It just initializes the given buffer, and returns it. BTW, the only failure condition is bad parameters, already checked by `lc3_hr_encoder_size()`. Perhaps I can just remove the check of the returned value. can this fail? Can just fail on bad parameters, the size of frames `frame_bytes` has been checked by `lc3_hr_frame_block_bytes()`. Looks safe to me. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".