From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 89AF64A3F8 for ; Wed, 27 Mar 2024 16:52:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1AF3F68D6AC; Wed, 27 Mar 2024 18:52:42 +0200 (EET) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D577368C830 for ; Wed, 27 Mar 2024 18:52:35 +0200 (EET) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-430d3fcc511so6631cf.1 for ; Wed, 27 Mar 2024 09:52:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711558354; x=1712163154; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fD9yBLhsznCDVOl1BiV1bn+nvZmH5MYmHI7DTkVsYU8=; b=naA5Wz5Xv6cpwZkUI3AJw/dk0rHJqbRfJRCqUHv7le05tgaNv/ENzbcpPpC9MKeCX/ UeDCPpfy2p3/86GUXT+zO9WoMDvkhApzP63W+b09QKVipXs812HXeQ8iRhsnLyJhhD84 BqKet6bwMRHFVOp5k0TtJJMEK92DtFq9/WKsmXL6SXICyOcqCWqMrp1ixWf42BINqpAt z/u1VRgLmq5FL/Xv1b0crk1fc+V/1JyxDXZeo54vRQDsXkKQBV4nP6IoJ2tv8It/BJHx Gh6kXiUxn3ZilTuVQAY4ArdiHY742Y/5HnqeRbOuApVYMCbejm/3JWgJed4cppIbLLro 1x8Q== X-Gm-Message-State: AOJu0Yy2xC/6mW5UVrONa94uzwNujDNb8L7f9E7nLs6jP2MMDNBwhda+ mTvdnGgom4mbqAElAz/qtrjU7rqqfyN3ZzFjOJ2AwmEa4VtrgaoxpjJFRgqUluLo2V275AGsc9h w4SVM7msakeNiVfKY16twHDuIzaOwLXM3ubrKjxme2D1Evvvsooce X-Google-Smtp-Source: AGHT+IHp2N3FDRd1j2pwt8YHmbcM+iKPIeq6sg7BIo5hzvYe7ELW1FMRA/UH6+sHZVPTYxWrs3IHzQGiV7E69Y4wSJE= X-Received: by 2002:a05:622a:4c13:b0:431:7e93:22ba with SMTP id ey19-20020a05622a4c1300b004317e9322bamr312643qtb.2.1711558354269; Wed, 27 Mar 2024 09:52:34 -0700 (PDT) MIME-Version: 1.0 References: <20240326230757.282319-1-asoulier@google.com> <20240326230757.282319-2-asoulier@google.com> In-Reply-To: Date: Wed, 27 Mar 2024 09:52:23 -0700 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Antoine Soulier via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Antoine Soulier Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > Does this function do anything else than frame_us * srate_hz / 1000? Also check the already validated parameters. Yes, I can safely replace it with "av_scale()". It seems that lc3 has a fixed blocksize. If so, you should use > ff_get_encode_buffer(). Technically the codec allows you to freely change the size on frame basis. But it's not used in this way, ack. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".