From: Antoine Soulier via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Antoine Soulier <asoulier@google.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec
Date: Wed, 27 Mar 2024 09:52:23 -0700
Message-ID: <CA+wrVdYEPoU0Vod+LumzyuxQ4c0hp8g9Kr4ONqvoqeEFdsb1dw@mail.gmail.com> (raw)
In-Reply-To: <GV1P250MB0737F1F8D5D83C3B2BA550A18F352@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
>
> Does this function do anything else than frame_us * srate_hz / 1000?
Also check the already validated parameters.
Yes, I can safely replace it with "av_scale()".
It seems that lc3 has a fixed blocksize. If so, you should use
> ff_get_encode_buffer().
Technically the codec allows you to freely change the size on frame basis.
But it's not used in this way, ack.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-27 16:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 23:07 [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper Antoine Soulier via ffmpeg-devel
2024-03-26 23:07 ` [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec Antoine Soulier via ffmpeg-devel
2024-03-26 23:32 ` Andreas Rheinhardt
2024-03-27 16:52 ` Antoine Soulier via ffmpeg-devel [this message]
2024-03-27 11:49 ` Stefano Sabatini
2024-03-27 16:48 ` Antoine Soulier via ffmpeg-devel
2024-03-26 23:07 ` [FFmpeg-devel] [PATCH 3/5] avformat/lc3: Add file format for LC3/LC3plus transport Antoine Soulier via ffmpeg-devel
2024-03-27 11:53 ` Stefano Sabatini
2024-03-27 11:55 ` Paul B Mahol
2024-03-26 23:07 ` [FFmpeg-devel] [PATCH 4/5] doc: Add LC3/LC3plus muxer and encoder parameters documentation Antoine Soulier via ffmpeg-devel
2024-03-27 11:59 ` Stefano Sabatini
2024-03-26 23:07 ` [FFmpeg-devel] [PATCH 5/5] Changelog: Add LC3/LC3plus decoding/encoding support Antoine Soulier via ffmpeg-devel
2024-03-27 11:32 ` [FFmpeg-devel] [PATCH 1/5] configure: Add option for enabling LC3/LC3plus wrapper Stefano Sabatini
-- strict thread matches above, loose matches on Subject: below --
2024-03-26 16:47 Antoine Soulier via ffmpeg-devel
2024-03-26 16:47 ` [FFmpeg-devel] [PATCH 2/5] avcodec/liblc3: Add encoding/decoding support of LC3 audio codec Antoine Soulier via ffmpeg-devel
2024-03-26 17:49 ` Stefano Sabatini
2024-03-26 18:50 ` Antoine Soulier via ffmpeg-devel
2024-03-26 18:27 ` Andreas Rheinhardt
2024-03-26 19:09 ` Antoine Soulier via ffmpeg-devel
2024-03-26 21:39 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+wrVdYEPoU0Vod+LumzyuxQ4c0hp8g9Kr4ONqvoqeEFdsb1dw@mail.gmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=asoulier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git