Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] Forgejo entry threshold
       [not found] <20250804143901.82ED768C3C2@ffbox0-bg.ffmpeg.org>
@ 2025-08-04 14:45 ` Nicolas George
  2025-08-04 14:47   ` Hendrik Leppkes
  2025-08-04 15:06   ` Leon Grutters
  0 siblings, 2 replies; 4+ messages in thread
From: Nicolas George @ 2025-08-04 14:45 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Dummy_test_user (HE12025-08-04):
> PR #20112 opened by Dummy_test_user
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20112
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20112.patch
> 
> I did that pull request to see what is preventing me from submitting crappy code.
> Apparently nothing.

Hi.

That was me. Thank you for ensuring it went to the mailing-list.

But…

I could register an account and create a pull request without ever
reading the coding-style rules in doc/developer.texi, and the pull
requests has red patcheck:

mismatching doxy params
+ * @param erbut  useless
+ * @param ernut  does nothing

That is not good.

If nothing better comes to mind to exclude crappy code, could we at
least condition creating an account to answering a 10 questions quiz
about our coding conventions?

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] Forgejo entry threshold
  2025-08-04 14:45 ` [FFmpeg-devel] Forgejo entry threshold Nicolas George
@ 2025-08-04 14:47   ` Hendrik Leppkes
  2025-08-04 14:49     ` Nicolas George
  2025-08-04 15:06   ` Leon Grutters
  1 sibling, 1 reply; 4+ messages in thread
From: Hendrik Leppkes @ 2025-08-04 14:47 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

On Mon, Aug 4, 2025 at 4:45 PM Nicolas George <george@nsup.org> wrote:
>
> Dummy_test_user (HE12025-08-04):
> > PR #20112 opened by Dummy_test_user
> > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20112
> > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20112.patch
> >
> > I did that pull request to see what is preventing me from submitting crappy code.
> > Apparently nothing.
>
> Hi.
>
> That was me. Thank you for ensuring it went to the mailing-list.
>
> But…
>
> I could register an account and create a pull request without ever
> reading the coding-style rules in doc/developer.texi,
>

Whats the barrier of entry to sending a patch to the ML right now?
Does it quiz you on the guidelines?

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] Forgejo entry threshold
  2025-08-04 14:47   ` Hendrik Leppkes
@ 2025-08-04 14:49     ` Nicolas George
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas George @ 2025-08-04 14:49 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Hendrik Leppkes (HE12025-08-04):
> Whats the barrier of entry to sending a patch to the ML right now?

Being able to, which is strongly correlated to knowing good practices.

> Does it quiz you on the guidelines?

Do you have better to propose?

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] Forgejo entry threshold
  2025-08-04 14:45 ` [FFmpeg-devel] Forgejo entry threshold Nicolas George
  2025-08-04 14:47   ` Hendrik Leppkes
@ 2025-08-04 15:06   ` Leon Grutters
  1 sibling, 0 replies; 4+ messages in thread
From: Leon Grutters @ 2025-08-04 15:06 UTC (permalink / raw)
  To: ffmpeg-devel

On 8/4/25 4:45 PM, Nicolas George wrote:
> Dummy_test_user (HE12025-08-04):
>> PR #20112 opened by Dummy_test_user
>> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20112
>> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20112.patch
>>
>> I did that pull request to see what is preventing me from submitting crappy code.
>> Apparently nothing.
> Hi.
>
> That was me. Thank you for ensuring it went to the mailing-list.
>
> But…
>
> I could register an account and create a pull request without ever
> reading the coding-style rules in doc/developer.texi, and the pull
> requests has red patcheck:
>
> mismatching doxy params
> + * @param erbut  useless
> + * @param ernut  does nothing
>
> That is not good.
>
> If nothing better comes to mind to exclude crappy code, could we at
> least condition creating an account to answering a 10 questions quiz
> about our coding conventions?
>
> Regards,
>
Is it that much harder to submit a patch on the ML? All you do is sign 
up for the ML, run one git command and then attach it to an email and 
click send.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-04 15:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20250804143901.82ED768C3C2@ffbox0-bg.ffmpeg.org>
2025-08-04 14:45 ` [FFmpeg-devel] Forgejo entry threshold Nicolas George
2025-08-04 14:47   ` Hendrik Leppkes
2025-08-04 14:49     ` Nicolas George
2025-08-04 15:06   ` Leon Grutters

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git